Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
fix(trace): record failed request durations, print request start times (#42191)
John Hill5d21e767884f
diff --git a/packages/playwright-core/src/server/har/harTracer.ts b/packages/playwright-core/src/server/har/harTracer.tsindex ecea99f27c..f24b39d6cd 100644--- a/packages/playwright-core/src/server/har/harTracer.ts+++ b/packages/playwright-core/src/server/har/harTracer.ts@@ -410,6 +410,8 @@ export class HarTracer {if (request._failureText !== null)harEntry.response._failureText = request._failureText;+ if (harEntry._monotonicTime && harEntry.time === -1)+ harEntry.time = monotonicTime() - harEntry._monotonicTime;this._recordRequestOverrides(harEntry, request);if (this._started)this._delegate.onEntryFinished(harEntry);diff --git a/packages/playwright-core/src/tools/skills/playwright-trace/SKILL.md b/packages/playwright-core/src/tools/skills/playwright-trace/SKILL.mdindex cc2e80a30b..c1da2ef591 100644--- a/packages/playwright-core/src/tools/skills/playwright-trace/SKILL.md+++ b/packages/playwright-core/src/tools/skills/playwright-trace/SKILL.md@@ -60,7 +60,7 @@ The `action` command displays available snapshot phases (before, input, after) a### Requests```bash-# All network requests: method, status, URL, duration, size+# All network requests: start time (on the `trace actions` clock), method, status, URL, duration, sizenpx playwright trace requests# Filter by URL patterndiff --git a/packages/playwright-core/src/tools/trace/traceRequests.ts b/packages/playwright-core/src/tools/trace/traceRequests.tsindex fff0046a18..c2a21e82ca 100644--- a/packages/playwright-core/src/tools/trace/traceRequests.ts+++ b/packages/playwright-core/src/tools/trace/traceRequests.ts@@ -18,7 +18,7 @@import path from 'path';import { msToString } from '@isomorphic/formatUtils';-import { loadTrace } from './traceUtils';+import { loadTrace, formatTimestamp } from './traceUtils';export async function traceRequests(options: { grep?: string, method?: string, status?: string, failed?: boolean }) {const trace = await loadTrace();@@ -44,8 +44,8 @@ export async function traceRequests(options: { grep?: string, method?: string, sconsole.log(' No network requests');return;}- console.log(` ${'#'.padStart(4)} ${'Method'.padEnd(8)} ${'Status'.padEnd(8)} ${'Name'.padEnd(45)} ${'Duration'.padStart(10)} ${'Size'.padStart(8)} ${'Route'.padEnd(10)}`);- console.log(` ${'─'.repeat(4)} ${'─'.repeat(8)} ${'─'.repeat(8)} ${'─'.repeat(45)} ${'─'.repeat(10)} ${'─'.repeat(8)} ${'─'.repeat(10)}`);+ console.log(` ${'#'.padStart(4)} ${'Start'.padEnd(9)} ${'Method'.padEnd(8)} ${'Status'.padEnd(8)} ${'Name'.padEnd(45)} ${'Duration'.padStart(10)} ${'Size'.padStart(8)} ${'Route'.padEnd(10)}`);+ console.log(` ${'─'.repeat(4)} ${'─'.repeat(9)} ${'─'.repeat(8)} ${'─'.repeat(8)} ${'─'.repeat(45)} ${'─'.repeat(10)} ${'─'.repeat(8)} ${'─'.repeat(10)}`);for (const { resource: r, ordinal } of indexed) {let name: string;@@ -65,7 +65,8 @@ export async function traceRequests(options: { grep?: string, method?: string, sconst status = r.response.status > 0 ? String(r.response.status) : 'ERR';const size = r.response._transferSize! > 0 ? r.response._transferSize! : r.response.bodySize;const route = formatRouteStatus(r);- console.log(` ${(ordinal + '.').padStart(4)} ${r.request.method.padEnd(8)} ${status.padEnd(8)} ${name.padEnd(45)} ${msToString(r.time).padStart(10)} ${bytesToString(size).padStart(8)} ${route.padEnd(10)}`);+ const start = r._monotonicTime ? formatTimestamp(r._monotonicTime, model.startTime) : '-';+ console.log(` ${(ordinal + '.').padStart(4)} ${start.padEnd(9)} ${r.request.method.padEnd(8)} ${status.padEnd(8)} ${name.padEnd(45)} ${msToString(r.time).padStart(10)} ${bytesToString(size).padStart(8)} ${route.padEnd(10)}`);}}@@ -94,6 +95,8 @@ export async function traceRequest(requestId: string) {// Generalconsole.log(' General');console.log(` status: ${status}`);+ if (r._monotonicTime)+ console.log(` start: ${formatTimestamp(r._monotonicTime, model.startTime)}`);console.log(` duration: ${msToString(r.time)}`);console.log(` size: ${bytesToString(size)}`);if (r.response.content.mimeType)diff --git a/tests/library/tracing.spec.ts b/tests/library/tracing.spec.tsindex 7b5178aaba..d0e2464559 100644--- a/tests/library/tracing.spec.ts+++ b/tests/library/tracing.spec.ts@@ -415,6 +415,8 @@ test('should record network failures', async ({ context, page, server }, testInfconst { events } = await parseTraceRaw(testInfo.outputPath('trace1.zip'));const requestEvent = events.find(e => e.type === 'resource-snapshot' && !!e.snapshot.response._failureText);expect(requestEvent).toBeTruthy();+ expect(requestEvent.snapshot._monotonicTime).toBeGreaterThan(0);+ expect(requestEvent.snapshot.time).toBeGreaterThanOrEqual(0);});test('should not crash when browser closes mid-trace', async ({ browserType, server }, testInfo) => {diff --git a/tests/mcp/trace-cli-fixtures.ts b/tests/mcp/trace-cli-fixtures.tsindex 1c39e81887..0f05b8f492 100644--- a/tests/mcp/trace-cli-fixtures.ts+++ b/tests/mcp/trace-cli-fixtures.ts@@ -108,6 +108,10 @@ export const test = baseTest// Fetchawait page.evaluate(() => fetch('/feedback', { method: 'POST', body: 'What a great product!' }).then(res => res.text()));+ // Aborted fetch+ await page.route('**/blocked', route => route.abort());+ await page.evaluate(() => fetch('/blocked').catch(() => {}));+// Navigate to another pageawait page.locator('a').click();diff --git a/tests/mcp/trace-cli.spec.ts b/tests/mcp/trace-cli.spec.tsindex 7b886ad1f6..49d14c5af6 100644--- a/tests/mcp/trace-cli.spec.ts+++ b/tests/mcp/trace-cli.spec.ts@@ -93,6 +93,18 @@ test('trace requests shows requests with ordinals', async ({ runTraceCli }) => {expect(stdout).toMatch(/\d+\./);});+test('trace requests shows start times and aborted request durations', async ({ runTraceCli }) => {+ const { stdout, exitCode } = await runTraceCli(['requests']);+ expect(exitCode).toBe(0);+ expect(stdout).toContain('Start');+ // Every request row carries a start timestamp in the `trace actions` Time format.+ expect(stdout).toMatch(/\d+\.\s+\d+:\d{2}\.\d{3}\s/);+ // The aborted request has a recorded duration rather than '-'.+ const abortedRow = stdout.split('\n').find(line => line.includes('aborted'))!;+ expect(abortedRow).toContain('blocked');+ expect(abortedRow).toMatch(/\s\d+(\.\d+)?m?s\s/);+});+test('trace requests --method filters', async ({ runTraceCli }) => {const { stdout, exitCode } = await runTraceCli(['requests', '--method', 'GET']);expect(exitCode).toBe(0);@@ -105,6 +117,7 @@ test('trace request shows details', async ({ runTraceCli }) => {expect(exitCode).toBe(0);expect(stdout).toContain('General');expect(stdout).toContain('status:');+ expect(stdout).toMatch(/start:\s+\d+:\d{2}\.\d{3}/);expect(stdout).toContain('Request headers');expect(stdout).toContain('Response headers');});