Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix: Replace path with parentPath (#39275)

lhfmartin5f4d2cbd8f01
diff --git a/packages/playwright-core/src/client/elementHandle.ts b/packages/playwright-core/src/client/elementHandle.ts
index fe206241aa..4eb1d52f89 100644
--- a/packages/playwright-core/src/client/elementHandle.ts
+++ b/packages/playwright-core/src/client/elementHandle.ts
@@ -289,7 +289,7 @@ export async function convertInputFiles(platform: Platform, files: string | File
context._checkFileAccess(localDirectory);
if (context._connection.isRemote()) {
- const files = localDirectory ? (await platform.fs().promises.readdir(localDirectory, { withFileTypes: true, recursive: true })).filter(f => f.isFile()).map(f => platform.path().join(f.path, f.name)) : localPaths!;
+ const files = localDirectory ? (await platform.fs().promises.readdir(localDirectory, { withFileTypes: true, recursive: true })).filter(f => f.isFile()).map(f => platform.path().join(f.parentPath, f.name)) : localPaths!;
const { writableStreams, rootDir } = await context._wrapApiCall(async () => context._channel.createTempFiles({
rootDirName: localDirectory ? platform.path().basename(localDirectory) : undefined,
items: await Promise.all(files.map(async file => {
diff --git a/tests/library/browsertype-connect.spec.ts b/tests/library/browsertype-connect.spec.ts
index 2b756d1a36..42c34120de 100644
--- a/tests/library/browsertype-connect.spec.ts
+++ b/tests/library/browsertype-connect.spec.ts
@@ -733,6 +733,44 @@ for (const kind of ['launchServer', 'run-server'] as const) {
await Promise.all([uploadFile, file1.filepath].map(fs.promises.unlink));
});
+ test('should upload a folder', async ({ connect, startRemoteServer, server }, testInfo) => {
+ test.slow();
+ const remoteServer = await startRemoteServer(kind);
+ const browser = await connect(remoteServer.wsEndpoint());
+ const context = await browser.newContext();
+ const page = await context.newPage();
+
+ await page.goto(server.PREFIX + '/input/folderupload.html');
+ const input = await page.$('input');
+ const folderName = 'folder-upload-test';
+ const dir = testInfo.outputPath(folderName);
+ {
+ await fs.promises.mkdir(dir, { recursive: true });
+ await fs.promises.writeFile(path.join(dir, 'file1.txt'), 'file1 content');
+ await fs.promises.writeFile(path.join(dir, 'file2'), 'file2 content');
+ await fs.promises.mkdir(path.join(dir, 'sub-dir'));
+ await fs.promises.writeFile(path.join(dir, 'sub-dir', 'really.txt'), 'sub-dir file content');
+ }
+ await input.setInputFiles(dir);
+
+ const webkitRelativePaths = await page.evaluate(e => [...e.files].map(f => f.webkitRelativePath), input);
+ expect(new Set(webkitRelativePaths)).toEqual(new Set([
+ `${folderName}/file1.txt`,
+ `${folderName}/file2`,
+ `${folderName}/sub-dir/really.txt`,
+ ]));
+
+ for (let i = 0; i < webkitRelativePaths.length; i++) {
+ const content = await input.evaluate((e, i) => {
+ const reader = new FileReader();
+ const promise = new Promise(fulfill => reader.onload = fulfill);
+ reader.readAsText(e.files[i]);
+ return promise.then(() => reader.result);
+ }, i);
+ expect(content).toEqual(fs.readFileSync(path.join(dir, '..', webkitRelativePaths[i])).toString());
+ }
+ });
+
test('setInputFiles should preserve lastModified timestamp', async ({ connect, startRemoteServer, asset }) => {
test.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/27452' });
const remoteServer = await startRemoteServer(kind);