Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
chore(bidi): don't set Accept-Language header for a locale override (#38196)
Holger Benl60e6df499c27
diff --git a/packages/playwright-core/src/server/bidi/bidiBrowser.ts b/packages/playwright-core/src/server/bidi/bidiBrowser.tsindex 7ac5e105a7..b9d3ce3496 100644--- a/packages/playwright-core/src/server/bidi/bidiBrowser.ts+++ b/packages/playwright-core/src/server/bidi/bidiBrowser.ts@@ -230,7 +230,7 @@ export class BidiBrowserContext extends BrowserContext {userContexts: [this._userContextId()],}));}- if (this._options.extraHTTPHeaders || this._options.locale)+ if (this._options.extraHTTPHeaders)promises.push(this.doUpdateExtraHTTPHeaders());await Promise.all(promises);}@@ -330,9 +330,7 @@ export class BidiBrowserContext extends BrowserContext {}async doUpdateExtraHTTPHeaders(): Promise<void> {- let allHeaders = this._options.extraHTTPHeaders || [];- if (this._options.locale)- allHeaders = network.mergeHeaders([allHeaders, network.singleHeader('Accept-Language', this._options.locale)]);+ const allHeaders = this._options.extraHTTPHeaders || [];await this._browser._browserSession.send('network.setExtraHeaders', {headers: allHeaders.map(({ name, value }) => ({ name, value: { type: 'string', value } })),userContexts: [this._userContextId()],diff --git a/packages/playwright-core/src/server/bidi/bidiPage.ts b/packages/playwright-core/src/server/bidi/bidiPage.tsindex e2015ac125..9041469d57 100644--- a/packages/playwright-core/src/server/bidi/bidiPage.ts+++ b/packages/playwright-core/src/server/bidi/bidiPage.ts@@ -298,11 +298,9 @@ export class BidiPage implements PageDelegate {}async updateExtraHTTPHeaders(): Promise<void> {- const locale = this._browserContext._options.locale;const allHeaders = network.mergeHeaders([this._browserContext._options.extraHTTPHeaders,this._page.extraHTTPHeaders(),- locale ? network.singleHeader('Accept-Language', locale) : undefined,]);await this._session.send('network.setExtraHeaders', {headers: allHeaders.map(({ name, value }) => ({ name, value: { type: 'string', value } })),