Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix(chromium): use resource type when deciding if evicted body can be re-fetched (#42201)

Yury Semikhatsky62e4f5ef5694
diff --git a/packages/playwright-core/src/server/chromium/crNetworkManager.ts b/packages/playwright-core/src/server/chromium/crNetworkManager.ts
index 193e3ad50a..f9a973699f 100644
--- a/packages/playwright-core/src/server/chromium/crNetworkManager.ts
+++ b/packages/playwright-core/src/server/chromium/crNetworkManager.ts
@@ -557,10 +557,10 @@ export class CRNetworkManager {
}
}
-// Sec-Fetch-Dest values of static subresources that are safe to fetch again.
-const kRefetchSafeDestinations = new Set([
- 'audio', 'audioworklet', 'font', 'image', 'manifest', 'paintworklet', 'script',
- 'serviceworker', 'sharedworker', 'style', 'track', 'video', 'worker', 'xslt',
+// Resource types of static subresources that are safe to fetch again. Unlike
+// Sec-Fetch-Dest, resource type is reported for plain http origins as well.
+const kRefetchSafeResourceTypes = new Set<network.ResourceType>([
+ 'font', 'image', 'manifest', 'media', 'script', 'stylesheet', 'texttrack',
]);
const kInterceptableRequest = Symbol('InterceptableRequest');
@@ -609,12 +609,12 @@ class InterceptableRequest {
// do it for GETs of static subresources and prefetch requests.
if (request.method() !== 'GET')
return Buffer.from('');
- const rawHeaders = await request.internalRawRequestHeaders();
- const rawHeaderValue = (name: string) => rawHeaders.find(h => h.name.toLowerCase() === name)?.value;
- const isPrefetch = !!rawHeaderValue('sec-purpose')?.startsWith('prefetch');
- const secFetchDest = rawHeaderValue('sec-fetch-dest');
- if (!isPrefetch && (!secFetchDest || !kRefetchSafeDestinations.has(secFetchDest)))
- return Buffer.from('');
+ if (!kRefetchSafeResourceTypes.has(request.resourceType())) {
+ const rawHeaders = await request.internalRawRequestHeaders();
+ const isPrefetch = rawHeaders.some(h => h.name.toLowerCase() === 'sec-purpose' && h.value.startsWith('prefetch'));
+ if (!isPrefetch)
+ return Buffer.from('');
+ }
const resource = await session.send('Network.loadNetworkResource', { url: request.url(), frameId: request.serviceWorker() ? undefined : request.frame()!._id, options: { disableCache: false, includeCredentials: true } });
const chunks: Buffer[] = [];
diff --git a/tests/page/page-network-response.spec.ts b/tests/page/page-network-response.spec.ts
index 8074ec53c0..6e65a81d10 100644
--- a/tests/page/page-network-response.spec.ts
+++ b/tests/page/page-network-response.spec.ts
@@ -344,8 +344,9 @@ it('should report if request was fromServiceWorker', async ({ page, server, isAn
}
});
-it('should return body for prefetch script', async ({ page, server, browserName }) => {
+it('should return body for prefetch script', async ({ page, server, browserName, browserMajorVersion }) => {
it.skip(browserName === 'webkit', 'No prefetch in WebKit: https://caniuse.com/link-rel-prefetch');
+ it.skip(browserName === 'chromium' && browserMajorVersion < 138, 'Requires Sec-Purpose header, shipped in Chrome 138');
const [response] = await Promise.all([
page.waitForResponse('**/prefetch.js'),
page.goto(server.PREFIX + '/prefetch.html')