Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
fix(fetch): handle multi-value RDN in certificate security details (#41824)
Dmitry Gozman6693f583f49c
diff --git a/packages/playwright-core/src/server/fetch.ts b/packages/playwright-core/src/server/fetch.tsindex 4a71fd9d6c..e9c1fbc1ba 100644--- a/packages/playwright-core/src/server/fetch.ts+++ b/packages/playwright-core/src/server/fetch.ts@@ -581,12 +581,14 @@ export abstract class APIRequestContext extends SdkObject {if (!(socket instanceof TLSSocket))return;const peerCertificate = socket.getPeerCertificate();+ // Multi-value RDNs are reported as string arrays, take the first common name.+ const commonName = (field: string | string[] | undefined) => Array.isArray(field) ? field[0] : field;securityDetails = {protocol: socket.getProtocol() ?? undefined,- subjectName: peerCertificate.subject.CN as string,+ subjectName: commonName(peerCertificate.subject?.CN),validFrom: new Date(peerCertificate.valid_from).getTime() / 1000,validTo: new Date(peerCertificate.valid_to).getTime() / 1000,- issuer: peerCertificate.issuer.CN as string+ issuer: commonName(peerCertificate.issuer?.CN)};};diff --git a/tests/assets/multi-value-rdn/README.md b/tests/assets/multi-value-rdn/README.mdnew file mode 100644index 0000000000..c73d626a71--- /dev/null+++ b/tests/assets/multi-value-rdn/README.md@@ -0,0 +1,10 @@+# Certificate with repeated CN attributes++Self-signed certificate whose subject and issuer DNs contain two CN attributes.+Generated with:++```bash+openssl req -x509 -newkey rsa:2048 -nodes -days 3650 \+ -keyout key.pem -out cert.pem \+ -subj "/CN=localhost/CN=secondary-name" -addext "subjectAltName=DNS:localhost"+```diff --git a/tests/assets/multi-value-rdn/cert.pem b/tests/assets/multi-value-rdn/cert.pemnew file mode 100644index 0000000000..74d1c9c43d--- /dev/null+++ b/tests/assets/multi-value-rdn/cert.pem@@ -0,0 +1,20 @@+-----BEGIN CERTIFICATE-----+MIIDUTCCAjmgAwIBAgIUDcubmCnYBUu3B/b8eigmpZhoDR0wDQYJKoZIhvcNAQEL+BQAwLTESMBAGA1UEAwwJbG9jYWxob3N0MRcwFQYDVQQDDA5zZWNvbmRhcnktbmFt+ZTAeFw0yNjA3MTYxMzMwMTJaFw0zNjA3MTMxMzMwMTJaMC0xEjAQBgNVBAMMCWxv+Y2FsaG9zdDEXMBUGA1UEAwwOc2Vjb25kYXJ5LW5hbWUwggEiMA0GCSqGSIb3DQEB+AQUAA4IBDwAwggEKAoIBAQDGzWBbkSIKCJvaAcDowynqdO6UHLcArwv/HAUsVOg9+PcIwaWOAjiBSgfljebKN/gaHyEnQrQEfkEXxrq71ig+wCtGdrt5cyLC2FR49HnE5+Q1GqTfnCnZCwdNo2OZ6J9Q2VGUoeO05r60C2YNNDKroq/axJdLd2M9EUKLTfXp9/+Trybp17VUods9gRIn4vlgbujdIybRwIicLH6cwN9KgNYRBn3rNoDVUK3igoUA5p2+YF/4LhoREnOC5MFA9Hf8tluJZFn0HWaxJ/VuKL0HbCEWgyQgy1QZ6R7ut5fY/RZ++/kNayIxaSiXPv8lVpQJ15h/B7tprKNhJkxrBoZVjNJjrAgMBAAGjaTBnMB0GA1Ud+DgQWBBTLhZ6Gu2woML7sZ6tWgVooZzZx0zAfBgNVHSMEGDAWgBTLhZ6Gu2woML7s+Z6tWgVooZzZx0zAPBgNVHRMBAf8EBTADAQH/MBQGA1UdEQQNMAuCCWxvY2FsaG9z+dDANBgkqhkiG9w0BAQsFAAOCAQEAkPvFLdEyck2ivwtnSbwGYTuu3CXTQrB5X0pa+lu5BCYYorrY/mmGtprQzKPhl8ESG1YDlGV05swF2+XPzb9jDvduYKLSyi+mJAf2J+RgQxwH4GlhHl0KNhG7IN8kspM7txGUifFklRppriSkeviGs9urazt489JYKmMBn/+kFihqGBcFk8FjHrdaLdInw2SZLbtE+bVDRux1C8+W/sO6M4Wg1sU0wo1RbwVgSKu+FRXeftlxpt/B20ygc2RNlaj4kxfKvwbeiQ0oYKUaQENpkReuF8mSA8vhAx/SkX/X+madb4L11oP0Y3bDTbQLBJGUV2zTkk0DtZ3zOeo+y442fyOWq5w==+-----END CERTIFICATE-----diff --git a/tests/assets/multi-value-rdn/key.pem b/tests/assets/multi-value-rdn/key.pemnew file mode 100644index 0000000000..7cee6dfabb--- /dev/null+++ b/tests/assets/multi-value-rdn/key.pem@@ -0,0 +1,28 @@+-----BEGIN PRIVATE KEY-----+MIIEvQIBADANBgkqhkiG9w0BAQEFAASCBKcwggSjAgEAAoIBAQDGzWBbkSIKCJva+AcDowynqdO6UHLcArwv/HAUsVOg9PcIwaWOAjiBSgfljebKN/gaHyEnQrQEfkEXx+rq71ig+wCtGdrt5cyLC2FR49HnE5Q1GqTfnCnZCwdNo2OZ6J9Q2VGUoeO05r60C2+YNNDKroq/axJdLd2M9EUKLTfXp9/Trybp17VUods9gRIn4vlgbujdIybRwIicLH6+cwN9KgNYRBn3rNoDVUK3igoUA5p2YF/4LhoREnOC5MFA9Hf8tluJZFn0HWaxJ/Vu+KL0HbCEWgyQgy1QZ6R7ut5fY/RZ+/kNayIxaSiXPv8lVpQJ15h/B7tprKNhJkxrB+oZVjNJjrAgMBAAECggEAC0c/fjJfof4XCWksDohz6k8z8ccnQqyrm491Y6x1eHP2+flScRoDJqKSjB1eyH4gXysA8H9CQzb+bmDh2yItKlIwolC+FgfIIxGuySXlepwcA+rQ67aqURvlECyCzAp8b1PE4w/EIVEt5Hz5Dyq07TPPkjOw+aEOSjqecdS8bMeaZe+J1Bwzavu6oZJ3oRnkqYmzarvqcudjXvAV4Ov70j2iGMyYNLPpoBGOJ5oo1IgIBGg+6Cf6M5zBkre7AELm1koUcNHhSwE3OoMyrIlgntC7ohbZQZoWsI3Z98eWwpB/l1vK+eKV8ugkh6m6OdWplRWCMXG4gijcHhZEh/tOoh5zrIQKBgQD5Si3zw7vBwpbfIm/O+pBamU334TSRwCOAAVUxFfYAsHTjQyhV4ssegFWONdTzixDXYOHnOwIekXDHqrWJq+3c84o+qa/aljVXFC7Uf9sxlhDrW18zJHXG8IRHeWuYRn1NofFxo61g0UsIoyCQgb+RCrHkvlZg1L07ZX6hbRa6UHnowKBgQDMJ0tqX1fvxdSVU3lE9qlde+j+A9J4IpBu+N/JQLZijxbwwQGAgXRcEwg4p4EXcUCJ52ujfyuYqfPO33jcWimPZktQTLeomoV1h+aVOEPTuVj0Y+6cCwkaX7SVVzIo1T7LJn/KBQuSDXCfg/2zhUIyWsZMT2n242OAB2+B3vNDF6+GQKBgAnMcKH0P50OGQAMSnjE2l8PSRRJc/UzZBqfP7A7jp4tR95tEwr7+e/0+2frlcM85ByTIk4Ec8Df1p8ChsAyjS1Hen4oYDmBpK1qGGR5Pu9+kxF+yf3du+mq6ogkraX+n04930+oL1hu4ZQlVVJYxs0YGmtUZfcxNNg2elecFZCc4hAoGAOYhV+W3vVB1BEEXT9tu6gWiUCSxt+o7Zx523Czs+atYSS/TIXJOe3BfM+FJUMewLmRFrp+x6+hX5XpBQcNlT+Y1gbn1yPYWdyduUb6b0jmUsaWsEIluFzDXuaSuyiglWcd++oY+r8cMNy2rFSvNWwCwrD2VuD7Dy2nKz3habjWvOXkCgYEAmQ1XlZXwMGyl4VKpGsmn+ohTJG3SmVqc/TykKNa++pc4oVS905cDOSAKnsz/azvTrBVFjTHk1nQ+DQFlTzJj9+cl28MfT9ppfyhDzPAUnINjWRfdKP99uGC9jqNPG95bwPuqsx5RKW3G81mkbNhIUB+K21AMRQ9UftQb0bSsvZz1E0=+-----END PRIVATE KEY-----diff --git a/tests/library/global-fetch.spec.ts b/tests/library/global-fetch.spec.tsindex 457d8c2e1f..d980b253f0 100644--- a/tests/library/global-fetch.spec.ts+++ b/tests/library/global-fetch.spec.ts@@ -14,9 +14,10 @@* limitations under the License.*/+import fs from 'fs';import os from 'os';import * as util from 'util';-import { getPlaywrightVersion } from '../../packages/playwright-core/lib/coreBundle';+import { getPlaywrightVersion, utils } from '../../packages/playwright-core/lib/coreBundle';import { expect, playwrightTest as base } from '../config/browserTest';const it = base.extend({@@ -263,6 +264,30 @@ it('should return null security details for http response', async ({ playwright,await request.dispose();});+it('should return security details for certificate with multiple CN attributes', {+ annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/41815' },+}, async ({ playwright, asset }) => {+ const server = utils.createHttpsServer({+ key: fs.readFileSync(asset('multi-value-rdn/key.pem')),+ cert: fs.readFileSync(asset('multi-value-rdn/cert.pem')),+ }, (req, res) => {+ res.writeHead(200, { 'Content-Type': 'application/json' });+ res.end(JSON.stringify({ ok: true }));+ });+ await new Promise<void>(resolve => server.listen(0, '127.0.0.1', resolve));+ try {+ const request = await playwright.request.newContext({ ignoreHTTPSErrors: true });+ const response = await request.get(`https://localhost:${server.address().port}/`);+ expect(response.status()).toBe(200);+ const securityDetails = await response.securityDetails();+ expect(securityDetails.subjectName).toBe('localhost');+ expect(securityDetails.issuer).toBe('localhost');+ await request.dispose();+ } finally {+ await new Promise(resolve => server.close(resolve));+ }+});+it('should resolve url relative to global baseURL option', async ({ playwright, server }) => {const request = await playwright.request.newContext({ baseURL: server.PREFIX });const response = await request.get('/empty.html');