Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
fix(selector generator): heuristic for icon fonts (#38182)
Dmitry Gozman68161ba65b82
diff --git a/packages/injected/src/selectorGenerator.ts b/packages/injected/src/selectorGenerator.tsindex 202472aa4f..73b6e4d3a2 100644--- a/packages/injected/src/selectorGenerator.ts+++ b/packages/injected/src/selectorGenerator.ts@@ -343,7 +343,8 @@ function buildTextCandidates(injectedScript: InjectedScript, element: Element, iconst ariaRole = getAriaRole(element);if (ariaRole && !['none', 'presentation'].includes(ariaRole)) {const ariaName = getElementAccessibleName(element, false);- if (ariaName) {+ // \p{Co} means "Private Use" characters - these are often used for icon fonts and make for bad locators.+ if (ariaName && !ariaName.match(/^\p{Co}+$/u)) {const roleToken = { engine: 'internal:role', selector: `${ariaRole}[name=${escapeForAttributeSelector(ariaName, true)}]`, score: kRoleWithNameScoreExact };candidates.push([roleToken]);for (const alternative of suitableTextAlternatives(ariaName))diff --git a/tests/library/selector-generator.spec.ts b/tests/library/selector-generator.spec.tsindex a78fb15a5c..37305fc5c8 100644--- a/tests/library/selector-generator.spec.ts+++ b/tests/library/selector-generator.spec.ts@@ -661,4 +661,23 @@ it.describe('selector generator', () => {`internal:label=\"Toggle Todo\"i >> nth=0`,]);});++ it('should not use icon fonts aria name', async ({ page }) => {+ await page.setContent(`+ <style>+ .icon-foo:before {+ content: "\\F1D4";+ }+ .icon-bar:before {+ content: "\\F0000";+ }+ </style>+ <div>+ <button><i class="icon-foo"></i></button>+ <button><i class="icon-bar"></i></button>+ </div>+ `);+ expect.soft(await generate(page, 'button:first-child')).toBe('internal:role=button >> nth=0');+ expect.soft(await generate(page, 'button:last-child')).toBe('internal:role=button >> nth=1');+ });});