Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore(html): make nav buttons into proper links (#36838)

Adam Gastineau72c4bf154d29
diff --git a/packages/html-reporter/src/headerView.spec.tsx b/packages/html-reporter/src/headerView.spec.tsx
index 1ad79683ab..85e78758b0 100644
--- a/packages/html-reporter/src/headerView.spec.tsx
+++ b/packages/html-reporter/src/headerView.spec.tsx
@@ -39,7 +39,10 @@ test('should render counters', async ({ mount }) => {
await expect(component).toMatchAriaSnapshot(`
- navigation:
- link "All90"
- - text: Passed42 Failed31 Flaky17 Skipped10
+ - link "Passed42"
+ - link "Failed31"
+ - link "Flaky17"
+ - link "Skipped10"
`);
});
diff --git a/packages/html-reporter/src/headerView.tsx b/packages/html-reporter/src/headerView.tsx
index f44b4daf87..d385c12992 100644
--- a/packages/html-reporter/src/headerView.tsx
+++ b/packages/html-reporter/src/headerView.tsx
@@ -81,31 +81,34 @@ export const GlobalFilterView: React.FC<{
const StatsNavView: React.FC<{
stats: Stats
}> = ({ stats }) => {
- const searchParams = React.useContext(SearchParamsContext);
- const q = searchParams.get('q')?.toString() || '';
return <nav>
<Link className='subnav-item' href='#?'>
<span className='subnav-item-label'>All</span>
<span className='d-inline counter'>{stats.total - stats.skipped}</span>
</Link>
- <Link className='subnav-item' click={filterWithQuery(q, 's:passed', false)} ctrlClick={filterWithQuery(q, 's:passed', true)}>
- <span className='subnav-item-label'>Passed</span>
- <span className='d-inline counter'>{stats.expected}</span>
- </Link>
- <Link className='subnav-item' click={filterWithQuery(q, 's:failed', false)} ctrlClick={filterWithQuery(q, 's:failed', true)}>
- {!!stats.unexpected && statusIcon('unexpected')}
- <span className='subnav-item-label'>Failed</span>
- <span className='d-inline counter'>{stats.unexpected}</span>
- </Link>
- <Link className='subnav-item' click={filterWithQuery(q, 's:flaky', false)} ctrlClick={filterWithQuery(q, 's:flaky', true)}>
- {!!stats.flaky && statusIcon('flaky')}
- <span className='subnav-item-label'>Flaky</span>
- <span className='d-inline counter'>{stats.flaky}</span>
- </Link>
- <Link className='subnav-item' click={filterWithQuery(q, 's:skipped', false)} ctrlClick={filterWithQuery(q, 's:skipped', true)}>
- {!!stats.skipped && statusIcon('skipped')}
- <span className='subnav-item-label'>Skipped</span>
- <span className='d-inline counter'>{stats.skipped}</span>
- </Link>
+ <NavLink token='passed' count={stats.expected} />
+ <NavLink token='failed' count={stats.unexpected} />
+ <NavLink token='flaky' count={stats.flaky} />
+ <NavLink token='skipped' count={stats.skipped} />
</nav>;
};
+
+const NavLink: React.FC<{
+ token: string,
+ count: number,
+}> = ({ token, count }) => {
+ const searchParams = React.useContext(SearchParamsContext);
+ const q = searchParams.get('q')?.toString() || '';
+ const queryToken = `s:${token}`;
+
+ const clickUrl = filterWithQuery(q, queryToken, false);
+ const ctrlClickUrl = filterWithQuery(q, queryToken, true);
+
+ const label = token.charAt(0).toUpperCase() + token.slice(1);
+
+ return <Link className='subnav-item' href={clickUrl} click={clickUrl} ctrlClick={ctrlClickUrl}>
+ {count > 0 && statusIcon(token as any)}
+ <span className='subnav-item-label'>{label}</span>
+ <span className='d-inline counter'>{count}</span>
+ </Link>;
+};