Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore(mcp): delete socket file only on posix (#38876)

Yury Semikhatsky78a7b750b2a1
diff --git a/packages/playwright/src/mcp/terminal/cli.ts b/packages/playwright/src/mcp/terminal/cli.ts
index 5a8627da3d..a6c90195c4 100644
--- a/packages/playwright/src/mcp/terminal/cli.ts
+++ b/packages/playwright/src/mcp/terminal/cli.ts
@@ -142,7 +142,8 @@ async function connectToDaemon(options: { headless?: boolean }): Promise<SocketS
return await connectToSocket(socketPath);
} catch (e) {
// Connection failed, delete the stale socket file.
- fs.unlinkSync(socketPath);
+ if (os.platform() !== 'win32')
+ await fs.promises.unlink(socketPath).catch(() => {});
}
}
diff --git a/packages/playwright/src/mcp/terminal/daemon.ts b/packages/playwright/src/mcp/terminal/daemon.ts
index c16cde81a8..dd6e507cb7 100644
--- a/packages/playwright/src/mcp/terminal/daemon.ts
+++ b/packages/playwright/src/mcp/terminal/daemon.ts
@@ -23,6 +23,7 @@ import url from 'url';
import { debug } from 'playwright-core/lib/utilsBundle';
import { SocketConnection } from './socketConnection';
import { browserTools } from '../browser/tools';
+import { aliases } from './commands';
import type { ServerBackendFactory } from '../sdk/server';
import type * as mcp from '../sdk/exports';
@@ -125,23 +126,12 @@ function camelToKebabCase(camel: string): string {
return camel.replace(/([A-Z])/g, letter => `-${letter.toLowerCase()}`);
}
-export const aliases: Record<string, string[]> = {
- 'navigate': ['goto', 'open'],
- 'take_screenshot': ['screenshot'],
-};
-
function canonicalName(name: string): string {
- switch (name) {
- case 'goto':
- case 'navigate':
- case 'open':
- return 'navigate';
- case 'screenshot':
- case 'take_screenshot':
- return 'take_screenshot';
- default:
- return name;
+ for (const [canonicalName, nameAliases] of Object.entries(aliases)) {
+ if (nameAliases.includes(name))
+ return canonicalName;
}
+ return name;
}
function parseCliCommand(argv: string[]): { toolName: string, args: mcp.CallToolRequest['params']['arguments'] } {
@@ -152,7 +142,6 @@ function parseCliCommand(argv: string[]): { toolName: string, args: mcp.CallTool
throw new Error('Command is required');
const toolName = `browser_${canonicalName(commandAlias)}`;
- // TODO: support aliases
const tool = browserTools.find(tool => tool.schema.name === toolName);
if (!tool)
throw new Error(`Unknown command: ${commandAlias}.`);