Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix(trace-viewer): restore displaying selected call title in call tab (#37898)

Adam Gastineau791ae34734a2
diff --git a/packages/trace-viewer/src/ui/callTab.tsx b/packages/trace-viewer/src/ui/callTab.tsx
index c3a6d34e5f..5accfc8605 100644
--- a/packages/trace-viewer/src/ui/callTab.tsx
+++ b/packages/trace-viewer/src/ui/callTab.tsx
@@ -24,6 +24,7 @@ import { asLocator } from '@isomorphic/locatorGenerators';
import type { Language } from '@isomorphic/locatorGenerators';
import { PlaceholderPanel } from './placeholderPanel';
import type { ActionTraceEventInContext } from './modelUtil';
+import { renderTitleForCall } from './actionList';
export const CallTab: React.FunctionComponent<{
action: ActionTraceEventInContext | undefined,
@@ -40,9 +41,11 @@ export const CallTab: React.FunctionComponent<{
const startTimeMillis = action.startTime - startTimeOffset;
const startTime = msToString(startTimeMillis);
+ const { title } = renderTitleForCall(action);
+
return (
<div className='call-tab'>
- <div className='call-line'>{action.title}</div>
+ <div className='call-line'>{title}</div>
<div className='call-section'>Time</div>
{renderProperty({ name: 'start', type: 'literal', text: startTime })}
{renderProperty({ name: 'duration', type: 'literal', text: renderDuration(action) })}
diff --git a/tests/library/trace-viewer.spec.ts b/tests/library/trace-viewer.spec.ts
index f5525a580b..22ce9d535a 100644
--- a/tests/library/trace-viewer.spec.ts
+++ b/tests/library/trace-viewer.spec.ts
@@ -303,7 +303,7 @@ test('should show params and return value', async ({ showTraceViewer }) => {
const traceViewer = await showTraceViewer(traceFile);
await traceViewer.selectAction('Evaluate');
await expect(traceViewer.callLines).toHaveText([
- '',
+ /Evaluate/,
/start:[\d\.]+m?s/,
/duration:[\d]+ms/,
/expression:"\({↵ a↵ }\) => {↵ console\.log\(\'Info\'\);↵ console\.warn\(\'Warning\'\);↵ console/,
@@ -329,7 +329,7 @@ test('should show null as a param', async ({ showTraceViewer, browserName }) =>
const traceViewer = await showTraceViewer(traceFile);
await traceViewer.selectAction('Evaluate', 1);
await expect(traceViewer.callLines).toHaveText([
- '',
+ /Evaluate/,
/start:[\d\.]+m?s/,
/duration:[\d]+ms/,
'expression:"() => 1 + 1"',