Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
feat(codegen): pick locator in right-click menu (#37516)
Dmitry Gozman7c4d2e7b4d21
diff --git a/packages/injected/src/recorder/recorder.ts b/packages/injected/src/recorder/recorder.tsindex 08da712f0a..60162b760a 100644--- a/packages/injected/src/recorder/recorder.ts+++ b/packages/injected/src/recorder/recorder.ts@@ -514,10 +514,10 @@ class RecordActionTool implements RecorderTool {private _showActionListDialog(model: HighlightModelWithSelector, event: MouseEvent) {consumeEvent(event);const actionPosition = positionForEvent(event);- const actions: { title: string, action: actions.PerformOnRecordAction }[] = [+ const actions: { title: string, cb: () => void }[] = [{title: 'Click',- action: {+ cb: () => this._performAction({name: 'click',selector: model.selector,position: actionPosition,@@ -525,11 +525,11 @@ class RecordActionTool implements RecorderTool {button: 'left',modifiers: 0,clickCount: 0,- }+ }),},{title: 'Right click',- action: {+ cb: () => this._performAction({name: 'click',selector: model.selector,position: actionPosition,@@ -537,11 +537,11 @@ class RecordActionTool implements RecorderTool {button: 'right',modifiers: 0,clickCount: 0,- }+ }),},{title: 'Double click',- action: {+ cb: () => this._performAction({name: 'click',selector: model.selector,position: actionPosition,@@ -549,16 +549,20 @@ class RecordActionTool implements RecorderTool {button: 'left',modifiers: 0,clickCount: 2,- }+ }),},{title: 'Hover',- action: {+ cb: () => this._performAction({name: 'hover',selector: model.selector,position: actionPosition,signals: [],- }+ }),+ },+ {+ title: 'Pick locator',+ cb: () => this._recorder.elementPicked(model.selector, model),},];@@ -572,7 +576,7 @@ class RecordActionTool implements RecorderTool {actionElement.setAttribute('aria-label', action.title);actionElement.addEventListener('click', () => {this._dialog.close();- this._performAction(action.action);+ action.cb();});listElement.appendChild(actionElement);}diff --git a/tests/library/inspector/cli-codegen-3.spec.ts b/tests/library/inspector/cli-codegen-3.spec.tsindex 6b911bbedb..ec380a9bba 100644--- a/tests/library/inspector/cli-codegen-3.spec.ts+++ b/tests/library/inspector/cli-codegen-3.spec.ts@@ -729,6 +729,7 @@ await page.GetByRole(AriaRole.Textbox, new() { Name = \"Coun\\\"try\" }).ClickAs- listitem "Right click"- listitem "Double click"- listitem "Hover"+ - listitem "Pick locator"`);await recorder.page.getByRole('listitem', { name: 'Hover' }).click();};