Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore(ui-mode): improve alignment of settings select beside checkboxes (#37350)

Adam Gastineau808a1308fa79
diff --git a/packages/trace-viewer/src/ui/settingsView.css b/packages/trace-viewer/src/ui/settingsView.css
index 4e59055227..68d8a6a751 100644
--- a/packages/trace-viewer/src/ui/settingsView.css
+++ b/packages/trace-viewer/src/ui/settingsView.css
@@ -40,7 +40,13 @@
flex-shrink: 0;
}
-.settings-view .setting select {
- margin-left: 8px;
- flex-shrink: 0;
+.settings-view .setting-select {
+ display: grid;
+ grid-template-rows: auto auto;
+ row-gap: 8px;
+ margin: 0 16px 0 22px;
+}
+
+.settings-view .setting-select:not(:first-child) {
+ margin-top: 4px;
}
diff --git a/packages/trace-viewer/src/ui/settingsView.tsx b/packages/trace-viewer/src/ui/settingsView.tsx
index 824dc22e38..cc50343817 100644
--- a/packages/trace-viewer/src/ui/settingsView.tsx
+++ b/packages/trace-viewer/src/ui/settingsView.tsx
@@ -37,10 +37,10 @@ export const SettingsView: React.FunctionComponent<{
return (
<div className='vbox settings-view'>
{settings.map(setting => {
- const labelId = `setting-${setting.name}`;
+ const labelId = `setting-${setting.name.replaceAll(/\s+/g, '-')}`;
return (
- <div key={setting.name} className='setting' title={setting.title}>
+ <div key={setting.name} className={`setting setting-${setting.type}`} title={setting.title}>
{renderSetting(setting, labelId)}
</div>
);
@@ -66,7 +66,7 @@ const renderSetting = (setting: Setting, labelId: string) => {
case 'select':
return (
<>
- <label htmlFor={labelId}>{setting.name}</label>
+ <label htmlFor={labelId}>{setting.name}:</label>
<select id={labelId} value={setting.value} onChange={e => setting.set(e.target.value)}>
{setting.options.map(option => (
<option key={option.value} value={option.value}>