Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
fix(webkit): use native checkVisibility for element visibility (#42971)
Yury Semikhatsky814dbe71228d
diff --git a/docs/src/electron-api/class-electron.md b/docs/src/electron-api/class-electron.mdindex 60e64080e0..e95c1edb1b 100644--- a/docs/src/electron-api/class-electron.md+++ b/docs/src/electron-api/class-electron.md@@ -41,9 +41,7 @@ const { _electron: electron } = require('playwright');```**Supported Electron versions are:**-* v12.2.0+-* v13.4.0+-* v14++* v21+**Known issues:**diff --git a/docs/src/mobile-api/class-android.md b/docs/src/mobile-api/class-android.mdindex 4427622b6a..68305f4b7f 100644--- a/docs/src/mobile-api/class-android.md+++ b/docs/src/mobile-api/class-android.md@@ -7,7 +7,7 @@ Playwright has **experimental** support for Android automation. This includes Ch*Requirements** Android device or AVD Emulator.* [ADB daemon](https://developer.android.com/studio/command-line/adb) running and authenticated with your device. Typically running `adb devices` is all you need to do.-* [`Chrome 87`](https://play.google.com/store/apps/details?id=com.android.chrome) or newer installed on the device+* [`Chrome 105`](https://play.google.com/store/apps/details?id=com.android.chrome) or newer installed on the device* "Enable command line on non-rooted devices" enabled in `chrome://flags`.*Known limitations*diff --git a/packages/injected/src/domUtils.ts b/packages/injected/src/domUtils.tsindex c88184506a..557e4ca9f3 100644--- a/packages/injected/src/domUtils.ts+++ b/packages/injected/src/domUtils.ts@@ -21,9 +21,6 @@ let globalOptions: GlobalOptions = {};export function setGlobalOptions(options: GlobalOptions) {globalOptions = options;}-export function getGlobalOptions(): GlobalOptions {- return globalOptions;-}export function isInsideScope(scope: Node, element: Element | undefined): boolean {while (element) {@@ -100,23 +97,31 @@ function computeElementStyleVisibilityVisible(element: Element, style?: CSSStyle// Element.checkVisibility checks for content-visibility and also looks at// styles up the flat tree including user-agent ShadowRoots, such as the// details element for example.- // All the browser implement it, but WebKit has a bug which prevents us from using it:- // https://bugs.webkit.org/show_bug.cgi?id=264733- // @ts-ignore- if (Element.prototype.checkVisibility && globalOptions.browserNameForWorkarounds !== 'webkit') {- if (!element.checkVisibility())- return false;- } else {- // Manual workaround for WebKit that does not have checkVisibility.- const detailsOrSummary = element.closest('details,summary');- if (detailsOrSummary !== element && detailsOrSummary?.nodeName === 'DETAILS' && !(detailsOrSummary as HTMLDetailsElement).open)- return false;- }+ if (!element.checkVisibility() && !isWebKitListBoxOptionVisible(element, style))+ return false;if (style.visibility !== 'visible')return false;return true;}+export function isListBoxSelect(select: HTMLSelectElement): boolean {+ return select.multiple || select.size > 1;+}++// WebKit does not create renderers for list box options, so checkVisibility() returns false for them.+function isWebKitListBoxOptionVisible(element: Element, style: CSSStyleDeclaration): boolean {+ if (globalOptions.browserNameForWorkarounds !== 'webkit' || element.nodeName !== 'OPTION' || style.display === 'none')+ return false;+ const select = element.closest('select');+ if (!select || !isListBoxSelect(select))+ return false;+ for (let e = element.parentElement; e && e !== select; e = e.parentElement) {+ if (getElementComputedStyle(e)?.display === 'none')+ return false;+ }+ return isElementStyleVisibilityVisible(select);+}+export function computeBox(element: Element) {// Note: this logic should be similar to waitForDisplayedAtStablePosition() to avoid surprises.const style = getElementComputedStyle(element);diff --git a/packages/injected/src/roleUtils.ts b/packages/injected/src/roleUtils.tsindex 6216b45b04..3b274129d3 100644--- a/packages/injected/src/roleUtils.ts+++ b/packages/injected/src/roleUtils.ts@@ -16,7 +16,7 @@import * as css from '@isomorphic/cssTokenizer';-import { beginDOMCaches, closestCrossShadow, elementSafeTagName, enclosingShadowRootOrDocument, endDOMCaches, getElementComputedStyle, isElementStyleVisibilityVisible, isVisibleTextNode, parentElementOrShadowHost } from './domUtils';+import { beginDOMCaches, closestCrossShadow, elementSafeTagName, enclosingShadowRootOrDocument, endDOMCaches, getElementComputedStyle, isElementStyleVisibilityVisible, isListBoxSelect, isVisibleTextNode, parentElementOrShadowHost } from './domUtils';import type { AriaRole } from '@isomorphic/ariaSnapshot';@@ -155,7 +155,7 @@ const kImplicitRoleByTagName: { [tagName: string]: (e: Element) => AriaRole | nu'PROGRESS': () => 'progressbar','SEARCH': () => 'search','SECTION': (e: Element) => hasExplicitAccessibleName(e) ? 'region' : null,- 'SELECT': (e: Element) => e.hasAttribute('multiple') || (e as HTMLSelectElement).size > 1 ? 'listbox' : 'combobox',+ 'SELECT': (e: Element) => isListBoxSelect(e as HTMLSelectElement) ? 'listbox' : 'combobox','STRONG': () => 'strong','SUB': () => 'subscript','SUP': () => 'superscript',@@ -341,7 +341,7 @@ function belongsToDisplayNoneOrAriaHiddenOrNonSlotted(element: Element): boolean// When parent has a shadow root, all light dom children must be assigned to a slot,// otherwise they are not rendered and considered hidden for aria.- // Note: we can remove this logic once WebKit supports `Element.checkVisibility`.+ // Note: needed for <option> and <slot>, which skip checkVisibility above.if (element.parentElement && element.parentElement.shadowRoot && !element.assignedSlot)hidden = true;diff --git a/packages/playwright-client/types/types.d.ts b/packages/playwright-client/types/types.d.tsindex 20b22f0e4e..cab3c0528a 100644--- a/packages/playwright-client/types/types.d.ts+++ b/packages/playwright-client/types/types.d.ts@@ -24015,9 +24015,7 @@ export interface WebStorage {* ```** **Supported Electron versions are:**- * - v12.2.0+- * - v13.4.0+- * - v14++ * - v21+** **Known issues:***@@ -24351,7 +24349,7 @@ export interface Electron {* - Android device or AVD Emulator.* - [ADB daemon](https://developer.android.com/studio/command-line/adb) running and authenticated with your device.* Typically running `adb devices` is all you need to do.- * - [`Chrome 87`](https://play.google.com/store/apps/details?id=com.android.chrome) or newer installed on the+ * - [`Chrome 105`](https://play.google.com/store/apps/details?id=com.android.chrome) or newer installed on the* device* - "Enable command line on non-rooted devices" enabled in `chrome://flags`.*diff --git a/packages/playwright-core/types/types.d.ts b/packages/playwright-core/types/types.d.tsindex 20b22f0e4e..cab3c0528a 100644--- a/packages/playwright-core/types/types.d.ts+++ b/packages/playwright-core/types/types.d.ts@@ -24015,9 +24015,7 @@ export interface WebStorage {* ```** **Supported Electron versions are:**- * - v12.2.0+- * - v13.4.0+- * - v14++ * - v21+** **Known issues:***@@ -24351,7 +24349,7 @@ export interface Electron {* - Android device or AVD Emulator.* - [ADB daemon](https://developer.android.com/studio/command-line/adb) running and authenticated with your device.* Typically running `adb devices` is all you need to do.- * - [`Chrome 87`](https://play.google.com/store/apps/details?id=com.android.chrome) or newer installed on the+ * - [`Chrome 105`](https://play.google.com/store/apps/details?id=com.android.chrome) or newer installed on the* device* - "Enable command line on non-rooted devices" enabled in `chrome://flags`.*diff --git a/tests/page/locator-is-visible.spec.ts b/tests/page/locator-is-visible.spec.tsindex 4349f3b3d8..2d4e681257 100644--- a/tests/page/locator-is-visible.spec.ts+++ b/tests/page/locator-is-visible.spec.ts@@ -60,6 +60,54 @@ it('isVisible and isHidden should work with details', async ({ page }) => {await expect(page.locator('ul')).toBeHidden();});+it('isVisible and isHidden should work with nested details', async ({ page }) => {+ await page.setContent(`<details>+ <summary>outer</summary>+ <details open>+ <summary>inner</summary>+ <button>hidden button</button>+ </details>+ </details>`);++ await expect(page.locator('summary', { hasText: 'outer' })).toBeVisible();+ await expect(page.locator('summary', { hasText: 'inner' })).toBeHidden();+ await expect(page.locator('button')).toBeHidden();+ await expect(page.getByRole('button')).toHaveCount(0);+});++it('isVisible and isHidden should work with unslotted content', async ({ page }) => {+ await page.setContent(`+ <div id=unslotted><span>hidden 1</span><div><span>hidden 2</span></div></div>+ <div id=slotted><span>visible</span></div>+ <script>+ unslotted.attachShadow({ mode: 'open' }).innerHTML = 'nothing to see here';+ slotted.attachShadow({ mode: 'open' }).innerHTML = '<slot></slot>';+ </script>+ `);++ await expect(page.locator('span', { hasText: 'hidden 1' })).toBeHidden();+ await expect(page.locator('span', { hasText: 'hidden 2' })).toBeHidden();+ await expect(page.locator('span', { hasText: 'visible' })).toBeVisible();+});++it('isVisible and isHidden should work with list box options', async ({ page }) => {+ await page.setContent(`+ <select multiple>+ <option>visible 1</option>+ <optgroup label="group"><option>visible 2</option></optgroup>+ <option hidden>hidden 1</option>+ <optgroup label="hidden group" style="display:none"><option>hidden 2</option></optgroup>+ </select>+ <select size=3><option>visible 3</option></select>+ <select multiple style="display:none"><option>hidden 3</option></select>+ `);++ for (const name of ['visible 1', 'visible 2', 'visible 3'])+ await expect(page.getByRole('option', { name, exact: true })).toBeVisible();+ for (const text of ['hidden 1', 'hidden 2', 'hidden 3'])+ await expect(page.locator('option', { hasText: text })).toBeHidden();+});+it('isVisible inside a button', async ({ page }) => {await page.setContent(`<button><span></span>a button</button>`);const span = page.locator('span');