Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

test: remove stale fixme/skips in capabilities spec (#36617)

Max Schmitt82ce7360fd0f
diff --git a/tests/library/capabilities.spec.ts b/tests/library/capabilities.spec.ts
index 9533021d7e..7332b70985 100644
--- a/tests/library/capabilities.spec.ts
+++ b/tests/library/capabilities.spec.ts
@@ -14,7 +14,6 @@
* limitations under the License.
*/
-import os from 'os';
import url from 'url';
import { contextTest as it, expect } from '../config/browserTest';
import { hostPlatform } from '../../packages/playwright-core/src/server/utils/hostPlatform';
@@ -31,8 +30,7 @@ it('SharedArrayBuffer should work @smoke', async function({ contextFactory, http
expect(await page.evaluate(() => typeof SharedArrayBuffer)).toBe('function');
});
-it('Web Assembly should work @smoke', async ({ page, server, browserName, platform }) => {
- it.fixme(browserName === 'webkit' && platform === 'win32', 'Windows JIT is disabled: https://bugs.webkit.org/show_bug.cgi?id=273854');
+it('Web Assembly should work @smoke', async ({ page, server }) => {
await page.goto(server.PREFIX + '/wasm/table2.html');
expect(await page.evaluate('loadTable()')).toBe('42, 83');
});
@@ -101,8 +99,7 @@ it('should play audio @smoke', async ({ page, server, browserName, platform }) =
expect(await page.$eval('audio', e => e.currentTime)).toBeGreaterThan(0.2);
});
-it('should support webgl @smoke', async ({ page, browserName, platform }) => {
- it.fixme(browserName === 'chromium' && platform === 'darwin' && os.arch() === 'arm64', 'SwiftShader is not available on macOS-arm64 - https://github.com/microsoft/playwright/issues/28216');
+it('should support webgl @smoke', async ({ page }) => {
const hasWebGL = await page.evaluate(() => {
const canvas = document.createElement('canvas');
return !!canvas.getContext('webgl');
@@ -110,11 +107,8 @@ it('should support webgl @smoke', async ({ page, browserName, platform }) => {
expect(hasWebGL).toBe(true);
});
-it('should support webgl 2 @smoke', async ({ page, browserName, headless, isWindows, platform }) => {
- it.skip(browserName === 'webkit', 'WebKit doesn\'t have webgl2 enabled yet upstream.');
+it('should support webgl 2 @smoke', async ({ page, browserName, isWindows }) => {
it.fixme(browserName === 'firefox' && isWindows);
- it.fixme(browserName === 'chromium' && !headless, 'chromium doesn\'t like webgl2 when running under xvfb');
- it.fixme(browserName === 'chromium' && platform === 'darwin' && os.arch() === 'arm64', 'SwiftShader is not available on macOS-arm64 - https://github.com/microsoft/playwright/issues/28216');
const hasWebGL2 = await page.evaluate(() => {
const canvas = document.createElement('canvas');
@@ -131,7 +125,6 @@ it('should not crash on page with mp4 @smoke', async ({ page, server, platform,
it('should not crash on showDirectoryPicker', async ({ page, server, browserName, browserMajorVersion }) => {
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/7339' });
- it.skip(browserName === 'chromium' && browserMajorVersion < 99, 'Fixed in Chromium r956769');
it.skip(browserName !== 'chromium', 'showDirectoryPicker is only available in Chromium');
await page.goto(server.EMPTY_PAGE);
// "User activation is required to show a file picker." - so we click first.
@@ -148,7 +141,6 @@ it('should not crash on showDirectoryPicker', async ({ page, server, browserName
it('should not crash on storage.getDirectory()', async ({ page, server, browserName, isMac }) => {
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/18235' });
- it.skip(browserName === 'firefox', 'navigator.storage.getDirectory is not a function');
await page.goto(server.EMPTY_PAGE);
const error = await page.evaluate(async () => {
const dir = await navigator.storage.getDirectory();
@@ -281,7 +273,6 @@ it('should send no Content-Length header for GET requests with a Content-Type',
it('Intl.ListFormat should work', async ({ page, server, browserName }) => {
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/23978' });
- it.skip(browserName === 'webkit' && hostPlatform.startsWith('ubuntu20.04'), 'libicu is too old and WebKit disables Intl.ListFormat by default then');
await page.goto(server.EMPTY_PAGE);
const formatted = await page.evaluate(() => {
const data = ['first', 'second', 'third'];
@@ -434,8 +425,7 @@ it('should not crash when clicking a color input', {
type: 'issue',
description: 'https://github.com/microsoft/playwright/issues/33864'
}
-}, async ({ page, browserMajorVersion, browserName }) => {
- it.skip(browserName === 'firefox' && browserMajorVersion < 135);
+}, async ({ page }) => {
await page.setContent('<input type="color">');
const input = page.locator('input');