Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

devops: update android bots to android-36 to fix failing tests (#43022)

Dmitry Gozman82db81d9b8b9
diff --git a/tests/page/locator-is-visible.spec.ts b/tests/page/locator-is-visible.spec.ts
index 2d4e681257..b182f8e479 100644
--- a/tests/page/locator-is-visible.spec.ts
+++ b/tests/page/locator-is-visible.spec.ts
@@ -90,7 +90,8 @@ it('isVisible and isHidden should work with unslotted content', async ({ page })
await expect(page.locator('span', { hasText: 'visible' })).toBeVisible();
});
-it('isVisible and isHidden should work with list box options', async ({ page }) => {
+it('isVisible and isHidden should work with list box options', async ({ page, isAndroid }) => {
+ it.skip(isAndroid, 'Android Chrome renders list boxes as popups, so options are not visible in the page');
await page.setContent(`
<select multiple>
<option>visible 1</option>
diff --git a/tests/page/page-evaluate.spec.ts b/tests/page/page-evaluate.spec.ts
index 84894686ff..30cd7a3462 100644
--- a/tests/page/page-evaluate.spec.ts
+++ b/tests/page/page-evaluate.spec.ts
@@ -894,10 +894,11 @@ it('should work with Array.from/map', async ({ page }) => {
})).toBe('([a-f0-9]{2})([a-f0-9]{2})([a-f0-9]{2})');
});
-it('should work with a using declaration', async ({ page, nodeVersion, browserName }) => {
+it('should work with a using declaration', async ({ page, nodeVersion, browserName, browserMajorVersion }) => {
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/41511' });
it.skip(nodeVersion.major < 24, 'using is lowered to a module-scope helper that does not survive evaluate serialization on Node < 24');
it.skip(browserName === 'webkit', 'WebKit does not support using declarations');
+ it.skip(browserName === 'chromium' && browserMajorVersion < 134, 'Chromium supports using declarations since 134');
const disposed = await page.evaluate(() => {
let disposed = false;
{
diff --git a/utils/avd_install.sh b/utils/avd_install.sh
index a7264ebaf7..1124de5eb9 100755
--- a/utils/avd_install.sh
+++ b/utils/avd_install.sh
@@ -24,7 +24,7 @@ echo Installing emulator...
yes | ${ANDROID_HOME}/cmdline-tools/latest/bin/sdkmanager --install platform-tools emulator
echo Installing platform SDK...
-yes | ${ANDROID_HOME}/cmdline-tools/latest/bin/sdkmanager --install "platforms;android-35"
+yes | ${ANDROID_HOME}/cmdline-tools/latest/bin/sdkmanager --install "platforms;android-36"
echo Starting ADB...
${ANDROID_HOME}/platform-tools/adb devices
diff --git a/utils/avd_recreate.sh b/utils/avd_recreate.sh
index 1b1c050942..651f423ba2 100755
--- a/utils/avd_recreate.sh
+++ b/utils/avd_recreate.sh
@@ -20,7 +20,7 @@ if [[ "$(uname -m)" == "arm64" ]]; then
ANDROID_ARCH="arm64-v8a"
fi
-${ANDROID_HOME}/cmdline-tools/latest/bin/avdmanager delete avd --name android35 || true
-yes | ${ANDROID_HOME}/cmdline-tools/latest/bin/sdkmanager --install "system-images;android-35;google_apis;$ANDROID_ARCH" platform-tools emulator
-echo "no" | ${ANDROID_HOME}/cmdline-tools/latest/bin/avdmanager create avd --force --name android35 --device "Nexus 5X" --package "system-images;android-35;google_apis;$ANDROID_ARCH"
+${ANDROID_HOME}/cmdline-tools/latest/bin/avdmanager delete avd --name android36 || true
+yes | ${ANDROID_HOME}/cmdline-tools/latest/bin/sdkmanager --install "system-images;android-36;google_apis;$ANDROID_ARCH" platform-tools emulator
+echo "no" | ${ANDROID_HOME}/cmdline-tools/latest/bin/avdmanager create avd --force --name android36 --device "Nexus 5X" --package "system-images;android-36;google_apis;$ANDROID_ARCH"
${ANDROID_HOME}/emulator/emulator -list-avds
diff --git a/utils/avd_start.sh b/utils/avd_start.sh
index 7fa111fcbb..5d99c95233 100755
--- a/utils/avd_start.sh
+++ b/utils/avd_start.sh
@@ -19,7 +19,7 @@ if [[ "${PWTEST_ANDROID_NO_ACCEL}" == "1" ]]; then
fi
echo "Starting emulator"
-nohup ${ANDROID_HOME}/emulator/emulator -avd android35 -no-audio -no-window -no-boot-anim -no-snapshot "${EMULATOR_EXTRA_ARGS[@]}" &
+nohup ${ANDROID_HOME}/emulator/emulator -avd android36 -no-audio -no-window -no-boot-anim -no-snapshot "${EMULATOR_EXTRA_ARGS[@]}" &
${ANDROID_HOME}/platform-tools/adb wait-for-device shell 'while [[ -z $(getprop sys.boot_completed | tr -d '\r') ]]; do sleep 1; done; input keyevent 82'
${ANDROID_HOME}/platform-tools/adb devices
echo "Emulator started"