Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore(mcp): test graceful http server shutdown on windows (#37484)

Yury Semikhatsky83cd5af5b5d0
diff --git a/packages/playwright/src/mcp/sdk/http.ts b/packages/playwright/src/mcp/sdk/http.ts
index d9359880a3..4d941d0b0d 100644
--- a/packages/playwright/src/mcp/sdk/http.ts
+++ b/packages/playwright/src/mcp/sdk/http.ts
@@ -64,6 +64,13 @@ export async function installHttpTransport(httpServer: http.Server, serverBacken
const streamableSessions = new Map();
httpServer.on('request', async (req, res) => {
const url = new URL(`http://localhost${req.url}`);
+ if (url.pathname === '/killkillkill' && req.method === 'GET') {
+ res.statusCode = 200;
+ res.end('Killing process');
+ // Simulate Ctrl+C in a way that works on Windows too.
+ process.emit('SIGINT');
+ return;
+ }
if (url.pathname.startsWith('/sse'))
await handleSSE(serverBackendFactory, req, res, url, sseSessions);
else
diff --git a/tests/mcp/http.spec.ts b/tests/mcp/http.spec.ts
index 458b2e6c6e..af43cc4bd3 100644
--- a/tests/mcp/http.spec.ts
+++ b/tests/mcp/http.spec.ts
@@ -24,7 +24,7 @@ import { test as baseTest, expect, mcpServerPath } from './fixtures';
import type { Config } from '../../packages/playwright/src/mcp/config';
import { ListRootsRequestSchema } from 'packages/playwright/lib/mcp/sdk/bundle';
-const test = baseTest.extend<{ serverEndpoint: (options?: { args?: string[], noPort?: boolean }) => Promise<{ url: URL, stderr: () => string, kill: () => void }> }>({
+const test = baseTest.extend<{ serverEndpoint: (options?: { args?: string[], noPort?: boolean }) => Promise<{ url: URL, stderr: () => string }> }>({
serverEndpoint: async ({ mcpHeadless }, use, testInfo) => {
let cp: ChildProcess | undefined;
const userDataDir = testInfo.outputPath('user-data-dir');
@@ -55,10 +55,7 @@ const test = baseTest.extend<{ serverEndpoint: (options?: { args?: string[], noP
resolve(match[1]);
}));
- return { url: new URL(url), stderr: () => stderr, kill: () => {
- cp?.kill('SIGTERM');
- cp = undefined;
- } };
+ return { url: new URL(url), stderr: () => stderr };
});
cp?.kill('SIGTERM');
},
@@ -249,7 +246,7 @@ test('http transport browser lifecycle (persistent, multiclient)', async ({ serv
});
test('http transport shared context', async ({ serverEndpoint, server }) => {
- const { url, stderr, kill } = await serverEndpoint({ args: ['--shared-browser-context'] });
+ const { url, stderr } = await serverEndpoint({ args: ['--shared-browser-context'] });
// Create first client and navigate
const transport1 = new StreamableHTTPClientTransport(new URL('/mcp', url));
@@ -304,15 +301,15 @@ test('http transport shared context', async ({ serverEndpoint, server }) => {
expect(lines.filter(line => line.match(/close browser context complete \(persistent\)/)).length).toBe(0);
}).toPass();
- kill();
+ // Simulate Ctrl+C in a way that works on Windows too.
+ await fetch(new URL('/killkillkill', url).href).catch(() => {});
+
+ await expect(async () => {
+ const lines = stderr().split('\n');
+ // Context should only close when the server shuts down.
+ expect(lines.filter(line => line.match(/close browser context complete \(persistent\)/)).length).toBe(1);
+ }).toPass();
- if (process.platform !== 'win32') {
- await expect(async () => {
- const lines = stderr().split('\n');
- // Context should only close when the server shuts down.
- expect(lines.filter(line => line.match(/close browser context complete \(persistent\)/)).length).toBe(1);
- }).toPass();
- }
});
test('http transport (default)', async ({ serverEndpoint }) => {
diff --git a/tests/mcp/sse.spec.ts b/tests/mcp/sse.spec.ts
index c214e44157..c1c8c9cdf5 100644
--- a/tests/mcp/sse.spec.ts
+++ b/tests/mcp/sse.spec.ts
@@ -23,7 +23,7 @@ import { test as baseTest, expect, mcpServerPath } from './fixtures';
import type { Config } from '../../packages/playwright/src/mcp/config';
-const test = baseTest.extend<{ serverEndpoint: (options?: { args?: string[], noPort?: boolean }) => Promise<{ url: URL, stderr: () => string, kill: () => void }> }>({
+const test = baseTest.extend<{ serverEndpoint: (options?: { args?: string[], noPort?: boolean }) => Promise<{ url: URL, stderr: () => string }> }>({
serverEndpoint: async ({ mcpHeadless }, use, testInfo) => {
let cp: ChildProcess | undefined;
const userDataDir = testInfo.outputPath('user-data-dir');
@@ -54,10 +54,7 @@ const test = baseTest.extend<{ serverEndpoint: (options?: { args?: string[], noP
resolve(match[1]);
}));
- return { url: new URL(url), stderr: () => stderr, kill: () => {
- cp?.kill('SIGTERM');
- cp = undefined;
- } };
+ return { url: new URL(url), stderr: () => stderr };
});
cp?.kill('SIGTERM');
},
@@ -234,7 +231,7 @@ test('sse transport browser lifecycle (persistent, multiclient)', async ({ serve
});
test('sse transport shared context', async ({ serverEndpoint, server }) => {
- const { url, stderr, kill } = await serverEndpoint({ args: ['--shared-browser-context'] });
+ const { url, stderr } = await serverEndpoint({ args: ['--shared-browser-context'] });
// Create first client and navigate
const transport1 = new SSEClientTransport(new URL('/sse', url));
@@ -287,13 +284,11 @@ test('sse transport shared context', async ({ serverEndpoint, server }) => {
expect(lines.filter(line => line.match(/close browser context complete \(persistent\)/)).length).toBe(0);
}).toPass();
- kill();
+ await fetch(new URL('/killkillkill', url).href).catch(() => {});
- if (process.platform !== 'win32') {
- await expect(async () => {
- const lines = stderr().split('\n');
- // Context should only close when the server shuts down.
- expect(lines.filter(line => line.match(/close browser context complete \(persistent\)/)).length).toBe(1);
- }).toPass();
- }
+ await expect(async () => {
+ const lines = stderr().split('\n');
+ // Context should only close when the server shuts down.
+ expect(lines.filter(line => line.match(/close browser context complete \(persistent\)/)).length).toBe(1);
+ }).toPass();
});