Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
fix(cli): show full tab list when opening with --extension (#39230)
Yury Semikhatsky872cc0d3b0ae
diff --git a/packages/playwright/src/mcp/extension/extensionContextFactory.ts b/packages/playwright/src/mcp/extension/extensionContextFactory.tsindex 1ff619c17e..f225a624fd 100644--- a/packages/playwright/src/mcp/extension/extensionContextFactory.ts+++ b/packages/playwright/src/mcp/extension/extensionContextFactory.ts@@ -29,13 +29,11 @@ export class ExtensionContextFactory implements BrowserContextFactory {private _browserChannel: string;private _userDataDir?: string;private _executablePath?: string;- private _forceNewTab: boolean;- constructor(browserChannel: string, userDataDir: string | undefined, executablePath: string | undefined, forceNewTab: boolean) {+ constructor(browserChannel: string, userDataDir: string | undefined, executablePath: string | undefined) {this._browserChannel = browserChannel;this._userDataDir = userDataDir;this._executablePath = executablePath;- this._forceNewTab = forceNewTab;}async createContext(clientInfo: ClientInfo, abortSignal: AbortSignal, options: { toolName?: string }): Promise<{ browserContext: playwright.BrowserContext, close: () => Promise<void> }> {@@ -51,7 +49,7 @@ export class ExtensionContextFactory implements BrowserContextFactory {private async _obtainBrowser(clientInfo: ClientInfo, abortSignal: AbortSignal, toolName: string | undefined): Promise<playwright.Browser> {const relay = await this._startRelay(abortSignal);- const forceNewTab = this._forceNewTab || toolName === 'browser_navigate';+ const forceNewTab = toolName === 'browser_navigate';await relay.ensureExtensionConnectionForMCPContext(clientInfo, abortSignal, forceNewTab);return await playwright.chromium.connectOverCDP(relay.cdpEndpoint(), { isLocal: true });}diff --git a/packages/playwright/src/mcp/program.ts b/packages/playwright/src/mcp/program.tsindex d97c64d261..bb515bee37 100644--- a/packages/playwright/src/mcp/program.ts+++ b/packages/playwright/src/mcp/program.ts@@ -106,9 +106,7 @@ export function decorateCommand(command: Command, version: string) {}const browserContextFactory = contextFactory(config);- // Always force new tab in cli mode as the first command is always navigation.- const forceNewTab = !!config.sessionConfig;- const extensionContextFactory = new ExtensionContextFactory(config.browser.launchOptions.channel || 'chrome', config.browser.userDataDir, config.browser.launchOptions.executablePath, forceNewTab);+ const extensionContextFactory = new ExtensionContextFactory(config.browser.launchOptions.channel || 'chrome', config.browser.userDataDir, config.browser.launchOptions.executablePath);if (config.sessionConfig) {const contextFactory = config.extension ? extensionContextFactory : browserContextFactory;diff --git a/packages/playwright/src/mcp/terminal/commands.ts b/packages/playwright/src/mcp/terminal/commands.tsindex f8beb4ae82..1b1bc37f49 100644--- a/packages/playwright/src/mcp/terminal/commands.ts+++ b/packages/playwright/src/mcp/terminal/commands.ts@@ -48,7 +48,7 @@ const open = declareCommand({persistent: z.boolean().optional().describe('Use persistent browser profile'),profile: z.string().optional().describe('Use persistent browser profile, store profile in specified directory.'),}),- toolName: 'browser_navigate',+ toolName: ({ url }) => url ? 'browser_navigate' : 'browser_snapshot',toolParams: ({ url }) => ({ url: url || 'about:blank' }),});diff --git a/tests/mcp/cli-navigation.spec.ts b/tests/mcp/cli-navigation.spec.tsindex 32bd07b9d0..07c9264a09 100644--- a/tests/mcp/cli-navigation.spec.ts+++ b/tests/mcp/cli-navigation.spec.ts@@ -35,6 +35,11 @@ test('go-forward', async ({ cli, server }) => {- Page Title: Title`);});+test('open without url opens about:blank', async ({ cli }) => {+ const { output } = await cli('open');+ expect(output).toContain('- Page URL: about:blank');+});+test('run-code', async ({ cli, server }) => {await cli('open', server.HELLO_WORLD);const { output } = await cli('run-code', '() => page.title()');