Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

devops: job.status is only per composite action :/ (#39390)

Simon Knott87587a305fd3
diff --git a/.github/actions/run-test/action.yml b/.github/actions/run-test/action.yml
index 34944f57ae..f1c15d5abd 100644
--- a/.github/actions/run-test/action.yml
+++ b/.github/actions/run-test/action.yml
@@ -86,7 +86,7 @@ runs:
if: ${{ !cancelled() }}
shell: bash
- name: Upload blob report
- if: ${{ !cancelled() }}
+ if: ${{ !cancelled() && (github.event_name == 'pull_request' || failure()) }}
uses: ./.github/actions/upload-blob-report
with:
report_dir: blob-report
diff --git a/.github/actions/upload-blob-report/action.yml b/.github/actions/upload-blob-report/action.yml
index 12edf46ce1..5992e7017b 100644
--- a/.github/actions/upload-blob-report/action.yml
+++ b/.github/actions/upload-blob-report/action.yml
@@ -16,7 +16,7 @@ runs:
shell: bash
run: find "${{ inputs.report_dir }}" -name "*.zip" -exec unzip -t {} \;
- name: Upload blob report to GitHub
- if: ${{ !cancelled() && (github.event_name == 'pull_request' || job.status == 'failure') }}
+ if: ${{ !cancelled() }}
uses: actions/upload-artifact@v4
with:
name: blob-report-${{ inputs.job_name }}
diff --git a/.github/workflows/create_test_report.yml b/.github/workflows/create_test_report.yml
index 3475ea0db9..5d5ff39f3c 100644
--- a/.github/workflows/create_test_report.yml
+++ b/.github/workflows/create_test_report.yml
@@ -66,5 +66,5 @@ jobs:
sha: '${{ github.event.workflow_run.head_sha }}',
state: 'success',
target_url: '${{ steps.upload-report.outputs.reportUrl }}',
- context: 'HTML Report',
+ context: 'HTML Report (${{ github.event.workflow_run.name }})',
});
diff --git a/.github/workflows/tests_primary.yml b/.github/workflows/tests_primary.yml
index 6258a602d1..dbc0924c39 100644
--- a/.github/workflows/tests_primary.yml
+++ b/.github/workflows/tests_primary.yml
@@ -182,7 +182,7 @@ jobs:
env:
PW_TAG: "@vscode-extension"
- name: Upload blob report
- if: ${{ !cancelled() }}
+ if: ${{ !cancelled() && (github.event_name == 'pull_request' || failure()) }}
uses: ./.github/actions/upload-blob-report
with:
report_dir: playwright-vscode/blob-report