Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
fix(edge): cancel downloads before closing the context (#40034)
Dmitry Gozman883825e4d62a
diff --git a/packages/playwright-core/src/server/chromium/crBrowser.ts b/packages/playwright-core/src/server/chromium/crBrowser.tsindex e3c7b5b2bd..440439ed72 100644--- a/packages/playwright-core/src/server/chromium/crBrowser.ts+++ b/packages/playwright-core/src/server/chromium/crBrowser.ts@@ -558,6 +558,9 @@ export class CRBrowserContext extends BrowserContext<CREventsMap> {return 'close-browser';}+ // Ongoing downloads cause crashes in Edge, so cancel them first.+ await Promise.all([...this._downloads].map(download => download.cancel().catch(() => {})));+await this._browser._session.send('Target.disposeBrowserContext', { browserContextId: this._browserContextId });this._browser._contexts.delete(this._browserContextId);for (const [targetId, serviceWorker] of this._browser._serviceWorkers) {diff --git a/packages/playwright-core/src/server/download.ts b/packages/playwright-core/src/server/download.tsindex 8a88eafcf0..95ba4eb2b1 100644--- a/packages/playwright-core/src/server/download.ts+++ b/packages/playwright-core/src/server/download.ts@@ -23,23 +23,28 @@ import { Artifact } from './artifact';export class Download {readonly artifact: Artifact;readonly url: string;+ private _uuid: string;private _page: Page;private _suggestedFilename: string | undefined;constructor(page: Page, downloadsPath: string, uuid: string, url: string, suggestedFilename?: string, downloadFilename?: string) {const unaccessibleErrorMessage = page.browserContext._options.acceptDownloads === 'deny' ? 'Pass { acceptDownloads: true } when you are creating your browser context.' : undefined;const downloadPath = path.join(downloadsPath, downloadFilename ?? uuid);- this.artifact = new Artifact(page, downloadPath, unaccessibleErrorMessage, () => {- return this._page.browserContext.cancelDownload(uuid);- });+ this.artifact = new Artifact(page, downloadPath, unaccessibleErrorMessage, () => this.cancel());this._page = page;this.url = url;+ this._uuid = uuid;this._suggestedFilename = suggestedFilename;+ // Note: downloads are never removed from the context, so that we can delete them upon context closure.page.browserContext._downloads.add(this);if (suggestedFilename !== undefined)this._fireDownloadEvent();}+ cancel() {+ return this._page.browserContext.cancelDownload(this._uuid);+ }+filenameSuggested(suggestedFilename: string) {assert(this._suggestedFilename === undefined);this._suggestedFilename = suggestedFilename;