Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
chore: a few fixes for vscode agents (#37535)
Dmitry Gozman89b74e9399eb
diff --git a/packages/playwright/src/agents/generateAgents.ts b/packages/playwright/src/agents/generateAgents.tsindex 211aab6c57..eac59189a6 100644--- a/packages/playwright/src/agents/generateAgents.ts+++ b/packages/playwright/src/agents/generateAgents.ts@@ -216,22 +216,38 @@ const vscodeToolMap = new Map<string, string[]>([['edit', ['editFiles']],['write', ['createFile', 'createDirectory']],]);+const vscodeToolsOrder = ['createFile', 'createDirectory', 'editFiles', 'fileSearch', 'textSearch', 'listDirectory', 'readFile'];+const vscodeToolPrefix = 'test_'; // FIXME: this is ugly, fix VSCode!function saveAsVSCodeChatmode(agent: Agent): string {function asVscodeTool(tool: string): string | string[] {const [first, second] = tool.split('/');if (second)- return second;+ return second.startsWith('browser_') ? vscodeToolPrefix + second : second;return vscodeToolMap.get(first) || first;}- const tools = agent.header.tools.map(asVscodeTool).flat().map(tool => `'${tool}'`).join(', ');+ const tools = agent.header.tools.map(asVscodeTool).flat().sort((a, b) => {+ // VSCode insisits on the specific tools order when editing agent config.+ const indexA = vscodeToolsOrder.indexOf(a);+ const indexB = vscodeToolsOrder.indexOf(b);+ if (indexA === -1 && indexB === -1)+ return a.localeCompare(b);+ if (indexA === -1)+ return 1;+ if (indexB === -1)+ return -1;+ return indexA - indexB;+ }).map(tool => `'${tool}'`).join(', ');const lines: string[] = [];lines.push(`---`);- lines.push(`description: ${agent.header.description}. Examples: ${agent.examples.map(example => `<example>${example}</example>`).join('')}`);+ lines.push(`description: ${agent.header.description}.`);lines.push(`tools: [${tools}]`);lines.push(`---`);lines.push('');lines.push(agent.instructions);+ for (const example of agent.examples)+ lines.push(`<example>${example}</example>`);+return lines.join('\n');}@@ -261,6 +277,7 @@ export async function initVSCodeRepo() {type: 'stdio',command: commonMcpServers.playwrightTest.command,args: commonMcpServers.playwrightTest.args,+ env: { 'PLAYWRIGHT_MCP_TOOL_PREFIX': vscodeToolPrefix },};await writeFile(mcpJsonPath, JSON.stringify(mcpJson, null, 2));}diff --git a/packages/playwright/src/mcp/browser/tools.ts b/packages/playwright/src/mcp/browser/tools.tsindex 3ebbe7591e..e5927c2888 100644--- a/packages/playwright/src/mcp/browser/tools.ts+++ b/packages/playwright/src/mcp/browser/tools.ts@@ -57,6 +57,13 @@ export const browserTools: Tool<any>[] = [...verify,];+// FIXME: this is ugly, fix VSCode!+const customPrefix = process.env.PLAYWRIGHT_MCP_TOOL_PREFIX;+if (customPrefix) {+ for (const tool of browserTools)+ tool.schema.name = customPrefix + tool.schema.name;+}+export function filteredTools(config: FullConfig) {return browserTools.filter(tool => tool.capability.startsWith('core') || config.capabilities?.includes(tool.capability));}diff --git a/tests/mcp/vscode.spec.ts b/tests/mcp/vscode.spec.tsindex fc0b8187e8..f563d39ed0 100644--- a/tests/mcp/vscode.spec.ts+++ b/tests/mcp/vscode.spec.ts@@ -118,3 +118,28 @@ test('browser_connect(debugController) works', async ({ startClient }) => {await expect.poll(() => messages).toContainEqual(expect.objectContaining({ method: 'stateChanged' }));});++test('tool prefix', async ({ startClient, server }) => {+ const { client } = await startClient({ env: { 'PLAYWRIGHT_MCP_TOOL_PREFIX': 'test_' } });+ expect(await client.callTool({+ name: 'test_browser_navigate',+ arguments: { url: server.HELLO_WORLD },+ })).toHaveResponse({+ code: `await page.goto('${server.HELLO_WORLD}');`,+ pageState: `- Page URL: ${server.HELLO_WORLD}+- Page Title: Title+- Page Snapshot:+\`\`\`yaml+- generic [active] [ref=e1]: Hello, world!+\`\`\``,+ });+});++test.describe(() => {+ test.use({ mcpServerType: 'test-mcp' });+ test('tool prefix does not affect test tools', async ({ startClient }) => {+ const { client } = await startClient({ env: { 'PLAYWRIGHT_MCP_TOOL_PREFIX': 'test_' } });+ const { tools } = await client.listTools();+ expect(tools.map(t => t.name)).toContain('test_setup_page');+ });+});