Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
fix(serviceWorkers): don't throw in opaque sandboxed iframes when blocking (#43134)
Pavel Feldman89eb0ed35c55
diff --git a/packages/playwright-core/src/server/browserContext.ts b/packages/playwright-core/src/server/browserContext.tsindex e43f2348a6..08abd03d0d 100644--- a/packages/playwright-core/src/server/browserContext.ts+++ b/packages/playwright-core/src/server/browserContext.ts@@ -171,7 +171,7 @@ export abstract class BrowserContext<EM extends EventMap = EventMap> extends Sdkawait this._exposeConsoleApi();if (this._options.serviceWorkers === 'block')- await this.addInitScript(nullProgress, `\nif (navigator.serviceWorker) navigator.serviceWorker.register = async () => { console.warn('Service Worker registration blocked by Playwright'); };\n`);+ await this.addInitScript(nullProgress, `\nif (self.ServiceWorkerContainer) ServiceWorkerContainer.prototype.register = async () => { console.warn('Service Worker registration blocked by Playwright'); };\n`);if (this._options.permissions)await this.grantPermissions(this._options.permissions);diff --git a/tests/library/browsercontext-service-worker-policy.spec.ts b/tests/library/browsercontext-service-worker-policy.spec.tsindex 5f660269d7..3db87f9469 100644--- a/tests/library/browsercontext-service-worker-policy.spec.ts+++ b/tests/library/browsercontext-service-worker-policy.spec.ts@@ -114,4 +114,14 @@ it.describe('block', () => {await page.goto('about:blank');expect(errors).toEqual([]);});++ it('should not throw error in opaque sandboxed iframe', async ({ page, server }) => {+ it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/43113' });+ const errors = [];+ page.on('pageerror', error => errors.push(error));+ await page.goto(server.EMPTY_PAGE);+ await page.setContent('<iframe sandbox="allow-scripts" srcdoc="<p>Preview</p>"></iframe>');+ await expect(page.frameLocator('iframe').locator('p')).toHaveText('Preview');+ expect(errors).toEqual([]);+ });});