Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
chore(ci): automatically update Docker to latest NodeJS LTS (#38163)
Adam Gastineau8c3be44af241
diff --git a/.github/workflows/roll_driver_nodejs.yml b/.github/workflows/roll_nodejs.ymlsimilarity index 83%rename from .github/workflows/roll_driver_nodejs.ymlrename to .github/workflows/roll_nodejs.ymlindex 0ab2a9e2ea..2bf362bfa5 100644--- a/.github/workflows/roll_driver_nodejs.yml+++ b/.github/workflows/roll_nodejs.yml@@ -1,4 +1,4 @@-name: "PR: bump driver Node.js"+name: "PR: bump driver/Docker Node.js"on:workflow_dispatch:schedule:@@ -16,7 +16,7 @@ jobs:- uses: actions/setup-node@v6with:node-version: 20- - run: node utils/build/update-playwright-driver-version.mjs+ - run: node utils/build/update-playwright-node.mjs- name: Prepare branchid: prepare-branchrun: |@@ -25,13 +25,13 @@ jobs:exit 0;fiecho "HAS_CHANGES=1" >> $GITHUB_OUTPUT- BRANCH_NAME="roll-driver-nodejs/$(date +%Y-%b-%d)"+ BRANCH_NAME="roll-platform-nodejs/$(date +%Y-%b-%d)"echo "BRANCH_NAME=$BRANCH_NAME" >> $GITHUB_OUTPUTgit config --global user.name microsoft-playwright-automation[bot]git config --global user.email 203992400+microsoft-playwright-automation[bot]@users.noreply.github.comgit checkout -b "$BRANCH_NAME"git add .- git commit -m "chore(driver): roll driver to recent Node.js LTS version"+ git commit -m "chore: roll driver/Dockerfile to recent Node.js LTS version"git push origin $BRANCH_NAME- uses: actions/create-github-app-token@v2id: app-token@@ -49,5 +49,5 @@ jobs:repo: 'playwright',head: 'microsoft:${{ steps.prepare-branch.outputs.BRANCH_NAME }}',base: 'main',- title: 'chore(driver): roll driver to recent Node.js LTS version',+ title: 'chore: roll driver/Dockerfile to recent Node.js LTS version',});diff --git a/utils/build/build-playwright-driver.sh b/utils/build/build-playwright-driver.shindex d6a62457d2..43d2d0e2a0 100755--- a/utils/build/build-playwright-driver.sh+++ b/utils/build/build-playwright-driver.sh@@ -4,7 +4,7 @@ set -xtrap "cd $(pwd -P)" EXITSCRIPT_PATH="$(cd "$(dirname "$0")" ; pwd -P)"-NODE_VERSION="24.11.0" # autogenerated via ./update-playwright-driver-version.mjs+NODE_VERSION="24.11.0" # autogenerated via ./update-playwright-node.mjscd "$(dirname "$0")"PACKAGE_VERSION=$(node -p "require('../../package.json').version")diff --git a/utils/build/update-playwright-driver-version.mjs b/utils/build/update-playwright-node.mjssimilarity index 51%rename from utils/build/update-playwright-driver-version.mjsrename to utils/build/update-playwright-node.mjsindex d3b8907353..747c983a6f 100644--- a/utils/build/update-playwright-driver-version.mjs+++ b/utils/build/update-playwright-node.mjs@@ -20,10 +20,25 @@ import https from 'https';const currentFilePath = url.fileURLToPath(import.meta.url);const buildFilePath = path.join(path.dirname(currentFilePath), 'build-playwright-driver.sh');+const dockerDirectory = path.join(path.dirname(currentFilePath), '../docker');+const dockerfilePaths = await getDockerfilePaths(dockerDirectory);+const latestNodeJsLts = await getLatestNodeJsVersion();-refreshBuildScriptVersionNumber(latestNodeJsLts, buildFilePath);-console.log(`Updated build script ${path.relative(process.cwd(), buildFilePath)} to Node.js ${latestNodeJsLts}`);+if (refreshBuildScriptVersionNumber(latestNodeJsLts, buildFilePath))+ console.log(`Updated build script ${path.relative(process.cwd(), buildFilePath)} to Node.js ${latestNodeJsLts}`);+for (const dockerfilePath of dockerfilePaths) {+ const nodeMajorVersion = latestNodeJsLts.split('.')[0];+ if (refreshDockerfileVersionNumber(nodeMajorVersion, dockerfilePath))+ console.log(`Updated Dockerfile ${path.relative(process.cwd(), dockerfilePath)} to Node.js ${nodeMajorVersion}.x`);+}++async function getDockerfilePaths(directory) {+ const entries = await fs.promises.readdir(directory);+ return entries+ .filter(entry => entry.startsWith('Dockerfile'))+ .map(entry => path.join(directory, entry));+}function getLatestNodeJsVersion() {return new Promise((resolve, reject) => {@@ -41,9 +56,19 @@ function getLatestNodeJsVersion() {});}+function replaceVersionInFile(filePath, newNodeJsVersion, replacementRegex) {+ const fileContent = fs.readFileSync(filePath, 'utf8');+ const newFileContent = fileContent.replace(replacementRegex, `$1${newNodeJsVersion}$3`);+ fs.writeFileSync(filePath, newFileContent);+ return fileContent !== newFileContent;+}+function refreshBuildScriptVersionNumber(newNodeJsVersion, buildScriptPath) {const replacementRegex = new RegExp(`(NODE_VERSION=")(.*)(" # autogenerated via \\.\/${path.basename(currentFilePath).replace('.', '\\.')})`);- let buildFile = fs.readFileSync(buildFilePath, 'utf8');- buildFile = buildFile.replace(replacementRegex, `$1${latestNodeJsLts}$3`);- fs.writeFileSync(buildFilePath, buildFile);+ return replaceVersionInFile(buildScriptPath, newNodeJsVersion, replacementRegex);+}++function refreshDockerfileVersionNumber(newNodeJsVersion, dockerfilePath) {+ const replacementRegex = new RegExp(`(ARG NODE_VERSION=)(.*)( # autogenerated via \\.\/${path.basename(currentFilePath).replace('.', '\\.')})`);+ return replaceVersionInFile(dockerfilePath, newNodeJsVersion, replacementRegex);}diff --git a/utils/docker/Dockerfile.jammy b/utils/docker/Dockerfile.jammyindex d4d0cbad8a..c9e30c12c2 100644--- a/utils/docker/Dockerfile.jammy+++ b/utils/docker/Dockerfile.jammy@@ -3,6 +3,7 @@ FROM ubuntu:jammyARG DEBIAN_FRONTEND=noninteractiveARG TZ=America/Los_AngelesARG DOCKER_IMAGE_NAME_TEMPLATE="mcr.microsoft.com/playwright:v%version%-jammy"+ARG NODE_VERSION=22 # autogenerated via ./update-playwright-node.mjsENV LANG=C.UTF-8ENV LC_ALL=C.UTF-8@@ -14,7 +15,7 @@ RUN apt-get update && \apt-get install -y curl wget gpg ca-certificates && \mkdir -p /etc/apt/keyrings && \curl -sL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg && \- echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_22.x nodistro main" >> /etc/apt/sources.list.d/nodesource.list && \+ echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_${NODE_VERSION}.x nodistro main" >> /etc/apt/sources.list.d/nodesource.list && \apt-get update && \apt-get install -y nodejs && \# Feature-parity with node.js base images.diff --git a/utils/docker/Dockerfile.noble b/utils/docker/Dockerfile.nobleindex 62ec6232c2..dc4a77d46c 100644--- a/utils/docker/Dockerfile.noble+++ b/utils/docker/Dockerfile.noble@@ -3,6 +3,7 @@ FROM ubuntu:nobleARG DEBIAN_FRONTEND=noninteractiveARG TZ=America/Los_AngelesARG DOCKER_IMAGE_NAME_TEMPLATE="mcr.microsoft.com/playwright:v%version%-noble"+ARG NODE_VERSION=22 # autogenerated via ./update-playwright-node.mjsENV LANG=C.UTF-8ENV LC_ALL=C.UTF-8@@ -14,7 +15,7 @@ RUN apt-get update && \apt-get install -y curl wget gpg ca-certificates && \mkdir -p /etc/apt/keyrings && \curl -sL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg && \- echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_22.x nodistro main" >> /etc/apt/sources.list.d/nodesource.list && \+ echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_${NODE_VERSION}.x nodistro main" >> /etc/apt/sources.list.d/nodesource.list && \apt-get update && \apt-get install -y nodejs && \# Feature-parity with node.js base images.