Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix(mcp): fix configs saveVideo option (#38621)

Pavel Feldman8dff40968065
diff --git a/packages/playwright/src/mcp/browser/browserContextFactory.ts b/packages/playwright/src/mcp/browser/browserContextFactory.ts
index 3907786080..db84d10316 100644
--- a/packages/playwright/src/mcp/browser/browserContextFactory.ts
+++ b/packages/playwright/src/mcp/browser/browserContextFactory.ts
@@ -23,7 +23,7 @@ import * as playwright from 'playwright-core';
import { registryDirectory } from 'playwright-core/lib/server/registry/index';
import { startTraceViewerServer } from 'playwright-core/lib/server';
import { logUnhandledError, testDebug } from '../log';
-import { outputFile } from './config';
+import { outputFile, tmpDir } from './config';
import { firstRootPath } from '../sdk/server';
import type { FullConfig } from './config';
@@ -143,7 +143,7 @@ class IsolatedContextFactory extends BaseContextFactory {
}
protected override async _doCreateContext(browser: playwright.Browser): Promise<playwright.BrowserContext> {
- return browser.newContext(this.config.browser.contextOptions);
+ return browser.newContext(browserContextOptionsFromConfig(this.config));
}
}
@@ -206,7 +206,7 @@ class PersistentContextFactory implements BrowserContextFactory {
const launchOptions: LaunchOptions & BrowserContextOptions = {
tracesDir,
...this.config.browser.launchOptions,
- ...this.config.browser.contextOptions,
+ ...browserContextOptionsFromConfig(this.config),
handleSIGINT: false,
handleSIGTERM: false,
ignoreDefaultArgs: [
@@ -345,3 +345,14 @@ async function computeTracesDir(config: FullConfig, clientInfo: ClientInfo): Pro
return;
return await outputFile(config, clientInfo, `traces`, { origin: 'code', reason: 'Collecting trace' });
}
+
+function browserContextOptionsFromConfig(config: FullConfig): playwright.BrowserContextOptions {
+ const result = { ...config.browser.contextOptions };
+ if (config.saveVideo) {
+ result.recordVideo = {
+ dir: tmpDir(),
+ size: config.saveVideo,
+ };
+ }
+ return result;
+}
diff --git a/packages/playwright/src/mcp/browser/config.ts b/packages/playwright/src/mcp/browser/config.ts
index 73a69f5ad0..38745c0d6e 100644
--- a/packages/playwright/src/mcp/browser/config.ts
+++ b/packages/playwright/src/mcp/browser/config.ts
@@ -222,14 +222,6 @@ export function configFromCLIOptions(cliOptions: CLIOptions): Config {
if (cliOptions.grantPermissions)
contextOptions.permissions = cliOptions.grantPermissions;
- if (cliOptions.saveVideo) {
- contextOptions.recordVideo = {
- // Videos are moved to output directory on saveAs.
- dir: tmpDir(),
- size: cliOptions.saveVideo,
- };
- }
-
const result: Config = {
browser: {
browserName,
@@ -330,7 +322,7 @@ async function loadConfig(configFile: string | undefined): Promise<Config> {
}
}
-function tmpDir(): string {
+export function tmpDir(): string {
return path.join(process.env.PW_TMPDIR_FOR_TEST ?? os.tmpdir(), 'playwright-mcp-output');
}
diff --git a/tests/mcp/video.spec.ts b/tests/mcp/video.spec.ts
index b0f6807956..b413d3c502 100644
--- a/tests/mcp/video.spec.ts
+++ b/tests/mcp/video.spec.ts
@@ -41,6 +41,28 @@ for (const mode of ['isolated', 'persistent']) {
expect(file).toMatch(/page-.*\.webm/);
});
+ test(`should work with { saveVideo } (${mode})`, async ({ startClient, server }, testInfo) => {
+ const outputDir = testInfo.outputPath('output');
+
+ const { client } = await startClient({
+ config: {
+ browser: { isolated: mode === 'isolated' },
+ saveVideo: { width: 800, height: 600 },
+ outputDir,
+ }
+ });
+
+ await navigateToTestPage(client, server);
+ await expect(async () => {
+ await produceFrames(client);
+ await checkIntermediateVideoFileExists();
+ }).toPass();
+ await closeBrowser(client);
+
+ const [file] = await fs.promises.readdir(outputDir);
+ expect(file).toMatch(/page-.*\.webm/);
+ });
+
test(`should work with recordVideo (${mode})`, async ({ startClient, server }, testInfo) => {
const videosDir = testInfo.outputPath('videos');