Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore: revert #37194 since select options got hidden (#37248)

Pavel Feldman9181309fc213
diff --git a/packages/injected/src/ariaSnapshot.ts b/packages/injected/src/ariaSnapshot.ts
index 89d447299a..06f4f75807 100644
--- a/packages/injected/src/ariaSnapshot.ts
+++ b/packages/injected/src/ariaSnapshot.ts
@@ -54,7 +54,7 @@ export type AriaTreeOptions = {
};
type InternalOptions = {
- visibility: 'aria' | 'visible' | 'ariaAndVisible',
+ visibility: 'aria' | 'ariaOrVisible' | 'ariaAndVisible',
refs: 'all' | 'interactable' | 'none',
refPrefix?: string,
includeGenericRole?: boolean,
@@ -67,7 +67,7 @@ function toInternalOptions(options: AriaTreeOptions): InternalOptions {
if (options.mode === 'ai') {
// For AI consumption.
return {
- visibility: 'visible',
+ visibility: 'ariaOrVisible',
refs: 'interactable',
refPrefix: options.refPrefix,
includeGenericRole: true,
@@ -119,8 +119,8 @@ export function generateAriaTree(rootElement: Element, publicOptions: AriaTreeOp
const element = node as Element;
const isElementVisibleForAria = !roleUtils.isElementHiddenForAria(element);
let visible = isElementVisibleForAria;
- if (options.visibility === 'visible')
- visible = isElementVisible(element);
+ if (options.visibility === 'ariaOrVisible')
+ visible = isElementVisibleForAria || isElementVisible(element);
if (options.visibility === 'ariaAndVisible')
visible = isElementVisibleForAria && isElementVisible(element);
diff --git a/tests/page/page-aria-snapshot-ai.spec.ts b/tests/page/page-aria-snapshot-ai.spec.ts
index 39a716294d..816ac4a688 100644
--- a/tests/page/page-aria-snapshot-ai.spec.ts
+++ b/tests/page/page-aria-snapshot-ai.spec.ts
@@ -17,7 +17,7 @@
// @ts-ignore
import { asLocator } from 'playwright-core/lib/utils';
-import { test as it, expect } from './pageTest';
+import { test as it, expect, unshift } from './pageTest';
function snapshotForAI(page: any, options?: { timeout?: number }): Promise<string> {
return page._snapshotForAI(options);
@@ -184,9 +184,18 @@ it('emit generic roles for nodes w/o roles', async ({ page }) => {
expect(snapshot).toContainYaml(`
- generic [ref=e2]:
- - generic [ref=e3]: Apple
- - generic [ref=e5]: Pear
- - generic [ref=e7]: Orange
+ - generic [ref=e3]:
+ - generic [ref=e4]:
+ - radio "Apple" [checked]
+ - text: Apple
+ - generic [ref=e5]:
+ - generic [ref=e6]:
+ - radio "Pear"
+ - text: Pear
+ - generic [ref=e7]:
+ - generic [ref=e8]:
+ - radio "Orange"
+ - text: Orange
`);
});
@@ -289,11 +298,11 @@ it('should show visible children of hidden elements', { annotation: { type: 'iss
</div>
`);
- expect(await snapshotForAI(page)).toContainYaml(`
+ expect(await snapshotForAI(page)).toEqual(unshift(`
- generic [active] [ref=e1]:
- button "Visible" [ref=e3]
- button "Visible" [ref=e4]
- `);
+ `));
});
it('should include active element information', async ({ page }) => {