Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore(bidi): add support for network.setExtraHeaders (#38079)

Holger Benl9212916c60a9
diff --git a/packages/playwright-core/src/server/bidi/bidiBrowser.ts b/packages/playwright-core/src/server/bidi/bidiBrowser.ts
index 28cdd80a98..10f1eca889 100644
--- a/packages/playwright-core/src/server/bidi/bidiBrowser.ts
+++ b/packages/playwright-core/src/server/bidi/bidiBrowser.ts
@@ -222,6 +222,8 @@ export class BidiBrowserContext extends BrowserContext {
userContexts: [this._userContextId()],
}));
}
+ if (this._options.extraHTTPHeaders || this._options.locale)
+ promises.push(this.doUpdateExtraHTTPHeaders());
await Promise.all(promises);
}
@@ -320,6 +322,13 @@ export class BidiBrowserContext extends BrowserContext {
}
async doUpdateExtraHTTPHeaders(): Promise<void> {
+ let allHeaders = this._options.extraHTTPHeaders || [];
+ if (this._options.locale)
+ allHeaders = network.mergeHeaders([allHeaders, network.singleHeader('Accept-Language', this._options.locale)]);
+ await this._browser._browserSession.send('network.setExtraHeaders', {
+ headers: allHeaders.map(({ name, value }) => ({ name, value: { type: 'string', value } })),
+ userContexts: [this._userContextId()],
+ });
}
async setUserAgent(userAgent: string | undefined): Promise<void> {
diff --git a/packages/playwright-core/src/server/bidi/bidiPage.ts b/packages/playwright-core/src/server/bidi/bidiPage.ts
index 5e1e53c6b1..e5ece31858 100644
--- a/packages/playwright-core/src/server/bidi/bidiPage.ts
+++ b/packages/playwright-core/src/server/bidi/bidiPage.ts
@@ -26,6 +26,7 @@ import { BidiNetworkManager } from './bidiNetworkManager';
import { BidiPDF } from './bidiPdf';
import * as bidi from './third_party/bidiProtocol';
+import * as network from '../network';
import type { RegisteredListener } from '../utils/eventsHelper';
import type * as accessibility from '../accessibility';
import type * as frames from '../frames';
@@ -298,6 +299,16 @@ export class BidiPage implements PageDelegate {
}
async updateExtraHTTPHeaders(): Promise<void> {
+ const locale = this._browserContext._options.locale;
+ const allHeaders = network.mergeHeaders([
+ this._browserContext._options.extraHTTPHeaders,
+ this._page.extraHTTPHeaders(),
+ locale ? network.singleHeader('Accept-Language', locale) : undefined,
+ ]);
+ await this._session.send('network.setExtraHeaders', {
+ headers: allHeaders.map(({ name, value }) => ({ name, value: { type: 'string', value } })),
+ contexts: [this._session.sessionId],
+ });
}
async updateEmulateMedia(): Promise<void> {
diff --git a/packages/playwright-core/src/server/bidi/third_party/bidiCommands.d.ts b/packages/playwright-core/src/server/bidi/third_party/bidiCommands.d.ts
index 474876ed2c..32042091dc 100644
--- a/packages/playwright-core/src/server/bidi/third_party/bidiCommands.d.ts
+++ b/packages/playwright-core/src/server/bidi/third_party/bidiCommands.d.ts
@@ -178,6 +178,10 @@ export interface Commands {
returnType: Bidi.Storage.SetCookieParameters;
};
+ 'network.setExtraHeaders': {
+ params: Bidi.Network.SetExtraHeadersParameters;
+ returnType: Bidi.Network.SetExtraHeadersResult;
+ };
'network.addDataCollector': {
params: Bidi.Network.AddDataCollectorParameters;
returnType: Bidi.Network.AddDataCollectorResult;