Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
fix(mcp): add missing .catch() on sessionLog write queue (#41234)
Sebastien Tardif954a7680c9be
diff --git a/packages/playwright-core/src/tools/backend/sessionLog.ts b/packages/playwright-core/src/tools/backend/sessionLog.tsindex 48d04986e5..f7cb13957b 100644--- a/packages/playwright-core/src/tools/backend/sessionLog.ts+++ b/packages/playwright-core/src/tools/backend/sessionLog.ts@@ -17,6 +17,8 @@import fs from 'fs';import path from 'path';+import debug from 'debug';+import { outputFile } from './context';import { parseResponse } from './response';@@ -60,6 +62,6 @@ export class SessionLog {}lines.push('');- this._sessionFileQueue = this._sessionFileQueue.then(() => fs.promises.appendFile(this._file, lines.join('\n')));+ this._sessionFileQueue = this._sessionFileQueue.then(() => fs.promises.appendFile(this._file, lines.join('\n'))).catch(e => debug('pw:tools:error')(e));}}diff --git a/tests/mcp/session-log.spec.ts b/tests/mcp/session-log.spec.tsindex 8fac3c6296..f18815320e 100644--- a/tests/mcp/session-log.spec.ts+++ b/tests/mcp/session-log.spec.ts@@ -84,6 +84,53 @@ test('session log should record tool calls', async ({ startClient, server, mcpBr`.trim()));});+test('session log should recover after write failure', async ({ startClient, server, mcpBrowser }, testInfo) => {+ test.skip(mcpBrowser === 'webkit');++ const { client, stderr } = await startClient({+ args: [+ '--save-session',+ '--output-dir', testInfo.outputPath('output'),+ ],+ });++ server.setContent('/', `<title>Title</title><button>Submit</button>`, 'text/html');++ // First call: logs successfully.+ await client.callTool({+ name: 'browser_navigate',+ arguments: { url: server.PREFIX },+ });++ const output = stderr().split('\n').filter(line => line.startsWith('Session: '))[0];+ const sessionFolder = output.substring('Session: '.length);+ const sessionFile = path.join(sessionFolder, 'session.md');++ // Wait for the first entry to be written.+ await expect.poll(() => readSessionLog(sessionFolder)).toContain('browser_navigate');++ // Make the session file read-only so the next write fails.+ await fs.promises.chmod(sessionFile, 0o444);++ // Second call: write fails (EACCES) but the chain should recover.+ await client.callTool({+ name: 'browser_click',+ arguments: { element: 'Submit button', target: 'e2' },+ });++ // Restore write permission.+ await fs.promises.chmod(sessionFile, 0o644);++ // Third call: without the fix the chain stays rejected and this is never logged.+ await client.callTool({+ name: 'browser_click',+ arguments: { element: 'Submit button', target: 'e2' },+ });++ // Verify the third call was logged (chain recovered).+ await expect.poll(() => readSessionLog(sessionFolder)).toContain('browser_click');+});+async function readSessionLog(sessionFolder: string): Promise<string> {return await fs.promises.readFile(path.join(sessionFolder, 'session.md'), 'utf8').catch(() => '');}