Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
chore(chromium): reenable RenderDocument again (#41303)
Dmitry Gozman966ed43b57e2
diff --git a/docs/src/api/class-coverage.md b/docs/src/api/class-coverage.mdindex 8eae75e24d..8a5fb7af68 100644--- a/docs/src/api/class-coverage.md+++ b/docs/src/api/class-coverage.md@@ -54,9 +54,10 @@ will have `__playwright_evaluation_script__` as their URL.### option: Coverage.startJSCoverage.resetOnNavigation* since: v1.11+* discouraged: Settings this to `false` may still reset on navigations.- `resetOnNavigation` <[boolean]>-Whether to reset coverage on every navigation. Defaults to `true`.+Whether to reset coverage on every navigation. Defaults to `true`. Note that passing `false` does not guarantee that coverage persists through navigations, due to browser architecture limitations.### option: Coverage.startJSCoverage.reportAnonymousScripts* since: v1.11diff --git a/packages/playwright-client/types/types.d.ts b/packages/playwright-client/types/types.d.tsindex b215084259..0e37993306 100644--- a/packages/playwright-client/types/types.d.ts+++ b/packages/playwright-client/types/types.d.ts@@ -19024,7 +19024,10 @@ export interface Coverage {reportAnonymousScripts?: boolean;/**- * Whether to reset coverage on every navigation. Defaults to `true`.+ * **NOTE** Settings this to `false` may still reset on navigations.+ *+ * Whether to reset coverage on every navigation. Defaults to `true`. Note that passing `false` does not guarantee+ * that coverage persists through navigations, due to browser architecture limitations.*/resetOnNavigation?: boolean;}): Promise<void>;diff --git a/packages/playwright-core/src/server/chromium/chromiumSwitches.ts b/packages/playwright-core/src/server/chromium/chromiumSwitches.tsindex b63cadd1ff..aade807fc3 100644--- a/packages/playwright-core/src/server/chromium/chromiumSwitches.ts+++ b/packages/playwright-core/src/server/chromium/chromiumSwitches.ts@@ -40,8 +40,6 @@ const disabledFeatures = ['Translate',// See https://issues.chromium.org/u/1/issues/435410220'AutoDeElevate',- // See https://github.com/microsoft/playwright/issues/37714- 'RenderDocument',// Prevents downloading optimization hints on startup.'OptimizationHints',// Disables forced sign-in in Edge.diff --git a/packages/playwright-core/types/types.d.ts b/packages/playwright-core/types/types.d.tsindex b215084259..0e37993306 100644--- a/packages/playwright-core/types/types.d.ts+++ b/packages/playwright-core/types/types.d.ts@@ -19024,7 +19024,10 @@ export interface Coverage {reportAnonymousScripts?: boolean;/**- * Whether to reset coverage on every navigation. Defaults to `true`.+ * **NOTE** Settings this to `false` may still reset on navigations.+ *+ * Whether to reset coverage on every navigation. Defaults to `true`. Note that passing `false` does not guarantee+ * that coverage persists through navigations, due to browser architecture limitations.*/resetOnNavigation?: boolean;}): Promise<void>;diff --git a/tests/library/chromium/js-coverage.spec.ts b/tests/library/chromium/js-coverage.spec.tsindex 18f21b70fd..7acc69386f 100644--- a/tests/library/chromium/js-coverage.spec.ts+++ b/tests/library/chromium/js-coverage.spec.ts@@ -63,14 +63,6 @@ it('should report multiple scripts', async function({ page, server }) {expect(coverage[1].url).toContain('/jscoverage/script2.js');});-it('should report scripts across navigations when disabled', async function({ page, server }) {- await page.coverage.startJSCoverage({ resetOnNavigation: false });- await page.goto(server.PREFIX + '/jscoverage/multiple.html');- await page.goto(server.EMPTY_PAGE);- const coverage = await page.coverage.stopJSCoverage();- expect(coverage.length).toBe(2);-});-it('should NOT report scripts across navigations when enabled', async function({ page, server }) {await page.coverage.startJSCoverage(); // Enabled by default.await page.goto(server.PREFIX + '/jscoverage/multiple.html');