Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

test: enable some getSelection tests in WebKit (#35498)

Yury Semikhatsky96f8b170180a
diff --git a/tests/page/elementhandle-select-text.spec.ts b/tests/page/elementhandle-select-text.spec.ts
index b916feb3fc..20bb600e5b 100644
--- a/tests/page/elementhandle-select-text.spec.ts
+++ b/tests/page/elementhandle-select-text.spec.ts
@@ -22,7 +22,7 @@ it('should select textarea', async ({ page, server, browserName }) => {
const textarea = await page.$('textarea');
await textarea.evaluate(textarea => textarea.value = 'some value');
await textarea.selectText();
- if (browserName === 'firefox' || browserName === 'webkit') {
+ if (browserName === 'firefox') {
expect(await textarea.evaluate(el => el.selectionStart)).toBe(0);
expect(await textarea.evaluate(el => el.selectionEnd)).toBe(10);
} else {
@@ -35,7 +35,7 @@ it('should select input', async ({ page, server, browserName }) => {
const input = await page.$('input');
await input.evaluate(input => input.value = 'some value');
await input.selectText();
- if (browserName === 'firefox' || browserName === 'webkit') {
+ if (browserName === 'firefox') {
expect(await input.evaluate(el => el.selectionStart)).toBe(0);
expect(await input.evaluate(el => el.selectionEnd)).toBe(10);
} else {
diff --git a/tests/page/locator-misc-2.spec.ts b/tests/page/locator-misc-2.spec.ts
index f09749eca5..1252e968dc 100644
--- a/tests/page/locator-misc-2.spec.ts
+++ b/tests/page/locator-misc-2.spec.ts
@@ -78,7 +78,7 @@ it('should select textarea', async ({ page, server, browserName }) => {
const textarea = page.locator('textarea');
await textarea.evaluate(textarea => (textarea as HTMLTextAreaElement).value = 'some value');
await textarea.selectText();
- if (browserName === 'firefox' || browserName === 'webkit') {
+ if (browserName === 'firefox') {
expect(await textarea.evaluate(el => (el as HTMLTextAreaElement).selectionStart)).toBe(0);
expect(await textarea.evaluate(el => (el as HTMLTextAreaElement).selectionEnd)).toBe(10);
} else {
diff --git a/tests/page/retarget.spec.ts b/tests/page/retarget.spec.ts
index 6c09d3b907..1ae942df98 100644
--- a/tests/page/retarget.spec.ts
+++ b/tests/page/retarget.spec.ts
@@ -239,7 +239,7 @@ it('input value retargeting', async ({ page, browserName }) => {
await expect(target).toHaveValue('bar');
await target.selectText();
- if (browserName === 'firefox' || browserName === 'webkit') {
+ if (browserName === 'firefox') {
expect(await page.locator('#target').evaluate((el: HTMLInputElement) => el.selectionStart)).toBe(0);
expect(await page.locator('#target').evaluate((el: HTMLInputElement) => el.selectionEnd)).toBe(3);
} else {