Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
chore(cli): better default browser message (#39163)
Yury Semikhatsky9901ab97198b
diff --git a/packages/playwright/src/mcp/extension/cdpRelay.ts b/packages/playwright/src/mcp/extension/cdpRelay.tsindex 639ac1c35e..4b489bf890 100644--- a/packages/playwright/src/mcp/extension/cdpRelay.ts+++ b/packages/playwright/src/mcp/extension/cdpRelay.ts@@ -99,11 +99,11 @@ export class CDPRelayServer {return `${this._wsHost}${this._extensionPath}`;}- async ensureExtensionConnectionForMCPContext(clientInfo: ClientInfo, abortSignal: AbortSignal, toolName: string | undefined) {+ async ensureExtensionConnectionForMCPContext(clientInfo: ClientInfo, abortSignal: AbortSignal, forceNewTab: boolean) {debugLogger('Ensuring extension connection for MCP context');if (this._extensionConnection)return;- this._connectBrowser(clientInfo, toolName);+ this._connectBrowser(clientInfo, forceNewTab);debugLogger('Waiting for incoming extension connection');await Promise.race([this._extensionConnectionPromise,@@ -115,7 +115,7 @@ export class CDPRelayServer {debugLogger('Extension connection established');}- private _connectBrowser(clientInfo: ClientInfo, toolName: string | undefined) {+ private _connectBrowser(clientInfo: ClientInfo, forceNewTab: boolean) {const mcpRelayEndpoint = `${this._wsHost}${this._extensionPath}`;// Need to specify "key" in the manifest.json to make the id stable when loading from file.const url = new URL('chrome-extension://jakfalbnbhgkpmoaakfflhflbfpkailf/connect.html');@@ -126,8 +126,8 @@ export class CDPRelayServer {};url.searchParams.set('client', JSON.stringify(client));url.searchParams.set('protocolVersion', process.env.PWMCP_TEST_PROTOCOL_VERSION ?? protocol.VERSION.toString());- if (toolName)- url.searchParams.set('newTab', String(toolName === 'browser_navigate'));+ if (forceNewTab)+ url.searchParams.set('newTab', 'true');const token = process.env.PLAYWRIGHT_MCP_EXTENSION_TOKEN;if (token)url.searchParams.set('token', token);diff --git a/packages/playwright/src/mcp/extension/extensionContextFactory.ts b/packages/playwright/src/mcp/extension/extensionContextFactory.tsindex 6783d7b62c..1ff619c17e 100644--- a/packages/playwright/src/mcp/extension/extensionContextFactory.ts+++ b/packages/playwright/src/mcp/extension/extensionContextFactory.ts@@ -29,11 +29,13 @@ export class ExtensionContextFactory implements BrowserContextFactory {private _browserChannel: string;private _userDataDir?: string;private _executablePath?: string;+ private _forceNewTab: boolean;- constructor(browserChannel: string, userDataDir: string | undefined, executablePath: string | undefined) {+ constructor(browserChannel: string, userDataDir: string | undefined, executablePath: string | undefined, forceNewTab: boolean) {this._browserChannel = browserChannel;this._userDataDir = userDataDir;this._executablePath = executablePath;+ this._forceNewTab = forceNewTab;}async createContext(clientInfo: ClientInfo, abortSignal: AbortSignal, options: { toolName?: string }): Promise<{ browserContext: playwright.BrowserContext, close: () => Promise<void> }> {@@ -49,7 +51,8 @@ export class ExtensionContextFactory implements BrowserContextFactory {private async _obtainBrowser(clientInfo: ClientInfo, abortSignal: AbortSignal, toolName: string | undefined): Promise<playwright.Browser> {const relay = await this._startRelay(abortSignal);- await relay.ensureExtensionConnectionForMCPContext(clientInfo, abortSignal, toolName);+ const forceNewTab = this._forceNewTab || toolName === 'browser_navigate';+ await relay.ensureExtensionConnectionForMCPContext(clientInfo, abortSignal, forceNewTab);return await playwright.chromium.connectOverCDP(relay.cdpEndpoint(), { isLocal: true });}diff --git a/packages/playwright/src/mcp/program.ts b/packages/playwright/src/mcp/program.tsindex b91650fd7f..85b926ea1d 100644--- a/packages/playwright/src/mcp/program.ts+++ b/packages/playwright/src/mcp/program.ts@@ -106,7 +106,9 @@ export function decorateCommand(command: Command, version: string) {}const browserContextFactory = contextFactory(config);- const extensionContextFactory = new ExtensionContextFactory(config.browser.launchOptions.channel || 'chrome', config.browser.userDataDir, config.browser.launchOptions.executablePath);+ // Always force new tab in cli mode as the first command is always navigation.+ const forceNewTab = !!config.sessionConfig;+ const extensionContextFactory = new ExtensionContextFactory(config.browser.launchOptions.channel || 'chrome', config.browser.userDataDir, config.browser.launchOptions.executablePath, forceNewTab);if (config.sessionConfig) {const contextFactory = config.extension ? extensionContextFactory : browserContextFactory;diff --git a/packages/playwright/src/mcp/terminal/program.ts b/packages/playwright/src/mcp/terminal/program.tsindex f9ea03c16f..f4b0c01094 100644--- a/packages/playwright/src/mcp/terminal/program.ts+++ b/packages/playwright/src/mcp/terminal/program.ts@@ -632,7 +632,7 @@ async function findOrInstallDefaultBrowser() {const executable = registry.findExecutable(channel);if (!executable?.executablePath())continue;- console.log(`Found ${channel} browser.`);+ console.log(`Found ${channel}, will use it as the default browser.`);return channel;}const chromiumExecutable = registry.findExecutable('chromium');diff --git a/tests/mcp/cli-misc.spec.ts b/tests/mcp/cli-misc.spec.tsindex 745f1302c5..3e6cb7b8a6 100644--- a/tests/mcp/cli-misc.spec.ts+++ b/tests/mcp/cli-misc.spec.ts@@ -56,7 +56,7 @@ test('install workspace w/skills', async ({ cli }, testInfo) => {test('install handles browser detection', async ({ cli }) => {const { output } = await cli('install');// Verify that one of the browser detection outcomes occurred- const foundMatch = output.match(/Found ((?:chrome|msedge)[\w-]*) browser\./m);+ const foundMatch = output.match(/Found ((?:chrome|msedge)[\w-]*), will use it as the default browser\./m);if (foundMatch?.[1] !== 'chrome')expect(output).toContain(`Created default config for ${foundMatch?.[1] ?? 'chromium'}.`);});