Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore: only use locator description if it is the last token (#36178)

Pavel Feldman990fb68f73ad
diff --git a/packages/playwright-core/src/utils/isomorphic/locatorGenerators.ts b/packages/playwright-core/src/utils/isomorphic/locatorGenerators.ts
index b27eba6ebb..3c16e089a2 100644
--- a/packages/playwright-core/src/utils/isomorphic/locatorGenerators.ts
+++ b/packages/playwright-core/src/utils/isomorphic/locatorGenerators.ts
@@ -39,9 +39,9 @@ export interface LocatorFactory {
export function asLocatorDescription(lang: Language, selector: string): string | undefined {
const parsed = parseSelector(selector);
- const describe = parsed.parts.findLast(part => part.name === 'internal:describe');
- if (describe)
- return JSON.parse(describe.body as string);
+ const lastPart = parsed.parts[parsed.parts.length - 1];
+ if (lastPart?.name === 'internal:describe')
+ return JSON.parse(lastPart.body as string);
return asLocator(lang, selector);
}
diff --git a/tests/library/trace-viewer.spec.ts b/tests/library/trace-viewer.spec.ts
index 35ca0c5272..ff50a454a5 100644
--- a/tests/library/trace-viewer.spec.ts
+++ b/tests/library/trace-viewer.spec.ts
@@ -1900,10 +1900,12 @@ test('should not trip over complex urls in style tags', {
test('should render locator descriptions', async ({ runAndTrace, page }) => {
const traceViewer = await runAndTrace(async () => {
await page.setContent('<input type="text" />');
- await page.locator('input').describe('main input').click({ button: 'right' });
+ await page.locator('input').describe('custom').click();
+ await page.locator('input').describe('custom').first().click();
});
await expect(traceViewer.page.locator('body')).toMatchAriaSnapshot(`
- - treeitem /Click.*main input/
+ - treeitem /Click.*custom/
+ - treeitem /Click.*input.*first/
`);
});