Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore: delete request._headersMap (#38723)

Yury Semikhatsky9e3ce26d70ca
diff --git a/packages/playwright-core/src/server/network.ts b/packages/playwright-core/src/server/network.ts
index e004f4353f..644e3fea7c 100644
--- a/packages/playwright-core/src/server/network.ts
+++ b/packages/playwright-core/src/server/network.ts
@@ -124,7 +124,6 @@ export class Request extends SdkObject {
private _method: string;
private _postData: Buffer | null;
readonly _headers: HeadersArray;
- private _headersMap = new Map<string, string>();
readonly _frame: frames.Frame | null = null;
readonly _serviceWorker: pages.Worker | null = null;
readonly _context: contexts.BrowserContext;
@@ -155,7 +154,6 @@ export class Request extends SdkObject {
this._method = method;
this._postData = postData;
this._headers = headers;
- this._updateHeadersMap();
this._isFavicon = url.endsWith('/favicon.ico') || !!redirectedFrom?._isFavicon;
}
@@ -166,15 +164,9 @@ export class Request extends SdkObject {
_applyOverrides(overrides: types.NormalizedContinueOverrides) {
this._overrides = { ...this._overrides, ...overrides };
- this._updateHeadersMap();
return this._overrides;
}
- private _updateHeadersMap() {
- for (const { name, value } of this.headers())
- this._headersMap.set(name.toLowerCase(), value);
- }
-
overrides() {
return this._overrides;
}
@@ -200,7 +192,8 @@ export class Request extends SdkObject {
}
headerValue(name: string): string | undefined {
- return this._headersMap.get(name);
+ const lowerCaseName = name.toLowerCase();
+ return this.headers().find(h => h.name.toLowerCase() === lowerCaseName)?.value;
}
// "null" means no raw headers available - we'll use provisional headers as raw headers.