Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
test: fix/skip some tests (#39904)
Dmitry Gozman9ed295ae1458
diff --git a/packages/playwright-core/src/utils/isomorphic/trace/snapshotRenderer.ts b/packages/playwright-core/src/utils/isomorphic/trace/snapshotRenderer.tsindex 7279ce2b0f..0b0085a003 100644--- a/packages/playwright-core/src/utils/isomorphic/trace/snapshotRenderer.ts+++ b/packages/playwright-core/src/utils/isomorphic/trace/snapshotRenderer.ts@@ -257,7 +257,7 @@ declare global {}function snapshotScript(viewport: ViewportSize, ...targetIds: (string | undefined)[]) {- function applyPlaywrightAttributes(viewport: ViewportSize, ...targetIds: (string | undefined)[]) {+ function applyPlaywrightAttributes(blankSnapshotUrl: string, viewport: ViewportSize, ...targetIds: (string | undefined)[]) {// eslint-disable-next-line no-restricted-globalsconst win = window;const searchParams = new URLSearchParams(win.location.search);@@ -555,7 +555,7 @@ function snapshotScript(viewport: ViewportSize, ...targetIds: (string | undefinewin.addEventListener('DOMContentLoaded', onDOMContentLoaded);}- return `\n(${applyPlaywrightAttributes.toString()})(${JSON.stringify(viewport)}${targetIds.map(id => `, "${id}"`).join('')})`;+ return `\n(${applyPlaywrightAttributes.toString()})(${JSON.stringify(blankSnapshotUrl)},${JSON.stringify(viewport)}${targetIds.map(id => `, "${id}"`).join('')})`;}diff --git a/tests/library/trace-viewer.spec.ts b/tests/library/trace-viewer.spec.tsindex 9e6a773145..b4e1478132 100644--- a/tests/library/trace-viewer.spec.ts+++ b/tests/library/trace-viewer.spec.ts@@ -1221,7 +1221,7 @@ test('should display waitForLoadState even if did not wait for it', async ({ run});test('should display language-specific locators', async ({ runAndTrace, server, page, toImpl }) => {- toImpl(page).attribution.playwright.options.sdkLanguage = 'python';+ toImpl(page).attribution.browser.options.sdkLanguage = 'python';const traceViewer = await runAndTrace(async () => {await page.setContent('<button>Submit</button>');await page.getByRole('button', { name: 'Submit' }).click();@@ -1230,7 +1230,7 @@ test('should display language-specific locators', async ({ runAndTrace, server,/Set content/,/Click.*get_by_role\("button", name="Submit"\)/,]);- toImpl(page).attribution.playwright.options.sdkLanguage = 'javascript';+ toImpl(page).attribution.browser.options.sdkLanguage = 'javascript';});test('should pick locator', async ({ page, runAndTrace, server }) => {diff --git a/tests/page/page-drag.spec.ts b/tests/page/page-drag.spec.tsindex fb59ba6b95..a13edbcf12 100644--- a/tests/page/page-drag.spec.ts+++ b/tests/page/page-drag.spec.ts@@ -19,12 +19,10 @@ import { test as it, expect } from './pageTest';import { attachFrame } from '../config/utils';it.skip(({ browserName, browserMajorVersion }) => browserName === 'chromium' && browserMajorVersion < 91);-it.fixme(({ headless, isLinux }) => isLinux && !headless, 'Stray mouse events on Linux headed mess up the tests.');-it.fixme(({ headless, isWindows, browserName }) => isWindows && !headless && browserName === 'webkit', 'WebKit win also send stray mouse events.');+it.skip(({ isAndroid }) => isAndroid, 'No drag&drop on Android.');+it.fixme(({ headless }) => !headless, 'Stray mouse events mess up the tests.');it.describe('Drag and drop', () => {- it.skip(({ isAndroid }) => isAndroid, 'No drag&drop on Android.');-it('should work @smoke', async ({ page, server }) => {await page.goto(server.PREFIX + '/drag-n-drop.html');await page.hover('#source');diff --git a/tests/playwright-test/perf.spec.ts b/tests/playwright-test/perf.spec.tsindex d8cb05abdb..8ab36b9bbd 100644--- a/tests/playwright-test/perf.spec.ts+++ b/tests/playwright-test/perf.spec.ts@@ -26,7 +26,7 @@ test('should not load rare bundles during test run', async ({ runInlineTest }) =expect(result.exitCode).toBe(0);expect(result.passed).toBe(1);const output = result.output;- expect(output).toContain('utilsBundle');+ expect(output).toContain('babelBundle');expect(output).not.toContain('mcpBundle');expect(output).not.toContain('zodBundle');expect(output).not.toContain('zipBundle');