Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix(video): avoid MJPEG interlace inference (#41776)

Simon Knotta0dce0caef9f
diff --git a/packages/playwright-core/src/server/ebml.ts b/packages/playwright-core/src/server/ebml.ts
index ce84b2ec36..cf58b55007 100644
--- a/packages/playwright-core/src/server/ebml.ts
+++ b/packages/playwright-core/src/server/ebml.ts
@@ -90,7 +90,7 @@ function element(id: Buffer, payload: Buffer): Buffer {
// Emits the Matroska header: EBML head, an unknown-size (streaming) Segment, stream Info with a
// 1ms timestamp scale, and a single MJPEG video track. Frames follow as Clusters via writeClusterHeader.
-export function writeHeader(width: number, height: number): Buffer {
+export function writeHeader(): Buffer {
const ebml = element(kEBML, Buffer.concat([
element(kEBMLVersion, uint(1)),
element(kEBMLReadVersion, uint(1)),
@@ -112,11 +112,12 @@ export function writeHeader(width: number, height: number): Buffer {
element(kTrackType, uint(1)), // 1 = video.
element(kFlagLacing, uint(0)),
element(kCodecID, Buffer.from('V_MJPEG')),
- // PixelWidth/PixelHeight are advisory: ffmpeg's mjpeg decoder uses the dimensions encoded in
- // each JPEG frame, and the output video filters normalize to the requested size.
+ // PixelWidth/PixelHeight are mandatory, but the actual JPEG dimensions are not known yet.
+ // A larger placeholder can make ffmpeg mistake a short progressive JPEG for an interlaced
+ // field, so use 1x1 and let the MJPEG decoder read the real dimensions from each frame.
element(kVideo, Buffer.concat([
- element(kPixelWidth, uint(width)),
- element(kPixelHeight, uint(height)),
+ element(kPixelWidth, uint(1)),
+ element(kPixelHeight, uint(1)),
])),
]));
const tracks = element(kTracks, track);
diff --git a/packages/playwright-core/src/server/videoRecorder.ts b/packages/playwright-core/src/server/videoRecorder.ts
index 292d6d84be..65f47b30fe 100644
--- a/packages/playwright-core/src/server/videoRecorder.ts
+++ b/packages/playwright-core/src/server/videoRecorder.ts
@@ -189,7 +189,7 @@ class FfmpegVideoRecorder {
});
this._process = launchedProcess;
this._gracefullyClose = gracefullyClose;
- launchedProcess.stdin!.write(writeHeader(w, h));
+ launchedProcess.stdin!.write(writeHeader());
}
writeFrame(frame: Buffer, timestamp: number) {
diff --git a/tests/library/video.spec.ts b/tests/library/video.spec.ts
index 3c1cff83e4..df431af1e8 100644
--- a/tests/library/video.spec.ts
+++ b/tests/library/video.spec.ts
@@ -130,6 +130,25 @@ it.describe('screencast', () => {
expectRedFrames(videoFile, size);
});
+ it('should pad a short frame to the video size', async ({ browser }, testInfo) => {
+ const videoSize = { width: 800, height: 600 };
+ const context = await browser.newContext({
+ recordVideo: {
+ dir: testInfo.outputPath(''),
+ size: videoSize,
+ },
+ viewport: { width: 800, height: 396 },
+ });
+ const page = await context.newPage();
+ await ensureSomeFrames(page);
+ await context.close();
+
+ const videoFile = await page.video().path();
+ const videoPlayer = new VideoPlayer(videoFile);
+ expect(videoPlayer.videoWidth).toBe(videoSize.width);
+ expect(videoPlayer.videoHeight).toBe(videoSize.height);
+ });
+
it('should continue recording main page after popup closes', async ({ browser, browserName }, testInfo) => {
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/30837' });
// Firefox does not have a mobile variant and has a large minimum size (500 on windows and 450 elsewhere).