Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
chore(extension): typecheck extension as part of lint (#43072)
Dmitry Gozmana3c5084d38c6
diff --git a/package.json b/package.jsonindex e58362f614..6f08b95f53 100644--- a/package.json+++ b/package.json@@ -33,7 +33,7 @@"ctest-mcp": "playwright test --config=tests/mcp/playwright.config.ts --project=chrome","test-extension": "playwright test --config=tests/extension/playwright.config.ts","eslint": "eslint --cache",- "tsc": "tsc -p .",+ "tsc": "tsc -p . && tsc -p packages/extension/tsconfig.json && tsc -p packages/extension/tsconfig.ui.json","doc": "node utils/doclint/cli.js","lint": "npm run eslint && npm run tsc && npm run doc && npm run check-deps && node utils/generate_channels.js && node utils/generate_types/ && npm run lint-tests && npm run test-types && npm run lint-packages","lint-packages": "node utils/workspace.js --ensure-consistent",diff --git a/packages/extension/src/connectedTabGroup.ts b/packages/extension/src/connectedTabGroup.tsindex 023e084e33..91ceabe44b 100644--- a/packages/extension/src/connectedTabGroup.ts+++ b/packages/extension/src/connectedTabGroup.ts@@ -76,7 +76,7 @@ export class ConnectedTabGroup {private _isTabReserved: (tabId: number) => boolean;private _groupId: number | null = null;private _groupTabIds: Set<number> = new Set();- private _onTabUpdatedListener: (tabId: number, changeInfo: chrome.tabs.TabChangeInfo, tab: chrome.tabs.Tab) => void;+ private _onTabUpdatedListener: (tabId: number, changeInfo: chrome.tabs.OnUpdatedInfo, tab: chrome.tabs.Tab) => void;private _onTabRemovedListener: (tabId: number) => void;onclose?: () => void;@@ -116,7 +116,7 @@ export class ConnectedTabGroup {this._connection.detachTab(tabId);}- private _onTabUpdated(tabId: number, changeInfo: chrome.tabs.TabChangeInfo, tab: chrome.tabs.Tab): void {+ private _onTabUpdated(tabId: number, changeInfo: chrome.tabs.OnUpdatedInfo, tab: chrome.tabs.Tab): void {if (changeInfo.groupId !== undefined)this._onTabGroupChanged(tabId, tab);if (changeInfo.url === undefined)@@ -217,8 +217,10 @@ export class ConnectedTabGroup {}export async function ungroupTabs(tabIds: number[]): Promise<void> {+ if (!tabIds.length)+ return;try {- await retryOnDrag(() => chrome.tabs.ungroup(tabIds));+ await retryOnDrag(() => chrome.tabs.ungroup(tabIds as [number, ...number[]]));} catch (error: any) {debugLog('Error ungrouping tabs:', error);}