Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore: update React to 19 (#37467)

Max Schmitta62740581e51
diff --git a/package-lock.json b/package-lock.json
index 28ac6268a6..0396d7fc63 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -24,8 +24,8 @@
"@types/codemirror": "^5.60.7",
"@types/formidable": "^2.0.4",
"@types/node": "18.19.76",
- "@types/react": "^18.0.12",
- "@types/react-dom": "^18.0.5",
+ "@types/react": "^19.1.13",
+ "@types/react-dom": "^19.1.9",
"@types/ws": "^8.5.3",
"@types/xml2js": "^0.4.9",
"@typescript-eslint/eslint-plugin": "^8.41.0",
@@ -53,8 +53,8 @@
"license-checker": "^25.0.1",
"mime": "^3.0.0",
"node-stream-zip": "^1.15.0",
- "react": "^18.1.0",
- "react-dom": "^18.1.0",
+ "react": "^19.1.1",
+ "react-dom": "^19.1.1",
"ssim.js": "^3.5.0",
"typescript": "^5.9.2",
"vite": "^6.3.6",
@@ -1810,29 +1810,24 @@
"undici-types": "~5.26.4"
}
},
- "node_modules/@types/prop-types": {
- "version": "15.7.15",
- "resolved": "https://registry.npmjs.org/@types/prop-types/-/prop-types-15.7.15.tgz",
- "integrity": "sha512-F6bEyamV9jKGAFBEmlQnesRPGOQqS2+Uwi0Em15xenOxHaf2hv6L8YCVn3rPdPJOiJfPiCnLIRyvwVaqMY3MIw==",
- "dev": true
- },
"node_modules/@types/react": {
- "version": "18.3.24",
- "resolved": "https://registry.npmjs.org/@types/react/-/react-18.3.24.tgz",
- "integrity": "sha512-0dLEBsA1kI3OezMBF8nSsb7Nk19ZnsyE1LLhB8r27KbgU5H4pvuqZLdtE+aUkJVoXgTVuA+iLIwmZ0TuK4tx6A==",
+ "version": "19.1.13",
+ "resolved": "https://registry.npmjs.org/@types/react/-/react-19.1.13.tgz",
+ "integrity": "sha512-hHkbU/eoO3EG5/MZkuFSKmYqPbSVk5byPFa3e7y/8TybHiLMACgI8seVYlicwk7H5K/rI2px9xrQp/C+AUDTiQ==",
"dev": true,
+ "license": "MIT",
"dependencies": {
- "@types/prop-types": "*",
"csstype": "^3.0.2"
}
},
"node_modules/@types/react-dom": {
- "version": "18.3.7",
- "resolved": "https://registry.npmjs.org/@types/react-dom/-/react-dom-18.3.7.tgz",
- "integrity": "sha512-MEe3UeoENYVFXzoXEWsvcpg6ZvlrFNlOQ7EOsvhI3CfAXwzPfO8Qwuxd40nepsYKqyyVQnTdEfv68q91yLcKrQ==",
+ "version": "19.1.9",
+ "resolved": "https://registry.npmjs.org/@types/react-dom/-/react-dom-19.1.9.tgz",
+ "integrity": "sha512-qXRuZaOsAdXKFyOhRBg6Lqqc0yay13vN7KrIg4L7N4aaHN68ma9OK3NE1BoDFgFOTfM7zg+3/8+2n8rLUH3OKQ==",
"dev": true,
+ "license": "MIT",
"peerDependencies": {
- "@types/react": "^18.0.0"
+ "@types/react": "^19.0.0"
}
},
"node_modules/@types/responselike": {
@@ -6439,28 +6434,26 @@
}
},
"node_modules/react": {
- "version": "18.3.1",
- "resolved": "https://registry.npmjs.org/react/-/react-18.3.1.tgz",
- "integrity": "sha512-wS+hAgJShR0KhEvPJArfuPVN1+Hz1t0Y6n5jLrGQbkb4urgPE/0Rve+1kMB1v/oWgHgm4WIcV+i7F2pTVj+2iQ==",
+ "version": "19.1.1",
+ "resolved": "https://registry.npmjs.org/react/-/react-19.1.1.tgz",
+ "integrity": "sha512-w8nqGImo45dmMIfljjMwOGtbmC/mk4CMYhWIicdSflH91J9TyCyczcPFXJzrZ/ZXcgGRFeP6BU0BEJTw6tZdfQ==",
"dev": true,
- "dependencies": {
- "loose-envify": "^1.1.0"
- },
+ "license": "MIT",
"engines": {
"node": ">=0.10.0"
}
},
"node_modules/react-dom": {
- "version": "18.3.1",
- "resolved": "https://registry.npmjs.org/react-dom/-/react-dom-18.3.1.tgz",
- "integrity": "sha512-5m4nQKp+rZRb09LNH59GM4BxTh9251/ylbKIbpe7TpGxfJ+9kv6BLkLBXIjjspbgbnIBNqlI23tRnTWT0snUIw==",
+ "version": "19.1.1",
+ "resolved": "https://registry.npmjs.org/react-dom/-/react-dom-19.1.1.tgz",
+ "integrity": "sha512-Dlq/5LAZgF0Gaz6yiqZCf6VCcZs1ghAJyrsu84Q/GT0gV+mCxbfmKNoGRKBYMJ8IEdGPqu49YWXD02GCknEDkw==",
"dev": true,
+ "license": "MIT",
"dependencies": {
- "loose-envify": "^1.1.0",
- "scheduler": "^0.23.2"
+ "scheduler": "^0.26.0"
},
"peerDependencies": {
- "react": "^18.3.1"
+ "react": "^19.1.1"
}
},
"node_modules/react-is": {
@@ -6865,13 +6858,11 @@
"dev": true
},
"node_modules/scheduler": {
- "version": "0.23.2",
- "resolved": "https://registry.npmjs.org/scheduler/-/scheduler-0.23.2.tgz",
- "integrity": "sha512-UOShsPwz7NrMUqhR6t0hWjFduvOzbtv7toDH1/hIrfRNIDBnnBWd0CwJTGvTpngVlmwGCdP9/Zl/tVrDqcuYzQ==",
+ "version": "0.26.0",
+ "resolved": "https://registry.npmjs.org/scheduler/-/scheduler-0.26.0.tgz",
+ "integrity": "sha512-NlHwttCI/l5gCPR3D1nNXtWABUmBwvZpEQiD4IXSbIDq8BzLIK/7Ir5gTFSGZDUu37K5cMNp0hFtzO38sC7gWA==",
"dev": true,
- "dependencies": {
- "loose-envify": "^1.1.0"
- }
+ "license": "MIT"
},
"node_modules/semver": {
"version": "7.7.2",
diff --git a/package.json b/package.json
index ec56915d80..2973982979 100644
--- a/package.json
+++ b/package.json
@@ -65,8 +65,8 @@
"@types/codemirror": "^5.60.7",
"@types/formidable": "^2.0.4",
"@types/node": "18.19.76",
- "@types/react": "^18.0.12",
- "@types/react-dom": "^18.0.5",
+ "@types/react": "^19.1.13",
+ "@types/react-dom": "^19.1.9",
"@types/ws": "^8.5.3",
"@types/xml2js": "^0.4.9",
"@typescript-eslint/eslint-plugin": "^8.41.0",
@@ -94,8 +94,8 @@
"license-checker": "^25.0.1",
"mime": "^3.0.0",
"node-stream-zip": "^1.15.0",
- "react": "^18.1.0",
- "react-dom": "^18.1.0",
+ "react": "^19.1.1",
+ "react-dom": "^19.1.1",
"ssim.js": "^3.5.0",
"typescript": "^5.9.2",
"vite": "^6.3.6",
diff --git a/packages/html-reporter/src/chip.tsx b/packages/html-reporter/src/chip.tsx
index cdd07777a6..456c8157ed 100644
--- a/packages/html-reporter/src/chip.tsx
+++ b/packages/html-reporter/src/chip.tsx
@@ -23,7 +23,7 @@ import { clsx } from '@web/uiUtils';
import { type AnchorID, useAnchor } from './links';
export const Chip: React.FC<{
- header: JSX.Element | string,
+ header: React.JSX.Element | string,
expanded?: boolean,
noInsets?: boolean,
setExpanded?: (expanded: boolean) => void,
@@ -48,7 +48,7 @@ export const Chip: React.FC<{
};
export const AutoChip: React.FC<{
- header: JSX.Element | string,
+ header: React.JSX.Element | string,
initialExpanded?: boolean,
noInsets?: boolean,
children?: any,
diff --git a/packages/html-reporter/src/statusIcon.tsx b/packages/html-reporter/src/statusIcon.tsx
index 39837955ae..778321276f 100644
--- a/packages/html-reporter/src/statusIcon.tsx
+++ b/packages/html-reporter/src/statusIcon.tsx
@@ -18,7 +18,7 @@ import * as icons from './icons';
import './colors.css';
import './common.css';
-export function statusIcon(status: 'failed' | 'timedOut' | 'skipped' | 'passed' | 'expected' | 'unexpected' | 'flaky' | 'interrupted'): JSX.Element {
+export function statusIcon(status: 'failed' | 'timedOut' | 'skipped' | 'passed' | 'expected' | 'unexpected' | 'flaky' | 'interrupted'): React.JSX.Element {
switch (status) {
case 'failed':
case 'unexpected':
diff --git a/packages/html-reporter/src/tabbedPane.tsx b/packages/html-reporter/src/tabbedPane.tsx
index 25d1f72169..a1e533348b 100644
--- a/packages/html-reporter/src/tabbedPane.tsx
+++ b/packages/html-reporter/src/tabbedPane.tsx
@@ -21,7 +21,7 @@ import * as React from 'react';
export interface TabbedPaneTab {
id: string;
- title: string | JSX.Element;
+ title: string | React.JSX.Element;
count?: number;
render: () => React.ReactElement;
}
diff --git a/packages/html-reporter/src/testFileView.tsx b/packages/html-reporter/src/testFileView.tsx
index fa88fbb65b..34e349b1e9 100644
--- a/packages/html-reporter/src/testFileView.tsx
+++ b/packages/html-reporter/src/testFileView.tsx
@@ -71,7 +71,7 @@ export const TestFileView: React.FC<React.PropsWithChildren<{
</Chip>;
};
-function imageDiffBadge(test: TestCaseSummary): JSX.Element | undefined {
+function imageDiffBadge(test: TestCaseSummary): React.JSX.Element | undefined {
for (const result of test.results) {
for (const attachment of result.attachments) {
if (attachment.contentType.startsWith('image/') && !!attachment.name.match(/-(expected|actual|diff)/))
@@ -80,7 +80,7 @@ function imageDiffBadge(test: TestCaseSummary): JSX.Element | undefined {
}
}
-function videoBadge(test: TestCaseSummary): JSX.Element | undefined {
+function videoBadge(test: TestCaseSummary): React.JSX.Element | undefined {
const resultWithVideo = test.results.find(result => result.attachments.some(attachment => attachment.name === 'video'));
return resultWithVideo ? <LinkBadge href={testResultHref({ test, result: resultWithVideo, anchor: 'attachment-video' })} title='View video' dim={true}>{video()}</LinkBadge> : undefined;
}
diff --git a/packages/html-reporter/src/treeItem.tsx b/packages/html-reporter/src/treeItem.tsx
index 546510afc3..389e558650 100644
--- a/packages/html-reporter/src/treeItem.tsx
+++ b/packages/html-reporter/src/treeItem.tsx
@@ -20,8 +20,8 @@ import * as icons from './icons';
import { clsx } from '@web/uiUtils';
export const TreeItem: React.FunctionComponent<{
- title: JSX.Element,
- loadChildren?: () => JSX.Element[],
+ title: React.JSX.Element,
+ loadChildren?: () => React.JSX.Element[],
onClick?: () => void,
expandByDefault?: boolean,
depth: number,
diff --git a/packages/trace-viewer/src/ui/consoleTab.tsx b/packages/trace-viewer/src/ui/consoleTab.tsx
index d8e9ec51e0..28550cb15b 100644
--- a/packages/trace-viewer/src/ui/consoleTab.tsx
+++ b/packages/trace-viewer/src/ui/consoleTab.tsx
@@ -26,7 +26,7 @@ import { PlaceholderPanel } from './placeholderPanel';
export type ConsoleEntry = {
browserMessage?: {
- body: JSX.Element[];
+ body: React.JSX.Element[];
bodyString: string;
location: string;
},
@@ -150,9 +150,9 @@ export const ConsoleTab: React.FunctionComponent<{
const errorSuffix = entry.isError ? 'status-error' : entry.isWarning ? 'status-warning' : 'status-none';
const statusElement = entry.browserMessage || entry.browserError ? <span className={clsx('codicon', 'codicon-browser', errorSuffix)} title='Browser message'></span> : <span className={clsx('codicon', 'codicon-file', errorSuffix)} title='Runner message'></span>;
let locationText: string | undefined;
- let messageBody: JSX.Element[] | string | undefined;
+ let messageBody: React.JSX.Element[] | string | undefined;
let messageInnerHTML: string | undefined;
- let messageStack: JSX.Element[] | string | undefined;
+ let messageStack: React.JSX.Element[] | string | undefined;
const { browserMessage, browserError, nodeMessage } = entry;
if (browserMessage) {
@@ -187,7 +187,7 @@ export const ConsoleTab: React.FunctionComponent<{
</div>;
};
-function format(args: { preview: string, value: any }[]): JSX.Element[] {
+function format(args: { preview: string, value: any }[]): React.JSX.Element[] {
if (args.length === 1)
return formatAnsi(args[0].preview);
@@ -198,8 +198,8 @@ function format(args: { preview: string, value: any }[]): JSX.Element[] {
const regex = /%([%sdifoOc])/g;
let match;
- const formatted: JSX.Element[] = [];
- let tokens: JSX.Element[] = [];
+ const formatted: React.JSX.Element[] = [];
+ let tokens: React.JSX.Element[] = [];
formatted.push(<span key={formatted.length + 1}>{tokens}</span>);
let formatIndex = 0;
while ((match = regex.exec(messageFormat)) !== null) {
@@ -236,7 +236,7 @@ function format(args: { preview: string, value: any }[]): JSX.Element[] {
return formatted;
}
-function formatAnsi(text: string): JSX.Element[] {
+function formatAnsi(text: string): React.JSX.Element[] {
// eslint-disable-next-line react/jsx-key
return [<span dangerouslySetInnerHTML={{ __html: ansi2html(text.trim()) }}></span>];
}
diff --git a/packages/trace-viewer/src/ui/filmStrip.tsx b/packages/trace-viewer/src/ui/filmStrip.tsx
index dd8a0cb0ac..19ed90505d 100644
--- a/packages/trace-viewer/src/ui/filmStrip.tsx
+++ b/packages/trace-viewer/src/ui/filmStrip.tsx
@@ -106,7 +106,7 @@ const FilmStripLane: React.FunctionComponent<{
const frameCount = (effectiveWidth / (frameSize.width + 2 * frameMargin)) | 0;
const frameDuration = (endTime - startTime) / frameCount;
- const frames: JSX.Element[] = [];
+ const frames: React.JSX.Element[] = [];
for (let i = 0; startTime && frameDuration && i < frameCount; ++i) {
const time = startTime + frameDuration * i;
const index = upperBound(screencastFrames, time, timeComparator) - 1;
diff --git a/packages/trace-viewer/src/ui/workbench.tsx b/packages/trace-viewer/src/ui/workbench.tsx
index 2581b672cb..0989e87deb 100644
--- a/packages/trace-viewer/src/ui/workbench.tsx
+++ b/packages/trace-viewer/src/ui/workbench.tsx
@@ -325,7 +325,7 @@ export const Workbench: React.FunctionComponent<{
component: <MetadataView model={model}/>
};
- return <div className='vbox workbench' {...(inert ? { inert: 'true' } : {})}>
+ return <div className='vbox workbench' {...(inert ? { inert: true } : {})}>
{!hideTimeline && <Timeline
model={model}
consoleEntries={consoleModel.entries}
diff --git a/packages/trace-viewer/src/ui/workbenchLoader.tsx b/packages/trace-viewer/src/ui/workbenchLoader.tsx
index 06ae35afa5..519b7fea78 100644
--- a/packages/trace-viewer/src/ui/workbenchLoader.tsx
+++ b/packages/trace-viewer/src/ui/workbenchLoader.tsx
@@ -186,7 +186,7 @@ export const WorkbenchLoader: React.FunctionComponent<{
const showFileUploadDropArea = !!(!isServer && !dragOver && !fileForLocalModeError && (!traceURLs.length || processingErrorMessage));
return <div className='vbox workbench-loader' onDragOver={event => { event.preventDefault(); setDragOver(true); }}>
- <div className='hbox header' {...(showFileUploadDropArea ? { inert: 'true' } : {})}>
+ <div className='hbox header' {...(showFileUploadDropArea ? { inert: true } : {})}>
<div className='logo'>
<img src='playwright-logo.svg' alt='Playwright logo' />
</div>
diff --git a/packages/web/src/components/dialog.tsx b/packages/web/src/components/dialog.tsx
index 4e2972e4f6..df40bde3fb 100644
--- a/packages/web/src/components/dialog.tsx
+++ b/packages/web/src/components/dialog.tsx
@@ -25,7 +25,7 @@ export interface DialogProps {
width?: number;
verticalOffset?: number;
requestClose?: () => void;
- anchor?: React.RefObject<HTMLElement>;
+ anchor?: React.RefObject<HTMLElement|null>;
dataTestId?: string;
}
diff --git a/packages/web/src/components/expandable.tsx b/packages/web/src/components/expandable.tsx
index a837bd0a0c..c0ac3ed841 100644
--- a/packages/web/src/components/expandable.tsx
+++ b/packages/web/src/components/expandable.tsx
@@ -19,7 +19,7 @@ import './expandable.css';
import { clsx } from '../uiUtils';
export const Expandable: React.FunctionComponent<React.PropsWithChildren<{
- title: JSX.Element | string,
+ title: React.JSX.Element | string,
setExpanded: (expanded: boolean) => void,
expanded: boolean,
expandOnTitleClick?: boolean,
diff --git a/tests/playwright-test/playwright.ct-build.spec.ts b/tests/playwright-test/playwright.ct-build.spec.ts
index 58451f7015..ecf9d6d1fa 100644
--- a/tests/playwright-test/playwright.ct-build.spec.ts
+++ b/tests/playwright-test/playwright.ct-build.spec.ts
@@ -41,7 +41,7 @@ test('should work with the empty component list', async ({ runInlineTest }, test
expect(metainfo.version).toEqual(require('playwright-core/package.json').version);
expect(metainfo.viteVersion).toEqual(require('vite/package.json').version);
expect(Object.entries(metainfo.deps)).toHaveLength(0);
- expect(Object.entries(metainfo.sources)).toHaveLength(9);
+ expect(Object.entries(metainfo.sources)).toHaveLength(10);
});
test('should extract component list', async ({ runInlineTest }, testInfo) => {