Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
chore: page.close -> `Close page` in steps (#36834)
Max Schmitta65efcbdf312
diff --git a/packages/playwright-core/src/utils/isomorphic/protocolMetainfo.ts b/packages/playwright-core/src/utils/isomorphic/protocolMetainfo.tsindex 33bc1e0b4a..ce1be44af8 100644--- a/packages/playwright-core/src/utils/isomorphic/protocolMetainfo.ts+++ b/packages/playwright-core/src/utils/isomorphic/protocolMetainfo.ts@@ -98,7 +98,7 @@ export const methodMetainfo = new Map<string, { internal?: boolean, title?: stri['BrowserContext.clockSetFixedTime', { title: 'Set fixed time "{timeNumber}{timeString}"', }],['BrowserContext.clockSetSystemTime', { title: 'Set system time "{timeNumber}{timeString}"', }],['Page.addInitScript', { }],- ['Page.close', { title: 'Close', }],+ ['Page.close', { title: 'Close page', }],['Page.emulateMedia', { title: 'Emulate media', snapshot: true, }],['Page.exposeBinding', { title: 'Expose binding', }],['Page.goBack', { title: 'Go back', slowMo: true, snapshot: true, }],diff --git a/packages/protocol/src/protocol.yml b/packages/protocol/src/protocol.ymlindex bbfdfcebe3..4a5b2910fb 100644--- a/packages/protocol/src/protocol.yml+++ b/packages/protocol/src/protocol.yml@@ -1554,7 +1554,7 @@ Page:source: stringclose:- title: Close+ title: Close pageparameters:runBeforeUnload: boolean?reason: string?diff --git a/tests/library/tracing.spec.ts b/tests/library/tracing.spec.tsindex ba06509c04..6a81df0c62 100644--- a/tests/library/tracing.spec.ts+++ b/tests/library/tracing.spec.ts@@ -52,7 +52,7 @@ test('should collect trace with resources, but no js', async ({ context, page, s'Navigate to "/input/fileupload.html"','Set input files','Wait for timeout',- 'Close',+ 'Close page',]);expect(events.some(e => e.type === 'frame-snapshot')).toBeTruthy();@@ -200,7 +200,7 @@ test('should collect two traces', async ({ context, page, server }, testInfo) =>expect(events[0].type).toBe('context-options');expect(actions).toEqual(['Double click',- 'Close',+ 'Close page',]);}});