Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

test: remove special handling for getSelection() with Firefox from tests (#35271)

Henrik Skupina7df837809d4
diff --git a/tests/page/elementhandle-select-text.spec.ts b/tests/page/elementhandle-select-text.spec.ts
index 20bb600e5b..502657ba7b 100644
--- a/tests/page/elementhandle-select-text.spec.ts
+++ b/tests/page/elementhandle-select-text.spec.ts
@@ -22,12 +22,7 @@ it('should select textarea', async ({ page, server, browserName }) => {
const textarea = await page.$('textarea');
await textarea.evaluate(textarea => textarea.value = 'some value');
await textarea.selectText();
- if (browserName === 'firefox') {
- expect(await textarea.evaluate(el => el.selectionStart)).toBe(0);
- expect(await textarea.evaluate(el => el.selectionEnd)).toBe(10);
- } else {
- expect(await page.evaluate(() => window.getSelection().toString())).toBe('some value');
- }
+ expect(await page.evaluate(() => window.getSelection().toString())).toBe('some value');
});
it('should select input', async ({ page, server, browserName }) => {
@@ -35,12 +30,7 @@ it('should select input', async ({ page, server, browserName }) => {
const input = await page.$('input');
await input.evaluate(input => input.value = 'some value');
await input.selectText();
- if (browserName === 'firefox') {
- expect(await input.evaluate(el => el.selectionStart)).toBe(0);
- expect(await input.evaluate(el => el.selectionEnd)).toBe(10);
- } else {
- expect(await page.evaluate(() => window.getSelection().toString())).toBe('some value');
- }
+ expect(await page.evaluate(() => window.getSelection().toString())).toBe('some value');
});
it('should select plain div', async ({ page, server }) => {
diff --git a/tests/page/locator-misc-2.spec.ts b/tests/page/locator-misc-2.spec.ts
index 1252e968dc..45d1c79da5 100644
--- a/tests/page/locator-misc-2.spec.ts
+++ b/tests/page/locator-misc-2.spec.ts
@@ -78,12 +78,7 @@ it('should select textarea', async ({ page, server, browserName }) => {
const textarea = page.locator('textarea');
await textarea.evaluate(textarea => (textarea as HTMLTextAreaElement).value = 'some value');
await textarea.selectText();
- if (browserName === 'firefox') {
- expect(await textarea.evaluate(el => (el as HTMLTextAreaElement).selectionStart)).toBe(0);
- expect(await textarea.evaluate(el => (el as HTMLTextAreaElement).selectionEnd)).toBe(10);
- } else {
- expect(await page.evaluate(() => window.getSelection().toString())).toBe('some value');
- }
+ expect(await page.evaluate(() => window.getSelection().toString())).toBe('some value');
});
it('should type', async ({ page }) => {
diff --git a/tests/page/retarget.spec.ts b/tests/page/retarget.spec.ts
index 1ae942df98..741758c5f7 100644
--- a/tests/page/retarget.spec.ts
+++ b/tests/page/retarget.spec.ts
@@ -239,12 +239,7 @@ it('input value retargeting', async ({ page, browserName }) => {
await expect(target).toHaveValue('bar');
await target.selectText();
- if (browserName === 'firefox') {
- expect(await page.locator('#target').evaluate((el: HTMLInputElement) => el.selectionStart)).toBe(0);
- expect(await page.locator('#target').evaluate((el: HTMLInputElement) => el.selectionEnd)).toBe(3);
- } else {
- expect(await page.evaluate(() => window.getSelection()!.toString())).toBe('bar');
- }
+ expect(await page.evaluate(() => window.getSelection()!.toString())).toBe('bar');
});
}
});
@@ -270,14 +265,7 @@ it('selection retargeting', async ({ page, browserName }) => {
await expect(page.locator('#target')).toHaveText('foo');
await target.selectText();
- if (browserName === 'firefox') {
- expect(await page.$eval('#target', target => {
- const selection = window.getSelection()!;
- return selection.anchorNode === target && selection.focusNode === target;
- })).toBe(true);
- } else {
- expect(await page.evaluate(() => window.getSelection()!.toString())).toBe('foo');
- }
+ expect(await page.evaluate(() => window.getSelection()!.toString())).toBe('foo');
});
}
});