Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

test: unflake/skip some tests (#41817)

Dmitry Gozmana98ab942d0f5
diff --git a/tests/library/browsercontext-basic.spec.ts b/tests/library/browsercontext-basic.spec.ts
index 8f498c6a1b..2d5debad68 100644
--- a/tests/library/browsercontext-basic.spec.ts
+++ b/tests/library/browsercontext-basic.spec.ts
@@ -376,9 +376,9 @@ it('should emulate offline event', { annotation: { type: 'issue', description: '
return events;
});
await context.setOffline(true);
- expect(await events.jsonValue()).toEqual(['offline']);
+ await expect.poll(() => events.jsonValue()).toEqual(['offline']);
await context.setOffline(false);
- expect(await events.jsonValue()).toEqual(['offline', 'online']);
+ await expect.poll(() => events.jsonValue()).toEqual(['offline', 'online']);
await context.close();
});
diff --git a/tests/page/page-cache-storage.spec.ts b/tests/page/page-cache-storage.spec.ts
index 4087533895..b8ff90f91c 100644
--- a/tests/page/page-cache-storage.spec.ts
+++ b/tests/page/page-cache-storage.spec.ts
@@ -18,8 +18,10 @@ import { test, expect } from './pageTest';
test('CacheStorage entry should survive page.reload()', {
annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/41618' }
-}, async ({ page, server, browserName }) => {
+}, async ({ page, server, browserName, isAndroid }) => {
test.fail(browserName === 'webkit', 'Ephemeral CacheStorage is not persisted across reload in WebKit, consistent with Safari');
+ test.skip(isAndroid, 'not supported on Android');
+
await page.goto(server.EMPTY_PAGE);
await page.evaluate(async () => {
const cache = await caches.open('repro-cache');
diff --git a/tests/page/workers.spec.ts b/tests/page/workers.spec.ts
index 80dd681461..03362021da 100644
--- a/tests/page/workers.spec.ts
+++ b/tests/page/workers.spec.ts
@@ -382,7 +382,9 @@ it('should resolve worker script allHeaders in main frame', {
it('should resolve worker script allHeaders in iframe', {
annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/39948' },
-}, async function({ page, server, browserName }) {
+}, async function({ page, server, browserName, browserMajorVersion }) {
+ it.skip(browserName === 'chromium' && browserMajorVersion < 151, 'needs proper Network.requestWillBeSentExtraInfo');
+
const [request] = await Promise.all([
page.waitForEvent('requestfinished', request => request.url() === server.PREFIX + '/worker/worker.js'),
attachFrame(page, 'frame1', server.PREFIX + '/worker/worker.html'),
@@ -400,12 +402,13 @@ it('should resolve worker script allHeaders in nested worker inside iframe', {
it.fixme(browserName === 'webkit', 'cannot evaluate in nested worker');
it.fixme(browserName === 'firefox', 'nested worker script request is not reported at all');
+ const url = server.PREFIX + '/worker/worker.js';
const [worker] = await Promise.all([
page.waitForEvent('worker'),
+ page.waitForEvent('requestfinished', request => request.url() === url),
attachFrame(page, 'frame1', server.PREFIX + '/worker/worker.html'),
]);
- const url = server.PREFIX + '/worker/worker.js';
const [request] = await Promise.all([
page.waitForEvent('requestfinished', request => request.url() === url),
worker.evaluate(url => {