Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
fix(tracing): do not hang on unresponsive page when capturing snapshots (#42919)
Yury Semikhatskyaec64327edb6
diff --git a/packages/playwright-core/src/server/trace/recorder/tracing.ts b/packages/playwright-core/src/server/trace/recorder/tracing.tsindex 67b163b1fe..ed938f231e 100644--- a/packages/playwright-core/src/server/trace/recorder/tracing.ts+++ b/packages/playwright-core/src/server/trace/recorder/tracing.ts@@ -515,7 +515,10 @@ export class Tracing extends SdkObject implements InstrumentationListener, Snapsif (this._snapshotter?.started()) {// Node references are only reset by the first snapshot of the action.const resetTargets = phase === 'before';- await this._snapshotter?.captureSnapshot(page, progress.metadata.id, phase, resetTargets).catch(() => {});+ try {+ await progress.race(this._snapshotter.captureSnapshot(page, progress.metadata.id, phase, resetTargets));+ } catch {+ }}const options = this._state?.options;diff --git a/packages/trace-viewer/src/ui/workbench.tsx b/packages/trace-viewer/src/ui/workbench.tsxindex 12c47c5590..685ab431fc 100644--- a/packages/trace-viewer/src/ui/workbench.tsx+++ b/packages/trace-viewer/src/ui/workbench.tsx@@ -168,6 +168,7 @@ const PartitionedWorkbench: React.FunctionComponent<WorkbenchProps & { partition}, [model]);const playback = usePlayback(actions || [], selectedAction, onActionSelected, selectedTime, boundaries);+ const { showSelectedAction } = playback;const selectPropertiesTab = React.useCallback((tab: string) => {setSelectedPropertiesTab(tab);@@ -180,9 +181,9 @@ const PartitionedWorkbench: React.FunctionComponent<WorkbenchProps & { partitionselectPropertiesTab('inspector');// Inspecting works against the DOM snapshot, not the screencast frame.if (value)- playback.showSelectedAction();+ showSelectedAction();setIsInspectingState(value);- }, [setIsInspectingState, selectPropertiesTab, isInspecting, playback.showSelectedAction]);+ }, [setIsInspectingState, selectPropertiesTab, isInspecting, showSelectedAction]);const elementPicked = React.useCallback((element: HighlightedElement) => {setHighlightedElement(element);diff --git a/tests/library/tracing.spec.ts b/tests/library/tracing.spec.tsindex 184bb34c0d..970aa5436d 100644--- a/tests/library/tracing.spec.ts+++ b/tests/library/tracing.spec.ts@@ -468,6 +468,23 @@ test('should not crash when browser closes mid-trace', async ({ browserType, serawait new Promise(f => setTimeout(f, 1000)); // Give it some time to throw errors});+test('should not hang when page is unresponsive', async ({ browserType, server }) => {+ test.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/42903' });+ const browser = await browserType.launch();+ const page = await browser.newPage();+ await page.context().tracing.start({ snapshots: true });+ await page.goto(server.EMPTY_PAGE);+ await page.evaluate(() => {+ setTimeout(() => {+ while (true) {}+ }, 0);+ });+ // All bets are off with a tight loop in the page, but an explicit timeout should still fire.+ const error = await page.goto(server.EMPTY_PAGE, { timeout: 1000 }).catch(e => e);+ expect(error.message).toContain('Timeout 1000ms exceeded');+ await browser.close();+});+test('should survive browser.close with auto-created traces dir', async ({ browserType }, testInfo) => {const oldTracesDir = (browserType as any)._playwright._defaultTracesDir;(browserType as any)._playwright._defaultTracesDir = undefined;diff --git a/utils/eslint-plugin-progress/index.js b/utils/eslint-plugin-progress/index.jsindex 394ade81b9..7a256116b7 100644--- a/utils/eslint-plugin-progress/index.js+++ b/utils/eslint-plugin-progress/index.js@@ -16,6 +16,8 @@// @ts-check+const crypto = require('crypto');+const fs = require('fs');const { ESLintUtils } = require('@typescript-eslint/utils');const createRule = ESLintUtils.RuleCreator(name => name);@@ -156,7 +158,9 @@ const rule = createRule({if (!isInProgressFunction())return;- const awaited = node.argument;+ let awaited = node.argument;+ if (awaited.type === 'ChainExpression')+ awaited = awaited.expression;// await progress.anything(...) is always fine — calls on the progress object itself.if (awaited.type === 'CallExpression' &&@@ -195,6 +199,11 @@ const rule = createRule({});module.exports = {+ meta: {+ name: 'eslint-plugin-progress',+ // ESLint cache key includes plugin version, so edits to this file invalidate cached results.+ version: crypto.createHash('sha1').update(fs.readFileSync(__filename)).digest('hex'),+ },rules: {'await-must-use-progress': rule,},