Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix(cli): report run-code route handler exception once and verbatim (#43203)

Pavel Feldmanafde449ba75a
diff --git a/packages/playwright-core/src/tools/backend/browserBackend.ts b/packages/playwright-core/src/tools/backend/browserBackend.ts
index 2c21b83caf..4c6739abaa 100644
--- a/packages/playwright-core/src/tools/backend/browserBackend.ts
+++ b/packages/playwright-core/src/tools/backend/browserBackend.ts
@@ -129,7 +129,7 @@ export class BrowserBackend extends EventEmitter<{ disconnected: [], dynamictool
responseObject = await response.serialize();
this._sessionLog?.logResponse(name, parsedArguments, responseObject);
} catch (error: any) {
- const messages = [String(error), ...context.drainPendingUnhandledRejections().map(formatRejectionReason)];
+ const messages = [String(error), ...context.drainPendingUnhandledRejections().filter(reason => reason !== error).map(formatRejectionReason)];
responseObject = formatError(messages.join('\n\n'));
} finally {
context.setRunningTool(undefined);
diff --git a/packages/playwright-core/src/tools/backend/runCode.ts b/packages/playwright-core/src/tools/backend/runCode.ts
index cfe8d84b7c..80c038a766 100644
--- a/packages/playwright-core/src/tools/backend/runCode.ts
+++ b/packages/playwright-core/src/tools/backend/runCode.ts
@@ -67,7 +67,7 @@ const runCode = defineTabTool({
// surfacing on the response.
const unsubscribe = tab.context.onUnhandledRejection(reason => {
if (!__end__.isDone())
- __end__.reject(reason instanceof Error ? reason : new Error(String(reason)));
+ __end__.reject(reason as Error);
});
try {
await tab.waitForCompletion(async () => {
diff --git a/tests/mcp/cli-run-code.spec.ts b/tests/mcp/cli-run-code.spec.ts
index 7bb97ce92c..3852936632 100644
--- a/tests/mcp/cli-run-code.spec.ts
+++ b/tests/mcp/cli-run-code.spec.ts
@@ -71,3 +71,19 @@ test('run-code delayed route with setTimeout', async ({ cli, server }) => {
const { output } = await cli('eval', 'async () => { const r = await fetch("/api/slow"); return r.text(); }');
expect(output).toContain('loaded');
});
+
+test('run-code reports route handler exception', async ({ cli, server }) => {
+ server.setContent('/', '<div>Hello</div>', 'text/html');
+ await cli('open', server.PREFIX);
+ const { output } = await cli('run-code', `async page => {
+ await page.route('**/route-throws', async route => {
+ throw new Error('route handler failed');
+ });
+ await page.goto('${server.PREFIX}/route-throws', { timeout: 5000 });
+ }`);
+ expect(output).toBe('### Error\nError: route handler failed');
+
+ server.setContent('/next', '<title>Next</title>', 'text/html');
+ const { output: gotoOutput } = await cli('goto', server.PREFIX + '/next');
+ expect(gotoOutput).toContain('Page Title: Next');
+});