Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

test: unflake some ui-mode tests (#38907)

Dmitry Gozmanb1fd5d0c5bfc
diff --git a/packages/trace-viewer/src/ui/workbench.tsx b/packages/trace-viewer/src/ui/workbench.tsx
index edee018ff3..9858690c2f 100644
--- a/packages/trace-viewer/src/ui/workbench.tsx
+++ b/packages/trace-viewer/src/ui/workbench.tsx
@@ -315,7 +315,7 @@ const PartitionedWorkbench: React.FunctionComponent<WorkbenchProps & { partition
id: 'actions',
title: 'Actions',
component: <div className='vbox'>
- {status && <div className='workbench-run-status'>
+ {status && <div className='workbench-run-status' data-testid='workbench-run-status'>
<span className={clsx('codicon', testStatusIcon(status))}></span>
<div>{testStatusText(status)}</div>
<div className='spacer'></div>
diff --git a/tests/playwright-test/ui-mode-test-network-tab.spec.ts b/tests/playwright-test/ui-mode-test-network-tab.spec.ts
index 3e04112f95..15d87ae64a 100644
--- a/tests/playwright-test/ui-mode-test-network-tab.spec.ts
+++ b/tests/playwright-test/ui-mode-test-network-tab.spec.ts
@@ -30,6 +30,8 @@ test('should filter network requests by resource type', async ({ runUITest, serv
});
await page.getByText('network tab test').dblclick();
+ await expect(page.getByTestId('workbench-run-status')).toContainText('Passed');
+
await page.getByText('Network', { exact: true }).click();
const networkItems = page.getByRole('list', { name: 'Network requests' }).getByRole('listitem');
@@ -73,6 +75,8 @@ test('should filter network requests by multiple resource types', async ({ runUI
});
await page.getByText('network tab test').dblclick();
+ await expect(page.getByTestId('workbench-run-status')).toContainText('Passed');
+
await page.getByText('Network', { exact: true }).click();
const networkItems = page.getByRole('list', { name: 'Network requests' }).getByRole('listitem');
@@ -112,6 +116,8 @@ test('should filter network requests by url', async ({ runUITest, server }) => {
});
await page.getByText('network tab test').dblclick();
+ await expect(page.getByTestId('workbench-run-status')).toContainText('Passed');
+
await page.getByText('Network', { exact: true }).click();
const networkItems = page.getByRole('list', { name: 'Network requests' }).getByRole('listitem');
@@ -149,6 +155,8 @@ test('should format JSON request body', async ({ runUITest, server }) => {
});
await page.getByText('network tab test').dblclick();
+ await expect(page.getByTestId('workbench-run-status')).toContainText('Passed');
+
await page.getByText('Network', { exact: true }).click();
await page.getByText('post-data-1').click();
@@ -193,6 +201,8 @@ test('should display list of query parameters (only if present)', async ({ runUI
});
await page.getByText('network tab test').dblclick();
+ await expect(page.getByTestId('workbench-run-status')).toContainText('Passed');
+
await page.getByText('Network', { exact: true }).click();
await page.getByText('call-with-query-params').click();
@@ -245,6 +255,8 @@ test('should not duplicate network entries from beforeAll', {
});
await page.getByText('first test').dblclick();
+ await expect(page.getByTestId('workbench-run-status')).toContainText('Passed');
+
await page.getByText('Network', { exact: true }).click();
await expect(page.getByRole('list', { name: 'Network requests' }).getByText('empty.html')).toHaveCount(1);
});
@@ -261,6 +273,8 @@ test('should toggle sections inside network details', async ({ runUITest, server
});
await page.getByRole('treeitem', { name: 'network tab test' }).dblclick();
+ await expect(page.getByTestId('workbench-run-status')).toContainText('Passed');
+
await page.getByRole('tab', { name: 'Network' }).click();
await page.getByRole('listitem').filter({ hasText: 'post-data-1' }).click();
const headersPanel = page.getByRole('tabpanel', { name: 'Headers' });
@@ -303,6 +317,8 @@ test('should copy network request', async ({ runUITest, server }) => {
});
await page.getByRole('treeitem', { name: 'network tab test' }).dblclick();
+ await expect(page.getByTestId('workbench-run-status')).toContainText('Passed');
+
await page.getByRole('tab', { name: 'Network' }).click();
await page.getByRole('listitem').filter({ hasText: 'post-data-1' }).click();
await page.getByRole('button', { name: 'Copy request' }).hover();
@@ -362,6 +378,8 @@ test('should not preserve selection across test runs', async ({ runUITest, serve
});
await page.getByRole('treeitem', { name: 'network tab test' }).dblclick();
+ await expect(page.getByTestId('workbench-run-status')).toContainText('Passed');
+
await page.getByRole('tab', { name: 'Network' }).click();
const networkItem = page.getByRole('listitem').filter({ hasText: 'network.html' });
await networkItem.click();
@@ -369,7 +387,5 @@ test('should not preserve selection across test runs', async ({ runUITest, serve
await expect(headersPanel).toBeVisible();
await page.getByRole('treeitem', { name: 'network tab test' }).dblclick();
- await networkItem.waitFor({ state: 'hidden' });
- await networkItem.waitFor();
await expect(headersPanel).toBeHidden();
});
diff --git a/tests/playwright-test/ui-mode-test-output.spec.ts b/tests/playwright-test/ui-mode-test-output.spec.ts
index 90b697dddd..c3426f8f46 100644
--- a/tests/playwright-test/ui-mode-test-output.spec.ts
+++ b/tests/playwright-test/ui-mode-test-output.spec.ts
@@ -119,12 +119,13 @@ test('should collapse repeated console messages for test', async ({ runUITest })
const { page } = await runUITest({
'a.spec.ts': `
import { test, expect } from '@playwright/test';
- test('print', async ({ page }) => {
+ test('print test', async ({ page }) => {
await page.evaluate(() => {
console.log('page message')
for (let i = 0; i < 10; ++i)
console.log('page message')
});
+ await page.waitForTimeout(3000);
for (let i = 0; i < 10; ++i)
console.log('node message')
await page.evaluate(async () => {
@@ -141,10 +142,10 @@ test('should collapse repeated console messages for test', async ({ runUITest })
});
`,
});
- await page.getByTitle('Run all').click();
- await page.getByRole('tab', { name: 'Console' }).click();
- await page.getByText('print').click();
+ await page.getByRole('treeitem', { name: 'print test' }).dblclick();
+ await expect(page.getByTestId('workbench-run-status')).toContainText('Passed');
+ await page.getByRole('tab', { name: 'Console' }).click();
await expect(page.getByRole('tabpanel', { name: 'Console' })).toMatchAriaSnapshot(`
- tabpanel "Console":
- list:
diff --git a/tests/playwright-test/ui-mode-trace.spec.ts b/tests/playwright-test/ui-mode-trace.spec.ts
index 59bbede8d4..7fdeec6b4d 100644
--- a/tests/playwright-test/ui-mode-trace.spec.ts
+++ b/tests/playwright-test/ui-mode-trace.spec.ts
@@ -140,6 +140,8 @@ test('should locate sync assertions in source', async ({ runUITest }) => {
});
await page.getByText('trace test').dblclick();
+ await expect(page.getByTestId('workbench-run-status')).toContainText('Passed');
+
await page.getByText('Expect "toBe"').click();
await expect(
@@ -253,6 +255,8 @@ test('should show image diff', async ({ runUITest }) => {
});
await page.getByText('vrt test').dblclick();
+ await expect(page.getByTestId('workbench-run-status')).toContainText('Failed');
+
await page.getByText(/Attachments/).click();
await expect(page.getByText('Diff', { exact: true })).toBeVisible();
await expect(page.getByText('Actual', { exact: true })).toBeVisible();
@@ -369,6 +373,8 @@ test('should show errors with causes in the error tab', async ({ runUITest }) =>
});
await page.getByText('pass').dblclick();
+ await expect(page.getByTestId('workbench-run-status')).toContainText('Failed');
+
await page.getByText('Errors', { exact: true }).click();
await expect(page.locator('.tab-errors')).toContainText(`Error: wrapper-message
[cause]: Error: outer-message
@@ -416,6 +422,8 @@ test('should show request source context id', async ({ runUITest, server }) => {
});
await page.getByText('pass').dblclick();
+ await expect(page.getByTestId('workbench-run-status')).toContainText('Passed');
+
await page.getByText('Network', { exact: true }).click();
await expect(page.locator('span').filter({ hasText: 'Source' })).toBeVisible();
await expect(page.getByText('page#1')).toBeVisible();
@@ -607,6 +615,8 @@ test('attachments tab shows all but top-level .push attachments', async ({ runUI
});
await page.getByRole('treeitem', { name: 'attachment test' }).dblclick();
+ await expect(page.getByTestId('workbench-run-status')).toContainText('Passed');
+
const actionsTree = page.getByTestId('actions-tree');
await actionsTree.getByRole('treeitem', { name: 'step' }).click();
await page.keyboard.press('ArrowRight');
@@ -641,6 +651,8 @@ test('skipped steps should have an indicator', async ({ runUITest }) => {
});
await page.getByRole('treeitem', { name: 'test with steps' }).dblclick();
+ await expect(page.getByTestId('workbench-run-status')).toContainText('Passed');
+
const actionsTree = page.getByTestId('actions-tree');
await actionsTree.getByRole('treeitem', { name: 'outer' }).click();
await page.keyboard.press('ArrowRight');
@@ -668,6 +680,7 @@ test('fails', async ({ page }) => {
});
await page.getByText('fails').dblclick();
+ await expect(page.getByTestId('workbench-run-status')).toContainText('Failed');
await page.context().grantPermissions(['clipboard-read', 'clipboard-write']);
await page.getByText('Errors', { exact: true }).click();
@@ -685,13 +698,14 @@ test('fails', async ({ page }) => {
`.trim());
});
-test('should indicate current test status', async ({ runUITest }) => {
+test('should indicate current test status', async ({ runUITest, createLatch }) => {
+ const latch = createLatch();
const { page } = await runUITest({
'a.spec.ts': `
import { test, expect } from '@playwright/test';
test('basic pass', async ({ page }) => {
await page.setContent('<button>Submit</button>');
- await new Promise(resolve => setTimeout(resolve, 1000));
+ ${latch.blockingCode}
expect(1).toBe(1);
});
test('basic fail', async ({ page }) => {
@@ -702,11 +716,12 @@ test('basic fail', async ({ page }) => {
});
await page.getByTestId('test-tree').getByText('basic pass').dblclick();
- await expect(page.getByRole('tabpanel', { name: 'Actions' })).toContainText('Running');
- await expect(page.getByRole('tabpanel', { name: 'Actions' })).toContainText('Passed');
+ await expect(page.getByTestId('workbench-run-status')).toContainText('Running');
+ latch.open();
+ await expect(page.getByTestId('workbench-run-status')).toContainText('Passed');
await page.getByTestId('test-tree').getByText('basic fail').dblclick();
- await expect(page.getByRole('tabpanel', { name: 'Actions' })).toContainText('Failed');
+ await expect(page.getByTestId('workbench-run-status')).toContainText('Failed');
});
test('should be able to create and dispose APIRequestContext inside Promise.all', async ({ runUITest }) => {
@@ -728,6 +743,7 @@ test('should be able to create and dispose APIRequestContext inside Promise.all'
});
await page.getByText('create api request contexts').dblclick();
+ await expect(page.getByTestId('workbench-run-status')).toContainText('Passed');
await expect(page.getByTestId('status-line')).toHaveText('1/1 passed (100%)');
@@ -762,6 +778,7 @@ test('should partition action tree state by test', async ({ runUITest }) => {
await page.getByTitle('Run all').click();
await page.getByTestId('test-tree').getByText('test1').click();
+ await expect(page.getByTestId('workbench-run-status')).toContainText('Passed');
const actionsTree = page.getByTestId('actions-tree');
await actionsTree.getByRole('treeitem', { name: 'After Hooks' }).click();