Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
fix(chromium): close file descriptor on protocol stream save error (#40749)
Sebastien Tardifb3c9a9b851a4
diff --git a/packages/playwright-core/src/server/chromium/crProtocolHelper.ts b/packages/playwright-core/src/server/chromium/crProtocolHelper.tsindex cd45d5d13e..deb0158f5f 100644--- a/packages/playwright-core/src/server/chromium/crProtocolHelper.ts+++ b/packages/playwright-core/src/server/chromium/crProtocolHelper.ts@@ -47,13 +47,16 @@ export async function saveProtocolStream(client: CRSession, handle: string, pathlet eof = false;await mkdirIfNeeded(path);const fd = await fs.promises.open(path, 'w');- while (!eof) {- const response = await client.send('IO.read', { handle });- eof = response.eof;- const buf = Buffer.from(response.data, response.base64Encoded ? 'base64' : undefined);- await fd.write(buf);+ try {+ while (!eof) {+ const response = await client.send('IO.read', { handle });+ eof = response.eof;+ const buf = Buffer.from(response.data, response.base64Encoded ? 'base64' : undefined);+ await fd.write(buf);+ }+ } finally {+ await fd.close().catch(() => {});}- await fd.close();await client.send('IO.close', { handle });}