Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
chore(bidi): pass acceptInsecureCerts to createUserContext (#36052)
Yury Semikhatskyb496dc46213d
diff --git a/packages/playwright-core/src/server/bidi/bidiBrowser.ts b/packages/playwright-core/src/server/bidi/bidiBrowser.tsindex 90a433402f..cfed26be3d 100644--- a/packages/playwright-core/src/server/bidi/bidiBrowser.ts+++ b/packages/playwright-core/src/server/bidi/bidiBrowser.ts@@ -124,7 +124,9 @@ export class BidiBrowser extends Browser {}async doCreateNewContext(options: types.BrowserContextOptions): Promise<BrowserContext> {- const { userContext } = await this._browserSession.send('browser.createUserContext', {});+ const { userContext } = await this._browserSession.send('browser.createUserContext', {+ acceptInsecureCerts: options.ignoreHTTPSErrors,+ });const context = new BidiBrowserContext(this, userContext, options);await context._initialize();this._contexts.set(userContext, context);diff --git a/packages/playwright-core/src/server/bidi/third_party/bidiProtocolCore.ts b/packages/playwright-core/src/server/bidi/third_party/bidiProtocolCore.tsindex ca0a96c83e..81e9e8b713 100644--- a/packages/playwright-core/src/server/bidi/third_party/bidiProtocolCore.ts+++ b/packages/playwright-core/src/server/bidi/third_party/bidiProtocolCore.ts@@ -327,7 +327,13 @@ export namespace Browser {export namespace Browser {export type CreateUserContext = {method: 'browser.createUserContext';- params: EmptyParams;+ params: Browser.CreateUserContextParameters;+ };+}+export namespace Browser {+ export type CreateUserContextParameters = {+ acceptInsecureCerts?: boolean;+ proxy?: Session.ProxyConfiguration;};}export namespace Browser {@@ -941,8 +947,14 @@ export namespace Emulation {};}export namespace Emulation {- export type SetGeolocationOverrideParameters = {- coordinates: Emulation.GeolocationCoordinates | null;+ export type SetGeolocationOverrideParameters = (+ | {+ coordinates: Emulation.GeolocationCoordinates | null;+ }+ | {+ error: Emulation.GeolocationPositionError;+ }+ ) & {contexts?: [BrowsingContext.BrowsingContext,...BrowsingContext.BrowsingContext[],@@ -990,6 +1002,11 @@ export namespace Emulation {speed?: number | null;};}+export namespace Emulation {+ export type GeolocationPositionError = {+ type: 'positionUnavailable';+ };+}export type NetworkCommand =| Network.AddIntercept| Network.ContinueRequest@@ -1699,16 +1716,16 @@ export namespace Script {};}export namespace Script {- export type RegExpRemoteValue = {+ export type RegExpRemoteValue = Script.RegExpLocalValue & {handle?: Script.Handle;internalId?: Script.InternalId;- } & Script.RegExpLocalValue;+ };}export namespace Script {- export type DateRemoteValue = {+ export type DateRemoteValue = Script.DateLocalValue & {handle?: Script.Handle;internalId?: Script.InternalId;- } & Script.DateLocalValue;+ };}export namespace Script {export type MapRemoteValue = {