Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix(html-reporter): use a button element for the chip header (#42149)

Denis Skvortsovb4a646a624c0
diff --git a/packages/html-reporter/src/chip.css b/packages/html-reporter/src/chip.css
index 88137cdbcd..f37aff953b 100644
--- a/packages/html-reporter/src/chip.css
+++ b/packages/html-reporter/src/chip.css
@@ -15,6 +15,8 @@
*/
.chip-header {
+ display: block;
+ width: 100%;
border: 1px solid var(--color-border-default);
border-top-left-radius: 6px;
border-top-right-radius: 6px;
@@ -22,14 +24,22 @@
padding: 0 8px;
border-bottom: none;
margin-top: 12px;
+ color: inherit;
+ font: inherit;
font-weight: 600;
line-height: 38px;
+ text-align: left;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
user-select: none;
}
+.chip-header:focus-visible {
+ outline: 1px solid var(--color-accent-fg);
+ outline-offset: -1px;
+}
+
.chip-header-allow-selection {
user-select: text;
}
diff --git a/packages/html-reporter/src/chip.spec.ts b/packages/html-reporter/src/chip.spec.ts
index 291654cefa..69d6444dbf 100644
--- a/packages/html-reporter/src/chip.spec.ts
+++ b/packages/html-reporter/src/chip.spec.ts
@@ -16,7 +16,7 @@
import { expect, test } from '@playwright/test';
-import type { Auto, AutoCollapsed, Stateful, WithBody } from './chip.story';
+import type { Auto, AutoCollapsed, NotExpandable, Stateful, WithBody } from './chip.story';
test.use({ viewport: { width: 500, height: 500 } });
@@ -50,6 +50,23 @@ test('body render prop is rendered', async ({ mount }) => {
await expect(component.getByText('Chip children')).toBeVisible();
});
+test('chip without setExpanded is not a button', async ({ mount }) => {
+ const component = await mount<typeof NotExpandable>('chip/NotExpandable');
+ await expect(component.getByRole('button')).toHaveCount(0);
+ await expect(component.getByText('Body')).toBeVisible();
+});
+
+test('expand collapse with the keyboard', async ({ mount, page }) => {
+ const component = await mount<typeof AutoCollapsed>('chip/AutoCollapsed');
+ const header = component.getByRole('button', { name: 'Title' });
+ await header.focus();
+ await expect(header).toBeFocused();
+ await page.keyboard.press('Enter');
+ await expect(component.getByText('Body')).toBeVisible();
+ await page.keyboard.press('Space');
+ await expect(component.getByText('Body')).not.toBeVisible();
+});
+
test('setExpanded should work', async ({ mount }) => {
const component = await mount<typeof AutoCollapsed>('chip/AutoCollapsed');
await component.getByText('Title').click();
diff --git a/packages/html-reporter/src/chip.story.tsx b/packages/html-reporter/src/chip.story.tsx
index 5945cfdb45..48fd0b0c93 100644
--- a/packages/html-reporter/src/chip.story.tsx
+++ b/packages/html-reporter/src/chip.story.tsx
@@ -33,3 +33,6 @@ export const Stateful = () => {
export const WithBody = () =>
<AutoChip header='Title' body={() => 'Body from render prop'}>Chip children</AutoChip>;
+
+export const NotExpandable = () =>
+ <Chip header='Title'>Body</Chip>;
diff --git a/packages/html-reporter/src/chip.tsx b/packages/html-reporter/src/chip.tsx
index f0dce3e48f..1a6926e36c 100644
--- a/packages/html-reporter/src/chip.tsx
+++ b/packages/html-reporter/src/chip.tsx
@@ -33,17 +33,23 @@ export const Chip: React.FC<{
dataTestId?: string,
}> = ({ header, footer, expanded, setExpanded, children, noInsets, body, dataTestId }) => {
const id = React.useId();
+ const title = typeof header === 'string' ? header : undefined;
+ const headerContent = <>
+ {setExpanded ? (expanded ? <icons.downArrow /> : <icons.rightArrow />) : <icons.spacer />}
+ {header}
+ </>;
return <div className='chip' data-testid={dataTestId}>
- <div
- role='button'
+ {setExpanded ? <button
+ type='button'
aria-expanded={!!expanded}
aria-controls={id}
- className={clsx('chip-header', setExpanded && ' expanded-' + expanded)}
- onClick={() => setExpanded?.(!expanded)}
- title={typeof header === 'string' ? header : undefined}>
- {setExpanded ? (expanded ? <icons.downArrow /> : <icons.rightArrow />) : <icons.spacer />}
- {header}
- </div>
+ className={clsx('chip-header', 'expanded-' + expanded)}
+ onClick={() => setExpanded(!expanded)}
+ title={title}>
+ {headerContent}
+ </button> : <div className='chip-header' title={title}>
+ {headerContent}
+ </div>}
{(!setExpanded || expanded) && <div id={id} role='region' className={clsx('chip-body', noInsets && 'chip-body-no-insets')}>
{children}
{body && body()}
diff --git a/tests/playwright-test/reporter-html.spec.ts b/tests/playwright-test/reporter-html.spec.ts
index 707c4c04b2..9ce7ac74a2 100644
--- a/tests/playwright-test/reporter-html.spec.ts
+++ b/tests/playwright-test/reporter-html.spec.ts
@@ -3431,7 +3431,7 @@ for (const useIntermediateMergeReport of [true, false] as const) {
await expect(page.getByRole('link', { name: 'Speedboard' })).toHaveAttribute('aria-selected', 'true');
await expect(page).toMatchAriaSnapshot(`
- - button "Slowest Tests"
+ - text: /Slowest Tests/
- region:
- list:
- listitem:
@@ -3455,7 +3455,7 @@ for (const useIntermediateMergeReport of [true, false] as const) {
`);
await page.getByText('foo').first().click();
await expect(page).toMatchAriaSnapshot(`
- - button "Slowest Tests"
+ - text: /Slowest Tests/
`);
await page.getByRole('link', { name: 'Failed' }).click();