Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore(bidi): ignore fileDialogOpened event from detached frame (#38589)

Holger Benlb4a9aad32ae6
diff --git a/packages/playwright-core/src/server/bidi/bidiConnection.ts b/packages/playwright-core/src/server/bidi/bidiConnection.ts
index 5dfca87212..5579f2c2d4 100644
--- a/packages/playwright-core/src/server/bidi/bidiConnection.ts
+++ b/packages/playwright-core/src/server/bidi/bidiConnection.ts
@@ -224,6 +224,7 @@ export class BidiSession extends EventEmitter {
this._browsingContexts.clear();
for (const callback of this._callbacks.values()) {
callback.error.type = this._crashed ? 'crashed' : 'closed';
+ callback.error.setMessage(`Internal server error, session ${callback.error.type}.`);
callback.error.logs = this.connection._browserDisconnectedLogs;
callback.reject(callback.error);
}
diff --git a/packages/playwright-core/src/server/bidi/bidiPage.ts b/packages/playwright-core/src/server/bidi/bidiPage.ts
index 9304412533..7b47c062dd 100644
--- a/packages/playwright-core/src/server/bidi/bidiPage.ts
+++ b/packages/playwright-core/src/server/bidi/bidiPage.ts
@@ -297,8 +297,10 @@ export class BidiPage implements PageDelegate {
if (!frame)
return;
const executionContext = await frame._mainContext();
- const handle = await toBidiExecutionContext(executionContext).remoteObjectForNodeId(executionContext, { sharedId: params.element.sharedId });
- await this._page._onFileChooserOpened(handle as dom.ElementHandle);
+ try {
+ const handle = await toBidiExecutionContext(executionContext).remoteObjectForNodeId(executionContext, { sharedId: params.element.sharedId });
+ await this._page._onFileChooserOpened(handle as dom.ElementHandle);
+ } catch {}
}
async navigateFrame(frame: frames.Frame, url: string, referrer: string | undefined): Promise<frames.GotoResult> {