Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore(bidi): hardcode "default" id for persistent context (#35303)

Yury Semikhatskyb9ccc5b252d9
diff --git a/packages/playwright-core/src/server/bidi/bidiBrowser.ts b/packages/playwright-core/src/server/bidi/bidiBrowser.ts
index 1f6b4090d1..c82c64928a 100644
--- a/packages/playwright-core/src/server/bidi/bidiBrowser.ts
+++ b/packages/playwright-core/src/server/bidi/bidiBrowser.ts
@@ -98,13 +98,9 @@ export class BidiBrowser extends Browser {
});
if (options.persistent) {
- const { userContexts } = await browser._browserSession.send('browser.getUserContexts', {});
- if (!userContexts.length)
- throw new Error('Cannot dermine default context id, no contexts found.');
const context = new BidiBrowserContext(browser, undefined, options.persistent);
- context._defaultUserContext = userContexts[0].userContext;
browser._defaultContext = context;
- await (browser._defaultContext as BidiBrowserContext)._initialize();
+ await context._initialize();
// Create default page as we cannot get access to the existing one.
const page = await browser._defaultContext.doCreateNewPage();
await page.waitForInitializedOrError();
@@ -209,7 +205,6 @@ export class BidiBrowser extends Browser {
export class BidiBrowserContext extends BrowserContext {
declare readonly _browser: BidiBrowser;
private _initScriptIds: bidi.Script.PreloadScript[] = [];
- _defaultUserContext: bidi.Browser.UserContext | undefined;
constructor(browser: BidiBrowser, browserContextId: string | undefined, options: types.BrowserContextOptions) {
super(browser, options, browserContextId);
@@ -376,7 +371,9 @@ export class BidiBrowserContext extends BrowserContext {
private _userContextId(): bidi.Browser.UserContext {
if (this._browserContextId)
return this._browserContextId;
- return this._defaultUserContext!;
+ // Default context always has same id, see
+ // https://w3c.github.io/webdriver-bidi/#default-user-context
+ return 'default';
}
}