Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
fix(trace-viewer): label filter inputs and keyboard-accessible error source (#42469)
Changsu Seongba0b817d406c
diff --git a/packages/trace-viewer/src/ui/actionList.css b/packages/trace-viewer/src/ui/actionList.cssindex 7161559c62..b54ec7fd0d 100644--- a/packages/trace-viewer/src/ui/actionList.css+++ b/packages/trace-viewer/src/ui/actionList.css@@ -49,10 +49,20 @@color: var(--vscode-foreground);}-.action-location > span {+.action-location > button {margin: 0 4px;cursor: pointer;text-decoration: underline;+ background: none;+ border: none;+ padding: 0;+ color: inherit;+ font: inherit;+}++.action-location > button:focus-visible {+ outline: 1px solid var(--vscode-focusBorder);+ outline-offset: -1px;}.action-duration {diff --git a/packages/trace-viewer/src/ui/errorsTab.tsx b/packages/trace-viewer/src/ui/errorsTab.tsxindex 36d65c4b7c..a10e0af5d9 100644--- a/packages/trace-viewer/src/ui/errorsTab.tsx+++ b/packages/trace-viewer/src/ui/errorsTab.tsx@@ -73,7 +73,7 @@ function ErrorView({ message, error, sdkLanguage, revealInSource }: { message: s}}>{error.action && renderAction(error.action, { sdkLanguage })}{location && <div className='action-location'>- @ <span title={longLocation} onClick={() => revealInSource(error)}>{location}</span>+ @ <button type='button' title={longLocation} aria-label={`Go to source: ${longLocation}`} onClick={() => revealInSource(error)}>{location}</button></div>}</div>diff --git a/packages/trace-viewer/src/ui/networkFilters.tsx b/packages/trace-viewer/src/ui/networkFilters.tsxindex dedb250dae..a08f9a99cf 100644--- a/packages/trace-viewer/src/ui/networkFilters.tsx+++ b/packages/trace-viewer/src/ui/networkFilters.tsx@@ -35,6 +35,7 @@ export const NetworkFilters = ({ filterState, onFilterStateChange }: {<inputtype='search'placeholder='Filter network'+ aria-label='Filter network'spellCheck={false}value={filterState.searchValue}onChange={e => onFilterStateChange({ ...filterState, searchValue: e.target.value })}diff --git a/packages/trace-viewer/src/ui/uiModeFiltersView.tsx b/packages/trace-viewer/src/ui/uiModeFiltersView.tsxindex 0579a741e1..722f1e758b 100644--- a/packages/trace-viewer/src/ui/uiModeFiltersView.tsx+++ b/packages/trace-viewer/src/ui/uiModeFiltersView.tsx@@ -46,7 +46,7 @@ export const FiltersView: React.FC<{<Expandableexpanded={expanded}setExpanded={setExpanded}- title={<input ref={inputRef} type='search' placeholder='Filter (e.g. text, @tag)' spellCheck={false} value={filterText}+ title={<input ref={inputRef} type='search' placeholder='Filter (e.g. text, @tag)' aria-label='Filter (e.g. text, @tag)' spellCheck={false} value={filterText}onChange={e => {setFilterText(e.target.value);}}diff --git a/tests/library/trace-viewer.spec.ts b/tests/library/trace-viewer.spec.tsindex a88c9cb3b4..7852c68482 100644--- a/tests/library/trace-viewer.spec.ts+++ b/tests/library/trace-viewer.spec.ts@@ -649,6 +649,8 @@ test('should filter network requests by url', async ({ page, runAndTrace, serverawait traceViewer.selectAction('Navigate');await traceViewer.showNetworkTab();+ await expect(traceViewer.page.getByRole('searchbox', { name: 'Filter network' })).toBeVisible();+await traceViewer.page.getByPlaceholder('Filter network').fill('script.');await expect(traceViewer.networkRequests).toHaveCount(1);await expect(traceViewer.networkRequests.getByText('script.js')).toBeVisible();