Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix: do not hang in route.continue with unsafe header (#35201)

Yury Semikhatskyba0bb01114d8
diff --git a/packages/playwright-core/src/server/chromium/crNetworkManager.ts b/packages/playwright-core/src/server/chromium/crNetworkManager.ts
index 812f62dfac..1ea01c17a9 100644
--- a/packages/playwright-core/src/server/chromium/crNetworkManager.ts
+++ b/packages/playwright-core/src/server/chromium/crNetworkManager.ts
@@ -660,6 +660,8 @@ async function catchDisallowedErrors(callback: () => Promise<void>) {
} catch (e) {
if (isProtocolError(e) && e.message.includes('Invalid http status code or phrase'))
throw e;
+ if (isProtocolError(e) && e.message.includes('Unsafe header'))
+ throw e;
}
}
diff --git a/tests/page/page-request-continue.spec.ts b/tests/page/page-request-continue.spec.ts
index 2dd1d66873..bd1d90f333 100644
--- a/tests/page/page-request-continue.spec.ts
+++ b/tests/page/page-request-continue.spec.ts
@@ -26,8 +26,10 @@ it('should work', async ({ page, server }) => {
it('should amend HTTP headers', async ({ page, server }) => {
await page.route('**/*', route => {
- const headers = Object.assign({}, route.request().headers());
- headers['FOO'] = 'bar';
+ const headers = {
+ ...route.request().headers(),
+ FOO: 'bar'
+ };
void route.continue({ headers });
});
await page.goto(server.EMPTY_PAGE);
@@ -38,6 +40,30 @@ it('should amend HTTP headers', async ({ page, server }) => {
expect(request.headers['foo']).toBe('bar');
});
+it('should not allow to override unsafe HTTP headers', async ({ page, server, browserName }) => {
+ let resolve;
+ const routePromise = new Promise<Route>(f => resolve = f);
+ await page.route('**/*', route => resolve(route));
+ const serverRequestPromise = server.waitForRequest('/empty.html');
+ page.goto(server.EMPTY_PAGE).catch(() => {});
+ const route = await routePromise;
+ const error = await route.continue({
+ headers: {
+ ...route.request().headers(),
+ host: 'bar'
+ }
+ }).catch(e => e);
+ if (browserName === 'chromium') {
+ expect(error.message).toContain('Unsafe header: host');
+ } else {
+ expect(error).toBeFalsy();
+ // These lines just document current behavior in FF and WK,
+ // we don't necessarily want to maintain this behavior.
+ const serverRequest = await serverRequestPromise;
+ expect(serverRequest.headers['host']).toBe('bar');
+ }
+});
+
it('should delete header with undefined value', async ({ page, server, browserName }) => {
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/13106' });