Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix(mcp): merge user ignoreDefaultArgs with persistent mode defaults (#40026)

Lennon Wangbabc50480f55
diff --git a/packages/playwright-core/src/tools/mcp/browserFactory.ts b/packages/playwright-core/src/tools/mcp/browserFactory.ts
index dfc1c153ef..e4f92bd241 100644
--- a/packages/playwright-core/src/tools/mcp/browserFactory.ts
+++ b/packages/playwright-core/src/tools/mcp/browserFactory.ts
@@ -145,15 +145,19 @@ async function createPersistentBrowser(config: FullConfig, clientInfo: ClientInf
throw new Error(`Browser is already in use for ${userDataDir}, use --isolated to run multiple instances of the same browser`);
const browserType = playwright[config.browser.browserName];
+ const configIgnoreDefaultArgs = config.browser.launchOptions?.ignoreDefaultArgs;
const launchOptions: playwright.LaunchOptions & playwright.BrowserContextOptions = {
tracesDir,
...config.browser.launchOptions,
...config.browser.contextOptions,
handleSIGINT: false,
handleSIGTERM: false,
- ignoreDefaultArgs: [
- '--disable-extensions',
- ],
+ ignoreDefaultArgs: configIgnoreDefaultArgs === true
+ ? true
+ : [
+ '--disable-extensions',
+ ...Array.isArray(configIgnoreDefaultArgs) ? configIgnoreDefaultArgs : [],
+ ],
};
try {
const browserContext = await browserType.launchPersistentContext(userDataDir, launchOptions);
diff --git a/tests/mcp/config.spec.ts b/tests/mcp/config.spec.ts
index 8dc55216f8..cb42d52145 100644
--- a/tests/mcp/config.spec.ts
+++ b/tests/mcp/config.spec.ts
@@ -104,6 +104,37 @@ test.describe(() => {
});
});
+test('config ignoreDefaultArgs merged with persistent mode defaults', async ({ startClient, mcpBrowser }, testInfo) => {
+ test.skip(!['chrome', 'chromium', 'msedge'].includes(mcpBrowser!), 'chrome://version is Chromium-specific');
+ const config: Config = {
+ browser: {
+ userDataDir: testInfo.outputPath('user-data-dir'),
+ launchOptions: {
+ ignoreDefaultArgs: ['--password-store=basic'],
+ },
+ },
+ };
+ const { client } = await startClient({ config });
+
+ await client.callTool({
+ name: 'browser_navigate',
+ arguments: { url: 'chrome://version' },
+ });
+
+ const result = await client.callTool({
+ name: 'browser_evaluate',
+ arguments: { function: '() => document.getElementById("command_line").innerText' },
+ });
+ const commandLine = result.content[0].text;
+
+ // User-specified arg should be removed.
+ expect(commandLine).not.toContain('--password-store=basic');
+ // Persistent mode's built-in --disable-extensions should also be removed.
+ expect(commandLine).not.toContain('--disable-extensions');
+ // Other default args should still be present.
+ expect(commandLine).toContain('--use-mock-keychain');
+});
+
test('browser_get_config returns merged config from file, env and cli', async ({ startClient }) => {
const { client } = await startClient({
config: {