Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore(bidi): report page errors (#37317)

Holger Benlbaffd849c3c9
diff --git a/packages/playwright-core/src/server/bidi/bidiPage.ts b/packages/playwright-core/src/server/bidi/bidiPage.ts
index d9807955a6..505b1ae5bf 100644
--- a/packages/playwright-core/src/server/bidi/bidiPage.ts
+++ b/packages/playwright-core/src/server/bidi/bidiPage.ts
@@ -18,6 +18,7 @@ import { eventsHelper } from '../utils/eventsHelper';
import * as dialog from '../dialog';
import * as dom from '../dom';
import { Page } from '../page';
+import { BidiBrowserContext } from './bidiBrowser';
import { BidiExecutionContext, createHandle } from './bidiExecutionContext';
import { RawKeyboardImpl, RawMouseImpl, RawTouchscreenImpl } from './bidiInput';
import { BidiNetworkManager } from './bidiNetworkManager';
@@ -30,7 +31,6 @@ import type * as frames from '../frames';
import type { InitScript, PageDelegate } from '../page';
import type { Progress } from '../progress';
import type * as types from '../types';
-import type { BidiBrowserContext } from './bidiBrowser';
import type { BidiSession } from './bidiConnection';
import type * as channels from '@protocol/channels';
@@ -218,6 +218,25 @@ export class BidiPage implements PageDelegate {
}
private _onLogEntryAdded(params: bidi.Log.Entry) {
+ if (params.type === 'javascript' && params.level === 'error') {
+ let errorName = '';
+ let errorMessage: string | undefined;
+ if (params.text?.includes(': ')) {
+ const index = params.text.indexOf(': ');
+ errorName = params.text.substring(0, index);
+ errorMessage = params.text.substring(index + 2);
+ } else {
+ errorMessage = params.text ?? undefined;
+ }
+ const error = new Error(errorMessage);
+ error.name = errorName;
+ error.stack = `${params.text}\n${params.stackTrace?.callFrames.map(f => {
+ const location = `${f.url}:${f.lineNumber + 1}:${f.columnNumber + 1}`;
+ return f.functionName ? ` at ${f.functionName} (${location})` : ` at ${location}`;
+ }).join('\n')}`;
+ this._page.emitOnContextOnceInitialized(BidiBrowserContext.Events.PageError, error, this._page);
+ return;
+ }
if (params.type !== 'console')
return;
const entry: bidi.Log.ConsoleLogEntry = params as bidi.Log.ConsoleLogEntry;
diff --git a/tests/page/page-event-pageerror.spec.ts b/tests/page/page-event-pageerror.spec.ts
index c7fc699683..312ddf0d7f 100644
--- a/tests/page/page-event-pageerror.spec.ts
+++ b/tests/page/page-event-pageerror.spec.ts
@@ -25,7 +25,7 @@ it('should fire', async ({ page, server, browserName }) => {
]);
expect(error.name).toBe('Error');
expect(error.message).toBe('Fancy error!');
- if (browserName === 'chromium') {
+ if (browserName === 'chromium' || browserName === '_bidiChromium' || browserName === '_bidiFirefox') {
expect(error.stack).toBe(`Error: Fancy error!
at c (myscript.js:14:11)
at b (myscript.js:10:5)