Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix(selectors): accept regexp v flag in locator options (#41458)

Omer Murat Aydinbb2dae0059af
diff --git a/packages/isomorphic/selectorParser.ts b/packages/isomorphic/selectorParser.ts
index f37d1ef4c3..c5c322cb7a 100644
--- a/packages/isomorphic/selectorParser.ts
+++ b/packages/isomorphic/selectorParser.ts
@@ -324,7 +324,7 @@ export function parseAttributeSelector(selector: string, allowUnquotedStrings: b
syntaxError('parsing regular expression');
let flags = '';
// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_Expressions
- while (!EOL && next().match(/[dgimsuy]/))
+ while (!EOL && next().match(/[dgimsuvy]/))
flags += eat1();
try {
return new RegExp(source, flags);
diff --git a/tests/page/selectors-get-by.spec.ts b/tests/page/selectors-get-by.spec.ts
index 692de3cc7f..de76065eca 100644
--- a/tests/page/selectors-get-by.spec.ts
+++ b/tests/page/selectors-get-by.spec.ts
@@ -286,6 +286,14 @@ it('getByRole escaping', async ({ page }) => {
]);
});
+it('getByRole should accept regexp with v flag', async ({ page }) => {
+ // Regression test for https://github.com/microsoft/playwright/issues/41457
+ await page.setContent(`<button>Click me</button><button>Submit</button>`);
+ await expect(page.getByRole('button', { name: /Click me/v })).toHaveCount(1);
+ await expect(page.getByRole('button', { name: /click me/iv })).toHaveCount(1);
+ await expect(page.getByRole('button', { name: /Missing/v })).toHaveCount(0, { timeout: 1000 });
+});
+
it('getByRole with description', async ({ page }) => {
await page.setContent(`
<div role="alert" aria-label="Upload successful" aria-description="File doc-2025.pdf was uploaded successfully">Alert 1</div>